[PATCH v2 0/4] powerpc/perf: Miscellaneous fixes
4356d
Revision v2 of 3 in this series.
8 messages,
2 authors,
2014-10-01 · open the first message on its own page
Miscellaenous fixes for perf and 24x7 counters in powerpc.
Patches 1,3,4 were submitted earlier as a part of the parametrized
events for 24x7 counters. But they are not directly related to the
parametrized events.
Patch 2 simplifies and fixes a bug in catalog_read() which causes the
catalog file to not read first page.
Changelog[v2]
Rebase to perf/core tree.
Cody P Schafer (3):
powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack
allocations
perf Documentation: sysfs events/ interfaces
perf Documentation: remove duplicated docs for powerpc cpu specific
events
Sukadev Bhattiprolu (1):
Simplify catalog_read()
.../testing/sysfs-bus-event_source-devices-events | 611 ++-------------------
arch/powerpc/perf/hv-24x7.c | 144 ++---
2 files changed, 96 insertions(+), 659 deletions(-)
--
1.8.3.1
catalog_read() implements the read interface for the sysfs file
/sys/bus/event_source/devices/hv_24x7/interface/catalog
It essentially takes a buffer, an offset and count as parameters
to the read() call. It makes a hypervisor call to read a specific
page from the catalog and copy the required bytes into the given
buffer. Each call to catalog_read() returns at most one 4K page.
Given these requirements, we should be able to simplify the
catalog_read().
Signed-off-by: Sukadev Bhattiprolu <redacted>
---
arch/powerpc/perf/hv-24x7.c | 92 +++++----------------------------------------
1 file changed, 10 insertions(+), 82 deletions(-)
diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
index 2f2215c..9427ef7 100644
--- a/arch/powerpc/perf/hv-24x7.c
+++ b/arch/powerpc/perf/hv-24x7.c @@ -75,86 +75,6 @@ static struct attribute_group format_group = {
static struct kmem_cache * hv_page_cache ;
- /* - * read_offset_data - copy data from one buffer to another while treating the - * source buffer as a small view on the total avaliable - * source data . - * - * @ dest : buffer to copy into - * @ dest_len : length of @ dest in bytes - * @ requested_offset : the offset within the source data we want . Must be > 0 - * @ src : buffer to copy data from - * @ src_len : length of @ src in bytes - * @ source_offset : the offset in the sorce data that ( src , src_len ) refers to . - * Must be > 0 - * - * returns the number of bytes copied . - * - * The following ascii art shows the various buffer possitioning we need to - * handle , assigns some arbitrary varibles to points on the buffer , and then - * shows how we fiddle with those values to get things we care about ( copy - * start in src and copy len ) - * - * s = @ src buffer - * d = @ dest buffer - * '.' areas in d are written to . - * - * u - * x w v z - * d | ......... | - * s |----------------------| - * - * u - * x w z v - * d | ........ ------| - * s |------------------| - * - * x w u , z , v - * d | ........ | - * s |------------------| - * - * x , w u , v , z - * d | .................. | - * s |------------------| - * - * x u - * w v z - * d | ........ | - * s |------------------| - * - * x z w v - * d |------| - * s |------| - * - * x = source_offset - * w = requested_offset - * z = source_offset + src_len - * v = requested_offset + dest_len - * - * w_offset_in_s = w - x = requested_offset - source_offset - * z_offset_in_s = z - x = src_len - * v_offset_in_s = v - x = request_offset + dest_len - src_len - */ - static ssize_t read_offset_data ( void * dest , size_t dest_len , - loff_t requested_offset , void * src , - size_t src_len , loff_t source_offset ) - { - size_t w_offset_in_s = requested_offset - source_offset ; - size_t z_offset_in_s = src_len ; - size_t v_offset_in_s = requested_offset + dest_len - src_len ; - size_t u_offset_in_s = min ( z_offset_in_s , v_offset_in_s ); - size_t copy_len = u_offset_in_s - w_offset_in_s ; - - if ( requested_offset < 0 || source_offset < 0 ) - return - EINVAL ; - - if ( z_offset_in_s <= w_offset_in_s ) - return 0 ; - - memcpy ( dest , src + w_offset_in_s , copy_len ); - return copy_len ; - } - static unsigned long h_get_24x7_catalog_page_ ( unsigned long phys_4096 ,
unsigned long version ,
unsigned long index ) @@ -185,6 +105,8 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
ssize_t ret = 0 ;
size_t catalog_len = 0 , catalog_page_len = 0 , page_count = 0 ;
loff_t page_offset = 0 ;
+ loff_t offset_in_page ; + size_t copy_len ; uint64_t catalog_version_num = 0 ;
void * page = kmem_cache_alloc ( hv_page_cache , GFP_USER );
struct hv_24x7_catalog_page_0 * page_0 = page ; @@ -203,6 +125,7 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
page_offset = offset / 4096 ;
page_count = count / 4096 ;
+ offset_in_page = count % 4096 ;
if ( page_offset >= catalog_page_len )
goto e_free ; @@ -216,8 +139,13 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
}
}
- ret = read_offset_data ( buf , count , offset , - page , 4096 , page_offset * 4096 ); + copy_len = 4096 - offset_in_page ; + if ( copy_len > count ) + copy_len = count ; + + memcpy ( buf , page + offset_in_page , copy_len ); + ret = copy_len ; + e_free :
if ( hret )
pr_err ( "h_get_24x7_catalog_page(ver=%lld, page=%lld) failed:" --
1.8.3.1
From: Cody P Schafer <redacted>
Ian pointed out the use of __aligned(4096) caused rather large stack
consumption in single_24x7_request(), so use the kmem_cache
hv_page_cache (which we've already got set up for other allocations)
insead of allocating locally.
CC: Sukadev Bhattiprolu <redacted>
CC: Haren Myneni <redacted>
CC: Cody P Schafer <redacted>
Reported-by: Ian Munsie <redacted>
Signed-off-by: Cody P Schafer <redacted>
---
arch/powerpc/perf/hv-24x7.c | 52 ++++++++++++++++++++++++++++++++-------------
1 file changed, 37 insertions(+), 15 deletions(-)
diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
index 70d4f74..2f2215c 100644
--- a/arch/powerpc/perf/hv-24x7.c
+++ b/arch/powerpc/perf/hv-24x7.c @@ -294,7 +294,7 @@ static unsigned long single_24x7_request(u8 domain, u32 offset, u16 ix,
u16 lpar , u64 * res ,
bool success_expected )
{
- unsigned long ret ; + unsigned long ret = - ENOMEM ;
/*
* request_buffer and result_buffer are not required to be 4 k aligned , @@ -304,7 +304,27 @@ static unsigned long single_24x7_request(u8 domain, u32 offset, u16 ix,
struct reqb {
struct hv_24x7_request_buffer buf ;
struct hv_24x7_request req ;
- } __packed __aligned ( 4096 ) request_buffer = { + } __packed * request_buffer ; + struct resb { + struct hv_24x7_data_result_buffer buf ; + struct hv_24x7_result res ; + struct hv_24x7_result_element elem ; + __be64 result ; + } __packed * result_buffer ; + + BUILD_BUG_ON ( sizeof ( * request_buffer ) > 4096 ); + BUILD_BUG_ON ( sizeof ( * result_buffer ) > 4096 ); + + request_buffer = kmem_cache_alloc ( hv_page_cache , GFP_USER ); + + if ( ! request_buffer ) + goto out_reqb ; + + result_buffer = kmem_cache_zalloc ( hv_page_cache , GFP_USER ); + if ( ! result_buffer ) + goto out_resb ; + + * request_buffer = ( struct reqb ) { . buf = {
. interface_version = HV_24X7_IF_VERSION_CURRENT ,
. num_requests = 1 , @@ -320,28 +340,30 @@ static unsigned long single_24x7_request(u8 domain, u32 offset, u16 ix,
}
};
- struct resb { - struct hv_24x7_data_result_buffer buf ; - struct hv_24x7_result res ; - struct hv_24x7_result_element elem ; - __be64 result ; - } __packed __aligned ( 4096 ) result_buffer = {}; - ret = plpar_hcall_norets ( H_GET_24X7_DATA ,
- virt_to_phys ( & request_buffer ), sizeof ( request_buffer ), - virt_to_phys ( & result_buffer ), sizeof ( result_buffer )); + virt_to_phys ( request_buffer ), sizeof ( * request_buffer ), + virt_to_phys ( result_buffer ), sizeof ( * result_buffer ));
if ( ret ) {
if ( success_expected )
pr_err_ratelimited ( "hcall failed: %d %#x %#x %d => 0x%lx (%ld) detail=0x%x failing ix=%x \n " ,
domain , offset , ix , lpar ,
ret , ret ,
- result_buffer . buf . detailed_rc , - result_buffer . buf . failing_request_ix ); - return ret ; + result_buffer -> buf . detailed_rc , + result_buffer -> buf . failing_request_ix ); + goto out_hcall ; }
- * res = be64_to_cpu ( result_buffer . result ); + * res = be64_to_cpu ( result_buffer -> result ); + kfree ( result_buffer ); + kfree ( request_buffer ); + return ret ; + + out_hcall : + kfree ( result_buffer ); + out_resb : + kfree ( request_buffer ); + out_reqb : return ret ;
}
--
1.8.3.1
From: Cody P Schafer <redacted>
Add documentation for the <event>, <event>.scale, and <event>.unit
files in sysfs.
<event>.scale and <event>.unit were undocumented.
<event> was previously documented only for specific powerpc pmu events.
CC: Sukadev Bhattiprolu <redacted>
CC: Haren Myneni <redacted>
CC: Cody P Schafer <redacted>
Signed-off-by: Cody P Schafer <redacted>
---
.../testing/sysfs-bus-event_source-devices-events | 60 ++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
index 7b40a3c..a5226f0 100644
--- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
+++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events @@ -599,3 +599,63 @@ Description: POWER-systems specific performance monitoring events
Further, multiple terms like 'event=0xNNNN' can be specified
and separated with comma. All available terms are defined in
the /sys/bus/event_source/devices/<dev>/format file.
+ + What: /sys/bus/event_source/devices/<pmu>/events/<event>+ Date: 2014/02/24+ Contact: Linux kernel mailing list <linux-kernel@vger.kernel.org>+ Description: Per-pmu performance monitoring events specific to the running system+ + Each file (except for some of those with a '.' in them, '.unit'+ and '.scale') in the 'events' directory describes a single+ performance monitoring event supported by the <pmu>. The name+ of the file is the name of the event.+ + File contents:+ + <term>[=<value>][,<term>[=<value>]]...+ + Where <term> is one of the terms listed under+ /sys/bus/event_source/devices/<pmu>/format/ and <value> is+ a number is base-16 format with a '0x' prefix (lowercase only).+ If a <term> is specified alone (without an assigned value), it+ is implied that 0x1 is assigned to that <term>.+ + Examples (each of these lines would be in a seperate file):+ + event=0x2abc+ event=0x423,inv,cmask=0x3+ domain=0x1,offset=0x8,starting_index=0xffff+ + Each of the assignments indicates a value to be assigned to a+ particular set of bits (as defined by the format file+ corresponding to the <term>) in the perf_event structure passed+ to the perf_open syscall.+ + What: /sys/bus/event_source/devices/<pmu>/events/<event>.unit+ Date: 2014/02/24+ Contact: Linux kernel mailing list <linux-kernel@vger.kernel.org>+ Description: Perf event units+ + A string specifying the English plural numerical unit that <event>+ (once multiplied by <event>.scale) represents.+ + Example:+ + Joules+ + What: /sys/bus/event_source/devices/<pmu>/events/<event>.scale+ Date: 2014/02/24+ Contact: Linux kernel mailing list <linux-kernel@vger.kernel.org>+ Description: Perf event scaling factors+ + A string representing a floating point value expressed in+ scientific notation to be multiplied by the event count+ recieved from the kernel to match the unit specified in the+ <event>.unit file.+ + Example:+ + 2.3283064365386962890625e-10+ + This is provided to avoid performing floating point arithmetic+ in the kernel.--
1.8.3.1
From: Cody P Schafer <redacted>
Listing specific events doesn't actually help us at all here because:
- these events actually vary between different ppc processors, they
aren't garunteed to be present.
- the documentation of the (generic) file contents is now superceded by the
docs for arbitrary event file contents.
CC: Sukadev Bhattiprolu <redacted>
CC: Haren Myneni <redacted>
CC: Cody P Schafer <redacted>
Signed-off-by: Cody P Schafer <redacted>
---
.../testing/sysfs-bus-event_source-devices-events | 573 ---------------------
1 file changed, 573 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
index a5226f0..20979f8 100644
--- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
+++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events @@ -27,579 +27,6 @@ Description: Generic performance monitoring events
"basename".
- What: /sys/devices/cpu/events/PM_1PLUS_PPC_CMPL- /sys/devices/cpu/events/PM_BRU_FIN- /sys/devices/cpu/events/PM_BR_MPRED- /sys/devices/cpu/events/PM_CMPLU_STALL- /sys/devices/cpu/events/PM_CMPLU_STALL_BRU- /sys/devices/cpu/events/PM_CMPLU_STALL_DCACHE_MISS- /sys/devices/cpu/events/PM_CMPLU_STALL_DFU- /sys/devices/cpu/events/PM_CMPLU_STALL_DIV- /sys/devices/cpu/events/PM_CMPLU_STALL_ERAT_MISS- /sys/devices/cpu/events/PM_CMPLU_STALL_FXU- /sys/devices/cpu/events/PM_CMPLU_STALL_IFU- /sys/devices/cpu/events/PM_CMPLU_STALL_LSU- /sys/devices/cpu/events/PM_CMPLU_STALL_REJECT- /sys/devices/cpu/events/PM_CMPLU_STALL_SCALAR- /sys/devices/cpu/events/PM_CMPLU_STALL_SCALAR_LONG- /sys/devices/cpu/events/PM_CMPLU_STALL_STORE- /sys/devices/cpu/events/PM_CMPLU_STALL_THRD- /sys/devices/cpu/events/PM_CMPLU_STALL_VECTOR- /sys/devices/cpu/events/PM_CMPLU_STALL_VECTOR_LONG- /sys/devices/cpu/events/PM_CYC- /sys/devices/cpu/events/PM_GCT_NOSLOT_BR_MPRED- /sys/devices/cpu/events/PM_GCT_NOSLOT_BR_MPRED_IC_MISS- /sys/devices/cpu/events/PM_GCT_NOSLOT_CYC- /sys/devices/cpu/events/PM_GCT_NOSLOT_IC_MISS- /sys/devices/cpu/events/PM_GRP_CMPL- /sys/devices/cpu/events/PM_INST_CMPL- /sys/devices/cpu/events/PM_LD_MISS_L1- /sys/devices/cpu/events/PM_LD_REF_L1- /sys/devices/cpu/events/PM_RUN_CYC- /sys/devices/cpu/events/PM_RUN_INST_CMPL- /sys/devices/cpu/events/PM_IC_DEMAND_L2_BR_ALL- /sys/devices/cpu/events/PM_GCT_UTIL_7_TO_10_SLOTS- /sys/devices/cpu/events/PM_PMC2_SAVED- /sys/devices/cpu/events/PM_VSU0_16FLOP- /sys/devices/cpu/events/PM_MRK_LSU_DERAT_MISS- /sys/devices/cpu/events/PM_MRK_ST_CMPL- /sys/devices/cpu/events/PM_NEST_PAIR3_ADD- /sys/devices/cpu/events/PM_L2_ST_DISP- /sys/devices/cpu/events/PM_L2_CASTOUT_MOD- /sys/devices/cpu/events/PM_ISEG- /sys/devices/cpu/events/PM_MRK_INST_TIMEO- /sys/devices/cpu/events/PM_L2_RCST_DISP_FAIL_ADDR- /sys/devices/cpu/events/PM_LSU1_DC_PREF_STREAM_CONFIRM- /sys/devices/cpu/events/PM_IERAT_WR_64K- /sys/devices/cpu/events/PM_MRK_DTLB_MISS_16M- /sys/devices/cpu/events/PM_IERAT_MISS- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_LMEM- /sys/devices/cpu/events/PM_FLOP- /sys/devices/cpu/events/PM_THRD_PRIO_4_5_CYC- /sys/devices/cpu/events/PM_BR_PRED_TA- /sys/devices/cpu/events/PM_EXT_INT- /sys/devices/cpu/events/PM_VSU_FSQRT_FDIV- /sys/devices/cpu/events/PM_MRK_LD_MISS_EXPOSED_CYC- /sys/devices/cpu/events/PM_LSU1_LDF- /sys/devices/cpu/events/PM_IC_WRITE_ALL- /sys/devices/cpu/events/PM_LSU0_SRQ_STFWD- /sys/devices/cpu/events/PM_PTEG_FROM_RL2L3_MOD- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L31_SHR- /sys/devices/cpu/events/PM_DATA_FROM_L21_MOD- /sys/devices/cpu/events/PM_VSU1_SCAL_DOUBLE_ISSUED- /sys/devices/cpu/events/PM_VSU0_8FLOP- /sys/devices/cpu/events/PM_POWER_EVENT1- /sys/devices/cpu/events/PM_DISP_CLB_HELD_BAL- /sys/devices/cpu/events/PM_VSU1_2FLOP- /sys/devices/cpu/events/PM_LWSYNC_HELD- /sys/devices/cpu/events/PM_PTEG_FROM_DL2L3_SHR- /sys/devices/cpu/events/PM_INST_FROM_L21_MOD- /sys/devices/cpu/events/PM_IERAT_XLATE_WR_16MPLUS- /sys/devices/cpu/events/PM_IC_REQ_ALL- /sys/devices/cpu/events/PM_DSLB_MISS- /sys/devices/cpu/events/PM_L3_MISS- /sys/devices/cpu/events/PM_LSU0_L1_PREF- /sys/devices/cpu/events/PM_VSU_SCALAR_SINGLE_ISSUED- /sys/devices/cpu/events/PM_LSU1_DC_PREF_STREAM_CONFIRM_STRIDE- /sys/devices/cpu/events/PM_L2_INST- /sys/devices/cpu/events/PM_VSU0_FRSP- /sys/devices/cpu/events/PM_FLUSH_DISP- /sys/devices/cpu/events/PM_PTEG_FROM_L2MISS- /sys/devices/cpu/events/PM_VSU1_DQ_ISSUED- /sys/devices/cpu/events/PM_MRK_DATA_FROM_DMEM- /sys/devices/cpu/events/PM_LSU_FLUSH_ULD- /sys/devices/cpu/events/PM_PTEG_FROM_LMEM- /sys/devices/cpu/events/PM_MRK_DERAT_MISS_16M- /sys/devices/cpu/events/PM_THRD_ALL_RUN_CYC- /sys/devices/cpu/events/PM_MEM0_PREFETCH_DISP- /sys/devices/cpu/events/PM_MRK_STALL_CMPLU_CYC_COUNT- /sys/devices/cpu/events/PM_DATA_FROM_DL2L3_MOD- /sys/devices/cpu/events/PM_VSU_FRSP- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L21_MOD- /sys/devices/cpu/events/PM_PMC1_OVERFLOW- /sys/devices/cpu/events/PM_VSU0_SINGLE- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_L3MISS- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_L31_SHR- /sys/devices/cpu/events/PM_VSU0_VECTOR_SP_ISSUED- /sys/devices/cpu/events/PM_VSU1_FEST- /sys/devices/cpu/events/PM_MRK_INST_DISP- /sys/devices/cpu/events/PM_VSU0_COMPLEX_ISSUED- /sys/devices/cpu/events/PM_LSU1_FLUSH_UST- /sys/devices/cpu/events/PM_FXU_IDLE- /sys/devices/cpu/events/PM_LSU0_FLUSH_ULD- /sys/devices/cpu/events/PM_MRK_DATA_FROM_DL2L3_MOD- /sys/devices/cpu/events/PM_LSU_LMQ_SRQ_EMPTY_ALL_CYC- /sys/devices/cpu/events/PM_LSU1_REJECT_LMQ_FULL- /sys/devices/cpu/events/PM_INST_PTEG_FROM_L21_MOD- /sys/devices/cpu/events/PM_INST_FROM_RL2L3_MOD- /sys/devices/cpu/events/PM_SHL_CREATED- /sys/devices/cpu/events/PM_L2_ST_HIT- /sys/devices/cpu/events/PM_DATA_FROM_DMEM- /sys/devices/cpu/events/PM_L3_LD_MISS- /sys/devices/cpu/events/PM_FXU1_BUSY_FXU0_IDLE- /sys/devices/cpu/events/PM_DISP_CLB_HELD_RES- /sys/devices/cpu/events/PM_L2_SN_SX_I_DONE- /sys/devices/cpu/events/PM_STCX_CMPL- /sys/devices/cpu/events/PM_VSU0_2FLOP- /sys/devices/cpu/events/PM_L3_PREF_MISS- /sys/devices/cpu/events/PM_LSU_SRQ_SYNC_CYC- /sys/devices/cpu/events/PM_LSU_REJECT_ERAT_MISS- /sys/devices/cpu/events/PM_L1_ICACHE_MISS- /sys/devices/cpu/events/PM_LSU1_FLUSH_SRQ- /sys/devices/cpu/events/PM_LD_REF_L1_LSU0- /sys/devices/cpu/events/PM_VSU0_FEST- /sys/devices/cpu/events/PM_VSU_VECTOR_SINGLE_ISSUED- /sys/devices/cpu/events/PM_FREQ_UP- /sys/devices/cpu/events/PM_DATA_FROM_LMEM- /sys/devices/cpu/events/PM_LSU1_LDX- /sys/devices/cpu/events/PM_PMC3_OVERFLOW- /sys/devices/cpu/events/PM_MRK_BR_MPRED- /sys/devices/cpu/events/PM_SHL_MATCH- /sys/devices/cpu/events/PM_MRK_BR_TAKEN- /sys/devices/cpu/events/PM_ISLB_MISS- /sys/devices/cpu/events/PM_DISP_HELD_THERMAL- /sys/devices/cpu/events/PM_INST_PTEG_FROM_RL2L3_SHR- /sys/devices/cpu/events/PM_LSU1_SRQ_STFWD- /sys/devices/cpu/events/PM_PTEG_FROM_DMEM- /sys/devices/cpu/events/PM_VSU_2FLOP- /sys/devices/cpu/events/PM_GCT_FULL_CYC- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L3_CYC- /sys/devices/cpu/events/PM_LSU_SRQ_S0_ALLOC- /sys/devices/cpu/events/PM_MRK_DERAT_MISS_4K- /sys/devices/cpu/events/PM_BR_MPRED_TA- /sys/devices/cpu/events/PM_INST_PTEG_FROM_L2MISS- /sys/devices/cpu/events/PM_DPU_HELD_POWER- /sys/devices/cpu/events/PM_MRK_VSU_FIN- /sys/devices/cpu/events/PM_LSU_SRQ_S0_VALID- /sys/devices/cpu/events/PM_GCT_EMPTY_CYC- /sys/devices/cpu/events/PM_IOPS_DISP- /sys/devices/cpu/events/PM_RUN_SPURR- /sys/devices/cpu/events/PM_PTEG_FROM_L21_MOD- /sys/devices/cpu/events/PM_VSU0_1FLOP- /sys/devices/cpu/events/PM_SNOOP_TLBIE- /sys/devices/cpu/events/PM_DATA_FROM_L3MISS- /sys/devices/cpu/events/PM_VSU_SINGLE- /sys/devices/cpu/events/PM_DTLB_MISS_16G- /sys/devices/cpu/events/PM_FLUSH- /sys/devices/cpu/events/PM_L2_LD_HIT- /sys/devices/cpu/events/PM_NEST_PAIR2_AND- /sys/devices/cpu/events/PM_VSU1_1FLOP- /sys/devices/cpu/events/PM_IC_PREF_REQ- /sys/devices/cpu/events/PM_L3_LD_HIT- /sys/devices/cpu/events/PM_DISP_HELD- /sys/devices/cpu/events/PM_L2_LD- /sys/devices/cpu/events/PM_LSU_FLUSH_SRQ- /sys/devices/cpu/events/PM_BC_PLUS_8_CONV- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L31_MOD_CYC- /sys/devices/cpu/events/PM_L2_RCST_BUSY_RC_FULL- /sys/devices/cpu/events/PM_TB_BIT_TRANS- /sys/devices/cpu/events/PM_THERMAL_MAX- /sys/devices/cpu/events/PM_LSU1_FLUSH_ULD- /sys/devices/cpu/events/PM_LSU1_REJECT_LHS- /sys/devices/cpu/events/PM_LSU_LRQ_S0_ALLOC- /sys/devices/cpu/events/PM_L3_CO_L31- /sys/devices/cpu/events/PM_POWER_EVENT4- /sys/devices/cpu/events/PM_DATA_FROM_L31_SHR- /sys/devices/cpu/events/PM_BR_UNCOND- /sys/devices/cpu/events/PM_LSU1_DC_PREF_STREAM_ALLOC- /sys/devices/cpu/events/PM_PMC4_REWIND- /sys/devices/cpu/events/PM_L2_RCLD_DISP- /sys/devices/cpu/events/PM_THRD_PRIO_2_3_CYC- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_L2MISS- /sys/devices/cpu/events/PM_IC_DEMAND_L2_BHT_REDIRECT- /sys/devices/cpu/events/PM_DATA_FROM_L31_SHR- /sys/devices/cpu/events/PM_IC_PREF_CANCEL_L2- /sys/devices/cpu/events/PM_MRK_FIN_STALL_CYC_COUNT- /sys/devices/cpu/events/PM_BR_PRED_CCACHE- /sys/devices/cpu/events/PM_GCT_UTIL_1_TO_2_SLOTS- /sys/devices/cpu/events/PM_MRK_ST_CMPL_INT- /sys/devices/cpu/events/PM_LSU_TWO_TABLEWALK_CYC- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L3MISS- /sys/devices/cpu/events/PM_LSU_SET_MPRED- /sys/devices/cpu/events/PM_FLUSH_DISP_TLBIE- /sys/devices/cpu/events/PM_VSU1_FCONV- /sys/devices/cpu/events/PM_DERAT_MISS_16G- /sys/devices/cpu/events/PM_INST_FROM_LMEM- /sys/devices/cpu/events/PM_IC_DEMAND_L2_BR_REDIRECT- /sys/devices/cpu/events/PM_INST_PTEG_FROM_L2- /sys/devices/cpu/events/PM_PTEG_FROM_L2- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L21_SHR_CYC- /sys/devices/cpu/events/PM_MRK_DTLB_MISS_4K- /sys/devices/cpu/events/PM_VSU0_FPSCR- /sys/devices/cpu/events/PM_VSU1_VECT_DOUBLE_ISSUED- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_RL2L3_MOD- /sys/devices/cpu/events/PM_MEM0_RQ_DISP- /sys/devices/cpu/events/PM_L2_LD_MISS- /sys/devices/cpu/events/PM_VMX_RESULT_SAT_1- /sys/devices/cpu/events/PM_L1_PREF- /sys/devices/cpu/events/PM_MRK_DATA_FROM_LMEM_CYC- /sys/devices/cpu/events/PM_GRP_IC_MISS_NONSPEC- /sys/devices/cpu/events/PM_PB_NODE_PUMP- /sys/devices/cpu/events/PM_SHL_MERGED- /sys/devices/cpu/events/PM_NEST_PAIR1_ADD- /sys/devices/cpu/events/PM_DATA_FROM_L3- /sys/devices/cpu/events/PM_LSU_FLUSH- /sys/devices/cpu/events/PM_LSU_SRQ_SYNC_COUNT- /sys/devices/cpu/events/PM_PMC2_OVERFLOW- /sys/devices/cpu/events/PM_LSU_LDF- /sys/devices/cpu/events/PM_POWER_EVENT3- /sys/devices/cpu/events/PM_DISP_WT- /sys/devices/cpu/events/PM_IC_BANK_CONFLICT- /sys/devices/cpu/events/PM_BR_MPRED_CR_TA- /sys/devices/cpu/events/PM_L2_INST_MISS- /sys/devices/cpu/events/PM_NEST_PAIR2_ADD- /sys/devices/cpu/events/PM_MRK_LSU_FLUSH- /sys/devices/cpu/events/PM_L2_LDST- /sys/devices/cpu/events/PM_INST_FROM_L31_SHR- /sys/devices/cpu/events/PM_VSU0_FIN- /sys/devices/cpu/events/PM_VSU1_FCONV- /sys/devices/cpu/events/PM_INST_FROM_RMEM- /sys/devices/cpu/events/PM_DISP_CLB_HELD_TLBIE- /sys/devices/cpu/events/PM_MRK_DATA_FROM_DMEM_CYC- /sys/devices/cpu/events/PM_BR_PRED_CR- /sys/devices/cpu/events/PM_LSU_REJECT- /sys/devices/cpu/events/PM_GCT_UTIL_3_TO_6_SLOTS- /sys/devices/cpu/events/PM_CMPLU_STALL_END_GCT_NOSLOT- /sys/devices/cpu/events/PM_LSU0_REJECT_LMQ_FULL- /sys/devices/cpu/events/PM_VSU_FEST- /sys/devices/cpu/events/PM_NEST_PAIR0_AND- /sys/devices/cpu/events/PM_PTEG_FROM_L3- /sys/devices/cpu/events/PM_POWER_EVENT2- /sys/devices/cpu/events/PM_IC_PREF_CANCEL_PAGE- /sys/devices/cpu/events/PM_VSU0_FSQRT_FDIV- /sys/devices/cpu/events/PM_MRK_GRP_CMPL- /sys/devices/cpu/events/PM_VSU0_SCAL_DOUBLE_ISSUED- /sys/devices/cpu/events/PM_GRP_DISP- /sys/devices/cpu/events/PM_LSU0_LDX- /sys/devices/cpu/events/PM_DATA_FROM_L2- /sys/devices/cpu/events/PM_MRK_DATA_FROM_RL2L3_MOD- /sys/devices/cpu/events/PM_VSU0_VECT_DOUBLE_ISSUED- /sys/devices/cpu/events/PM_VSU1_2FLOP_DOUBLE- /sys/devices/cpu/events/PM_THRD_PRIO_6_7_CYC- /sys/devices/cpu/events/PM_BC_PLUS_8_RSLV_TAKEN- /sys/devices/cpu/events/PM_BR_MPRED_CR- /sys/devices/cpu/events/PM_L3_CO_MEM- /sys/devices/cpu/events/PM_DATA_FROM_RL2L3_MOD- /sys/devices/cpu/events/PM_LSU_SRQ_FULL_CYC- /sys/devices/cpu/events/PM_TABLEWALK_CYC- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_RMEM- /sys/devices/cpu/events/PM_LSU_SRQ_STFWD- /sys/devices/cpu/events/PM_INST_PTEG_FROM_RMEM- /sys/devices/cpu/events/PM_FXU0_FIN- /sys/devices/cpu/events/PM_LSU1_L1_SW_PREF- /sys/devices/cpu/events/PM_PTEG_FROM_L31_MOD- /sys/devices/cpu/events/PM_PMC5_OVERFLOW- /sys/devices/cpu/events/PM_LD_REF_L1_LSU1- /sys/devices/cpu/events/PM_INST_PTEG_FROM_L21_SHR- /sys/devices/cpu/events/PM_DATA_FROM_RMEM- /sys/devices/cpu/events/PM_VSU0_SCAL_SINGLE_ISSUED- /sys/devices/cpu/events/PM_BR_MPRED_LSTACK- /sys/devices/cpu/events/PM_MRK_DATA_FROM_RL2L3_MOD_CYC- /sys/devices/cpu/events/PM_LSU0_FLUSH_UST- /sys/devices/cpu/events/PM_LSU_NCST- /sys/devices/cpu/events/PM_BR_TAKEN- /sys/devices/cpu/events/PM_INST_PTEG_FROM_LMEM- /sys/devices/cpu/events/PM_DTLB_MISS_4K- /sys/devices/cpu/events/PM_PMC4_SAVED- /sys/devices/cpu/events/PM_VSU1_PERMUTE_ISSUED- /sys/devices/cpu/events/PM_SLB_MISS- /sys/devices/cpu/events/PM_LSU1_FLUSH_LRQ- /sys/devices/cpu/events/PM_DTLB_MISS- /sys/devices/cpu/events/PM_VSU1_FRSP- /sys/devices/cpu/events/PM_VSU_VECTOR_DOUBLE_ISSUED- /sys/devices/cpu/events/PM_L2_CASTOUT_SHR- /sys/devices/cpu/events/PM_DATA_FROM_DL2L3_SHR- /sys/devices/cpu/events/PM_VSU1_STF- /sys/devices/cpu/events/PM_ST_FIN- /sys/devices/cpu/events/PM_PTEG_FROM_L21_SHR- /sys/devices/cpu/events/PM_L2_LOC_GUESS_WRONG- /sys/devices/cpu/events/PM_MRK_STCX_FAIL- /sys/devices/cpu/events/PM_LSU0_REJECT_LHS- /sys/devices/cpu/events/PM_IC_PREF_CANCEL_HIT- /sys/devices/cpu/events/PM_L3_PREF_BUSY- /sys/devices/cpu/events/PM_MRK_BRU_FIN- /sys/devices/cpu/events/PM_LSU1_NCLD- /sys/devices/cpu/events/PM_INST_PTEG_FROM_L31_MOD- /sys/devices/cpu/events/PM_LSU_NCLD- /sys/devices/cpu/events/PM_LSU_LDX- /sys/devices/cpu/events/PM_L2_LOC_GUESS_CORRECT- /sys/devices/cpu/events/PM_THRESH_TIMEO- /sys/devices/cpu/events/PM_L3_PREF_ST- /sys/devices/cpu/events/PM_DISP_CLB_HELD_SYNC- /sys/devices/cpu/events/PM_VSU_SIMPLE_ISSUED- /sys/devices/cpu/events/PM_VSU1_SINGLE- /sys/devices/cpu/events/PM_DATA_TABLEWALK_CYC- /sys/devices/cpu/events/PM_L2_RC_ST_DONE- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_L21_MOD- /sys/devices/cpu/events/PM_LARX_LSU1- /sys/devices/cpu/events/PM_MRK_DATA_FROM_RMEM- /sys/devices/cpu/events/PM_DISP_CLB_HELD- /sys/devices/cpu/events/PM_DERAT_MISS_4K- /sys/devices/cpu/events/PM_L2_RCLD_DISP_FAIL_ADDR- /sys/devices/cpu/events/PM_SEG_EXCEPTION- /sys/devices/cpu/events/PM_FLUSH_DISP_SB- /sys/devices/cpu/events/PM_L2_DC_INV- /sys/devices/cpu/events/PM_PTEG_FROM_DL2L3_MOD- /sys/devices/cpu/events/PM_DSEG- /sys/devices/cpu/events/PM_BR_PRED_LSTACK- /sys/devices/cpu/events/PM_VSU0_STF- /sys/devices/cpu/events/PM_LSU_FX_FIN- /sys/devices/cpu/events/PM_DERAT_MISS_16M- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_DL2L3_MOD- /sys/devices/cpu/events/PM_GCT_UTIL_11_PLUS_SLOTS- /sys/devices/cpu/events/PM_INST_FROM_L3- /sys/devices/cpu/events/PM_MRK_IFU_FIN- /sys/devices/cpu/events/PM_ITLB_MISS- /sys/devices/cpu/events/PM_VSU_STF- /sys/devices/cpu/events/PM_LSU_FLUSH_UST- /sys/devices/cpu/events/PM_L2_LDST_MISS- /sys/devices/cpu/events/PM_FXU1_FIN- /sys/devices/cpu/events/PM_SHL_DEALLOCATED- /sys/devices/cpu/events/PM_L2_SN_M_WR_DONE- /sys/devices/cpu/events/PM_LSU_REJECT_SET_MPRED- /sys/devices/cpu/events/PM_L3_PREF_LD- /sys/devices/cpu/events/PM_L2_SN_M_RD_DONE- /sys/devices/cpu/events/PM_MRK_DERAT_MISS_16G- /sys/devices/cpu/events/PM_VSU_FCONV- /sys/devices/cpu/events/PM_ANY_THRD_RUN_CYC- /sys/devices/cpu/events/PM_LSU_LMQ_FULL_CYC- /sys/devices/cpu/events/PM_MRK_LSU_REJECT_LHS- /sys/devices/cpu/events/PM_MRK_LD_MISS_L1_CYC- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L2_CYC- /sys/devices/cpu/events/PM_INST_IMC_MATCH_DISP- /sys/devices/cpu/events/PM_MRK_DATA_FROM_RMEM_CYC- /sys/devices/cpu/events/PM_VSU0_SIMPLE_ISSUED- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_RL2L3_SHR- /sys/devices/cpu/events/PM_VSU_FMA_DOUBLE- /sys/devices/cpu/events/PM_VSU_4FLOP- /sys/devices/cpu/events/PM_VSU1_FIN- /sys/devices/cpu/events/PM_NEST_PAIR1_AND- /sys/devices/cpu/events/PM_INST_PTEG_FROM_RL2L3_MOD- /sys/devices/cpu/events/PM_PTEG_FROM_RMEM- /sys/devices/cpu/events/PM_LSU_LRQ_S0_VALID- /sys/devices/cpu/events/PM_LSU0_LDF- /sys/devices/cpu/events/PM_FLUSH_COMPLETION- /sys/devices/cpu/events/PM_ST_MISS_L1- /sys/devices/cpu/events/PM_L2_NODE_PUMP- /sys/devices/cpu/events/PM_INST_FROM_DL2L3_SHR- /sys/devices/cpu/events/PM_MRK_STALL_CMPLU_CYC- /sys/devices/cpu/events/PM_VSU1_DENORM- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L31_SHR_CYC- /sys/devices/cpu/events/PM_NEST_PAIR0_ADD- /sys/devices/cpu/events/PM_INST_FROM_L3MISS- /sys/devices/cpu/events/PM_EE_OFF_EXT_INT- /sys/devices/cpu/events/PM_INST_PTEG_FROM_DMEM- /sys/devices/cpu/events/PM_INST_FROM_DL2L3_MOD- /sys/devices/cpu/events/PM_PMC6_OVERFLOW- /sys/devices/cpu/events/PM_VSU_2FLOP_DOUBLE- /sys/devices/cpu/events/PM_TLB_MISS- /sys/devices/cpu/events/PM_FXU_BUSY- /sys/devices/cpu/events/PM_L2_RCLD_DISP_FAIL_OTHER- /sys/devices/cpu/events/PM_LSU_REJECT_LMQ_FULL- /sys/devices/cpu/events/PM_IC_RELOAD_SHR- /sys/devices/cpu/events/PM_GRP_MRK- /sys/devices/cpu/events/PM_MRK_ST_NEST- /sys/devices/cpu/events/PM_VSU1_FSQRT_FDIV- /sys/devices/cpu/events/PM_LSU0_FLUSH_LRQ- /sys/devices/cpu/events/PM_LARX_LSU0- /sys/devices/cpu/events/PM_IBUF_FULL_CYC- /sys/devices/cpu/events/PM_MRK_DATA_FROM_DL2L3_SHR_CYC- /sys/devices/cpu/events/PM_LSU_DC_PREF_STREAM_ALLOC- /sys/devices/cpu/events/PM_GRP_MRK_CYC- /sys/devices/cpu/events/PM_MRK_DATA_FROM_RL2L3_SHR_CYC- /sys/devices/cpu/events/PM_L2_GLOB_GUESS_CORRECT- /sys/devices/cpu/events/PM_LSU_REJECT_LHS- /sys/devices/cpu/events/PM_MRK_DATA_FROM_LMEM- /sys/devices/cpu/events/PM_INST_PTEG_FROM_L3- /sys/devices/cpu/events/PM_FREQ_DOWN- /sys/devices/cpu/events/PM_PB_RETRY_NODE_PUMP- /sys/devices/cpu/events/PM_INST_FROM_RL2L3_SHR- /sys/devices/cpu/events/PM_MRK_INST_ISSUED- /sys/devices/cpu/events/PM_PTEG_FROM_L3MISS- /sys/devices/cpu/events/PM_RUN_PURR- /sys/devices/cpu/events/PM_MRK_GRP_IC_MISS- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L3- /sys/devices/cpu/events/PM_PTEG_FROM_RL2L3_SHR- /sys/devices/cpu/events/PM_LSU_FLUSH_LRQ- /sys/devices/cpu/events/PM_MRK_DERAT_MISS_64K- /sys/devices/cpu/events/PM_INST_PTEG_FROM_DL2L3_MOD- /sys/devices/cpu/events/PM_L2_ST_MISS- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_L21_SHR- /sys/devices/cpu/events/PM_LWSYNC- /sys/devices/cpu/events/PM_LSU0_DC_PREF_STREAM_CONFIRM_STRIDE- /sys/devices/cpu/events/PM_MRK_LSU_FLUSH_LRQ- /sys/devices/cpu/events/PM_INST_IMC_MATCH_CMPL- /sys/devices/cpu/events/PM_NEST_PAIR3_AND- /sys/devices/cpu/events/PM_PB_RETRY_SYS_PUMP- /sys/devices/cpu/events/PM_MRK_INST_FIN- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_DL2L3_SHR- /sys/devices/cpu/events/PM_INST_FROM_L31_MOD- /sys/devices/cpu/events/PM_MRK_DTLB_MISS_64K- /sys/devices/cpu/events/PM_LSU_FIN- /sys/devices/cpu/events/PM_MRK_LSU_REJECT- /sys/devices/cpu/events/PM_L2_CO_FAIL_BUSY- /sys/devices/cpu/events/PM_MEM0_WQ_DISP- /sys/devices/cpu/events/PM_DATA_FROM_L31_MOD- /sys/devices/cpu/events/PM_THERMAL_WARN- /sys/devices/cpu/events/PM_VSU0_4FLOP- /sys/devices/cpu/events/PM_BR_MPRED_CCACHE- /sys/devices/cpu/events/PM_L1_DEMAND_WRITE- /sys/devices/cpu/events/PM_FLUSH_BR_MPRED- /sys/devices/cpu/events/PM_MRK_DTLB_MISS_16G- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_DMEM- /sys/devices/cpu/events/PM_L2_RCST_DISP- /sys/devices/cpu/events/PM_LSU_PARTIAL_CDF- /sys/devices/cpu/events/PM_DISP_CLB_HELD_SB- /sys/devices/cpu/events/PM_VSU0_FMA_DOUBLE- /sys/devices/cpu/events/PM_FXU0_BUSY_FXU1_IDLE- /sys/devices/cpu/events/PM_IC_DEMAND_CYC- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L21_SHR- /sys/devices/cpu/events/PM_MRK_LSU_FLUSH_UST- /sys/devices/cpu/events/PM_INST_PTEG_FROM_L3MISS- /sys/devices/cpu/events/PM_VSU_DENORM- /sys/devices/cpu/events/PM_MRK_LSU_PARTIAL_CDF- /sys/devices/cpu/events/PM_INST_FROM_L21_SHR- /sys/devices/cpu/events/PM_IC_PREF_WRITE- /sys/devices/cpu/events/PM_BR_PRED- /sys/devices/cpu/events/PM_INST_FROM_DMEM- /sys/devices/cpu/events/PM_IC_PREF_CANCEL_ALL- /sys/devices/cpu/events/PM_LSU_DC_PREF_STREAM_CONFIRM- /sys/devices/cpu/events/PM_MRK_LSU_FLUSH_SRQ- /sys/devices/cpu/events/PM_MRK_FIN_STALL_CYC- /sys/devices/cpu/events/PM_L2_RCST_DISP_FAIL_OTHER- /sys/devices/cpu/events/PM_VSU1_DD_ISSUED- /sys/devices/cpu/events/PM_PTEG_FROM_L31_SHR- /sys/devices/cpu/events/PM_DATA_FROM_L21_SHR- /sys/devices/cpu/events/PM_LSU0_NCLD- /sys/devices/cpu/events/PM_VSU1_4FLOP- /sys/devices/cpu/events/PM_VSU1_8FLOP- /sys/devices/cpu/events/PM_VSU_8FLOP- /sys/devices/cpu/events/PM_LSU_LMQ_SRQ_EMPTY_CYC- /sys/devices/cpu/events/PM_DTLB_MISS_64K- /sys/devices/cpu/events/PM_THRD_CONC_RUN_INST- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_L2- /sys/devices/cpu/events/PM_PB_SYS_PUMP- /sys/devices/cpu/events/PM_VSU_FIN- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L31_MOD- /sys/devices/cpu/events/PM_THRD_PRIO_0_1_CYC- /sys/devices/cpu/events/PM_DERAT_MISS_64K- /sys/devices/cpu/events/PM_PMC2_REWIND- /sys/devices/cpu/events/PM_INST_FROM_L2- /sys/devices/cpu/events/PM_GRP_BR_MPRED_NONSPEC- /sys/devices/cpu/events/PM_INST_DISP- /sys/devices/cpu/events/PM_MEM0_RD_CANCEL_TOTAL- /sys/devices/cpu/events/PM_LSU0_DC_PREF_STREAM_CONFIRM- /sys/devices/cpu/events/PM_L1_DCACHE_RELOAD_VALID- /sys/devices/cpu/events/PM_VSU_SCALAR_DOUBLE_ISSUED- /sys/devices/cpu/events/PM_L3_PREF_HIT- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_L31_MOD- /sys/devices/cpu/events/PM_MRK_FXU_FIN- /sys/devices/cpu/events/PM_PMC4_OVERFLOW- /sys/devices/cpu/events/PM_MRK_PTEG_FROM_L3- /sys/devices/cpu/events/PM_LSU0_LMQ_LHR_MERGE- /sys/devices/cpu/events/PM_BTAC_HIT- /sys/devices/cpu/events/PM_L3_RD_BUSY- /sys/devices/cpu/events/PM_LSU0_L1_SW_PREF- /sys/devices/cpu/events/PM_INST_FROM_L2MISS- /sys/devices/cpu/events/PM_LSU0_DC_PREF_STREAM_ALLOC- /sys/devices/cpu/events/PM_L2_ST- /sys/devices/cpu/events/PM_VSU0_DENORM- /sys/devices/cpu/events/PM_MRK_DATA_FROM_DL2L3_SHR- /sys/devices/cpu/events/PM_BR_PRED_CR_TA- /sys/devices/cpu/events/PM_VSU0_FCONV- /sys/devices/cpu/events/PM_MRK_LSU_FLUSH_ULD- /sys/devices/cpu/events/PM_BTAC_MISS- /sys/devices/cpu/events/PM_MRK_LD_MISS_EXPOSED_CYC_COUNT- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L2- /sys/devices/cpu/events/PM_LSU_DCACHE_RELOAD_VALID- /sys/devices/cpu/events/PM_VSU_FMA- /sys/devices/cpu/events/PM_LSU0_FLUSH_SRQ- /sys/devices/cpu/events/PM_LSU1_L1_PREF- /sys/devices/cpu/events/PM_IOPS_CMPL- /sys/devices/cpu/events/PM_L2_SYS_PUMP- /sys/devices/cpu/events/PM_L2_RCLD_BUSY_RC_FULL- /sys/devices/cpu/events/PM_LSU_LMQ_S0_ALLOC- /sys/devices/cpu/events/PM_FLUSH_DISP_SYNC- /sys/devices/cpu/events/PM_MRK_DATA_FROM_DL2L3_MOD_CYC- /sys/devices/cpu/events/PM_L2_IC_INV- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L21_MOD_CYC- /sys/devices/cpu/events/PM_L3_PREF_LDST- /sys/devices/cpu/events/PM_LSU_SRQ_EMPTY_CYC- /sys/devices/cpu/events/PM_LSU_LMQ_S0_VALID- /sys/devices/cpu/events/PM_FLUSH_PARTIAL- /sys/devices/cpu/events/PM_VSU1_FMA_DOUBLE- /sys/devices/cpu/events/PM_1PLUS_PPC_DISP- /sys/devices/cpu/events/PM_DATA_FROM_L2MISS- /sys/devices/cpu/events/PM_SUSPENDED- /sys/devices/cpu/events/PM_VSU0_FMA- /sys/devices/cpu/events/PM_STCX_FAIL- /sys/devices/cpu/events/PM_VSU0_FSQRT_FDIV_DOUBLE- /sys/devices/cpu/events/PM_DC_PREF_DST- /sys/devices/cpu/events/PM_VSU1_SCAL_SINGLE_ISSUED- /sys/devices/cpu/events/PM_L3_HIT- /sys/devices/cpu/events/PM_L2_GLOB_GUESS_WRONG- /sys/devices/cpu/events/PM_MRK_DFU_FIN- /sys/devices/cpu/events/PM_INST_FROM_L1- /sys/devices/cpu/events/PM_IC_DEMAND_REQ- /sys/devices/cpu/events/PM_VSU1_FSQRT_FDIV_DOUBLE- /sys/devices/cpu/events/PM_VSU1_FMA- /sys/devices/cpu/events/PM_MRK_LD_MISS_L1- /sys/devices/cpu/events/PM_VSU0_2FLOP_DOUBLE- /sys/devices/cpu/events/PM_LSU_DC_PREF_STRIDED_STREAM_CONFIRM- /sys/devices/cpu/events/PM_INST_PTEG_FROM_L31_SHR- /sys/devices/cpu/events/PM_MRK_LSU_REJECT_ERAT_MISS- /sys/devices/cpu/events/PM_MRK_DATA_FROM_L2MISS- /sys/devices/cpu/events/PM_DATA_FROM_RL2L3_SHR- /sys/devices/cpu/events/PM_INST_FROM_PREF- /sys/devices/cpu/events/PM_VSU1_SQ- /sys/devices/cpu/events/PM_L2_LD_DISP- /sys/devices/cpu/events/PM_L2_DISP_ALL- /sys/devices/cpu/events/PM_THRD_GRP_CMPL_BOTH_CYC- /sys/devices/cpu/events/PM_VSU_FSQRT_FDIV_DOUBLE- /sys/devices/cpu/events/PM_INST_PTEG_FROM_DL2L3_SHR- /sys/devices/cpu/events/PM_VSU_1FLOP- /sys/devices/cpu/events/PM_HV_CYC- /sys/devices/cpu/events/PM_MRK_LSU_FIN- /sys/devices/cpu/events/PM_MRK_DATA_FROM_RL2L3_SHR- /sys/devices/cpu/events/PM_DTLB_MISS_16M- /sys/devices/cpu/events/PM_LSU1_LMQ_LHR_MERGE- /sys/devices/cpu/events/PM_IFU_FIN- /sys/devices/cpu/events/PM_1THRD_CON_RUN_INSTR- /sys/devices/cpu/events/PM_CMPLU_STALL_COUNT- /sys/devices/cpu/events/PM_MEM0_PB_RD_CL- /sys/devices/cpu/events/PM_THRD_1_RUN_CYC- /sys/devices/cpu/events/PM_THRD_2_CONC_RUN_INSTR- /sys/devices/cpu/events/PM_THRD_2_RUN_CYC- /sys/devices/cpu/events/PM_THRD_3_CONC_RUN_INST- /sys/devices/cpu/events/PM_THRD_3_RUN_CYC- /sys/devices/cpu/events/PM_THRD_4_CONC_RUN_INST- /sys/devices/cpu/events/PM_THRD_4_RUN_CYC- - Date: 2013/01/08- - Contact: Linux kernel mailing list <linux-kernel@vger.kernel.org>- Linux Powerpc mailing list <linuxppc-dev@ozlabs.org>- - Description: POWER-systems specific performance monitoring events- - A collection of performance monitoring events that may be- supported by the POWER CPU. These events can be monitored- using the 'perf(1)' tool.- - These events may not be supported by other CPUs.- - The contents of each file would look like:- - event=0xNNNN- - where 'N' is a hex digit and the number '0xNNNN' shows the- "raw code" for the perf event identified by the file's- "basename".- - Further, multiple terms like 'event=0xNNNN' can be specified- and separated with comma. All available terms are defined in- the /sys/bus/event_source/devices/<dev>/format file.- What: /sys/bus/event_source/devices/<pmu>/events/<event>
Date: 2014/02/24
Contact: Linux kernel mailing list <linux-kernel@vger.kernel.org> --
1.8.3.1
On Wed, 2014-24-09 at 19:24:39 UTC, sukadev@linux.vnet.ibm.com wrote: quoted hunk catalog_read() implements the read interface for the sysfs file
/sys/bus/event_source/devices/hv_24x7/interface/catalog
It essentially takes a buffer, an offset and count as parameters
to the read() call. It makes a hypervisor call to read a specific
page from the catalog and copy the required bytes into the given
buffer. Each call to catalog_read() returns at most one 4K page.
Given these requirements, we should be able to simplify the
catalog_read().
diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
index 2f2215c..9427ef7 100644
--- a/arch/powerpc/perf/hv-24x7.c
+++ b/arch/powerpc/perf/hv-24x7.c @@ -185,6 +105,8 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
ssize_t ret = 0 ;
size_t catalog_len = 0 , catalog_page_len = 0 , page_count = 0 ;
loff_t page_offset = 0 ;
+ loff_t offset_in_page ; + size_t copy_len ; uint64_t catalog_version_num = 0 ;
void * page = kmem_cache_alloc ( hv_page_cache , GFP_USER );
struct hv_24x7_catalog_page_0 * page_0 = page ; @@ -203,6 +125,7 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
page_offset = offset / 4096 ;
page_count = count / 4096 ;
I don't see where page_count is used.
+ offset_in_page = count % 4096;
Shouldn't offset_in_page be based on offset ?
cheers
Michael Ellerman [mpe@ellerman.id.au] wrote:
| > @@ -203,6 +125,7 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
| >
| > page_offset = offset / 4096;
| > page_count = count / 4096;
|
| I don't see where page_count is used.
Yes, I will remove it.
|
| > + offset_in_page = count % 4096;
|
| Shouldn't offset_in_page be based on offset ?
Yes. I will fix that.
Thanks,
Sukadev
On Wed, 2014-24-09 at 19:24:38 UTC, sukadev@linux.vnet.ibm.com wrote: quoted hunk From: Cody P Schafer <redacted>
Ian pointed out the use of __aligned(4096) caused rather large stack
consumption in single_24x7_request(), so use the kmem_cache
hv_page_cache (which we've already got set up for other allocations)
insead of allocating locally.
diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
index 70d4f74..2f2215c 100644
--- a/arch/powerpc/perf/hv-24x7.c
+++ b/arch/powerpc/perf/hv-24x7.c @@ -294,7 +294,7 @@ static unsigned long single_24x7_request(u8 domain, u32 offset, u16 ix,
u16 lpar , u64 * res ,
bool success_expected )
{
- unsigned long ret ; + unsigned long ret = - ENOMEM ;
/*
* request_buffer and result_buffer are not required to be 4 k aligned , @@ -304,7 +304,27 @@ static unsigned long single_24x7_request(u8 domain, u32 offset, u16 ix,
struct reqb {
struct hv_24x7_request_buffer buf ;
struct hv_24x7_request req ;
- } __packed __aligned ( 4096 ) request_buffer = { + } __packed * request_buffer ;
No space after the * please.
+ struct resb {
You never use the struct name so this can be anonymous, eg:
struct {
struct hv_24x7_data_result_buffer buf;
...
+ struct hv_24x7_data_result_buffer buf;
+ struct hv_24x7_result res;
+ struct hv_24x7_result_element elem;
+ __be64 result;
+ } __packed * result_buffer;
No space again.
+ BUILD_BUG_ON(sizeof(*request_buffer) > 4096);
+ BUILD_BUG_ON(sizeof(*result_buffer) > 4096);
+
+ request_buffer = kmem_cache_alloc(hv_page_cache, GFP_USER);
Why aren't we using kzalloc here?
It looks like we're initialising everything below except the reserved fields,
but are they allowed to be non-zero? It's probably safer to just kzalloc it.
+ if (!request_buffer)
+ goto out_reqb;
If prefer labels to be named for what they do, so this would be just "out".
+
+ result_buffer = kmem_cache_zalloc(hv_page_cache, GFP_USER);
+ if (!result_buffer)
+ goto out_resb;
And this would be "out_free_request_buffer".
quoted hunk +
+ *request_buffer = (struct reqb) {
.buf = {
.interface_version = HV_24X7_IF_VERSION_CURRENT,
.num_requests = 1, @@ -320,28 +340,30 @@ static unsigned long single_24x7_request(u8 domain, u32 offset, u16 ix,
}
};
- struct resb {- struct hv_24x7_data_result_buffer buf;- struct hv_24x7_result res;- struct hv_24x7_result_element elem;- __be64 result;- } __packed __aligned(4096) result_buffer = {};- ret = plpar_hcall_norets(H_GET_24X7_DATA,
- virt_to_phys(&request_buffer), sizeof(request_buffer),- virt_to_phys(&result_buffer), sizeof(result_buffer));+ virt_to_phys(request_buffer), sizeof(*request_buffer),+ virt_to_phys(result_buffer), sizeof(*result_buffer));
if (ret) {
if (success_expected)
pr_err_ratelimited("hcall failed: %d %#x %#x %d => 0x%lx (%ld) detail=0x%x failing ix=%x\n",
domain, offset, ix, lpar,
ret, ret,
- result_buffer.buf.detailed_rc,- result_buffer.buf.failing_request_ix);- return ret;+ result_buffer->buf.detailed_rc,+ result_buffer->buf.failing_request_ix);+ goto out_hcall; }
- *res = be64_to_cpu(result_buffer.result);+ *res = be64_to_cpu(result_buffer->result);+ kfree(result_buffer);+ kfree(request_buffer);+ return ret;+ + out_hcall:+ kfree(result_buffer);+ out_resb:+ kfree(request_buffer);+ out_reqb: return ret;
}
Wouldn't this be better as:
*res = be64_to_cpu(result_buffer->result);
out_free_result_buffer:
kfree(result_buffer);
out_free_request_buffer:
kfree(request_buffer);
out:
return ret;
}
cheers