[PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE

Subsystems: linux for powerpc (32-bit and 64-bit), pci enhanced error handling (eeh) for powerpc, the rest

STALE4377d

2 messages, 1 author, 2014-08-15 · open the first message on its own page

[PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE

From: Mike Qiu <hidden>
Date: 2014-08-13 11:14:28 

When PE passed to guest, and guest EEH occured with this PE,
EEH_PE_ISOLATED maybe set in host.

It is a big issue when the PE  is reused by host, host EEH
will not work on this PE because it was set to EEH_PE_ISOLATED
unexpectly.

Signed-off-by: Mike Qiu <redacted>
---
 arch/powerpc/platforms/powernv/eeh-ioda.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c
index c945bed..e88eaf6 100644
--- a/arch/powerpc/platforms/powernv/eeh-ioda.c
+++ b/arch/powerpc/platforms/powernv/eeh-ioda.c
@@ -371,7 +371,8 @@ static int ioda_eeh_get_pe_state(struct eeh_pe *pe)
 	    !(result & EEH_STATE_UNAVAILABLE) &&
 	    !(result & EEH_STATE_MMIO_ACTIVE) &&
 	    !(result & EEH_STATE_DMA_ACTIVE)  &&
-	    !(pe->state & EEH_PE_ISOLATED)) {
+	    !(pe->state & EEH_PE_ISOLATED)    &&
+	    !eeh_pe_passed(pe)) {
 		if (phb->freeze_pe)
 			phb->freeze_pe(phb, pe->addr);
 
-- 
1.8.1.4

Re: [PATCH] powerpc/powernv: Avoid to set EEH_PE_ISOLATED for passed PE

From: Mike Qiu <hidden>
Date: 2014-08-15 03:17:58 

Hi, all

After discussing with Gavin offline, it's inappropriate to drop ISOLATED 
state. Please ignore this patch.

Otherwise, somebody will merge that to mainline, which would be a problem.

Thanks,
Mike
On 08/13/2014 07:14 PM, Mike Qiu wrote:
quoted hunk
When PE passed to guest, and guest EEH occured with this PE,
EEH_PE_ISOLATED maybe set in host.

It is a big issue when the PE  is reused by host, host EEH
will not work on this PE because it was set to EEH_PE_ISOLATED
unexpectly.

Signed-off-by: Mike Qiu <redacted>
---
  arch/powerpc/platforms/powernv/eeh-ioda.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c
index c945bed..e88eaf6 100644
--- a/arch/powerpc/platforms/powernv/eeh-ioda.c
+++ b/arch/powerpc/platforms/powernv/eeh-ioda.c
@@ -371,7 +371,8 @@ static int ioda_eeh_get_pe_state(struct eeh_pe *pe)
  	    !(result & EEH_STATE_UNAVAILABLE) &&
  	    !(result & EEH_STATE_MMIO_ACTIVE) &&
  	    !(result & EEH_STATE_DMA_ACTIVE)  &&
-	    !(pe->state & EEH_PE_ISOLATED)) {
+	    !(pe->state & EEH_PE_ISOLATED)    &&
+	    !eeh_pe_passed(pe)) {
  		if (phb->freeze_pe)
  			phb->freeze_pe(phb, pe->addr);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help