[PATCH] net: fs_enet: fix reference counting for phy_node

Subsystems: freescale soc fs_enet driver, networking drivers, the rest

STALE4386d

2 messages, 2 authors, 2014-08-07 · open the first message on its own page

[PATCH] net: fs_enet: fix reference counting for phy_node

From: Uwe Kleine-König <hidden>
Date: 2014-08-07 21:24:50

Make sure that fs_enet_probe is left with a reference to the phy node.
In the presence of a phy handle this is already the case as
of_parse_phandle returns a reference. In the fixed phy case a call to
of_node_get is necessary. Otherwise the error path and remove function
drop a reference the driver isn't holding.

Fixes: bb74d9a4a87b ("fs_enet: use the new fixed PHY helpers")
Signed-off-by: Uwe Kleine-König <redacted>
---
 drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index cfaf17b70f3f..748fd24d3d9e 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1033,7 +1033,7 @@ static int fs_enet_probe(struct platform_device *ofdev)
 		/* In the case of a fixed PHY, the DT node associated
 		 * to the PHY is the Ethernet MAC DT node.
 		 */
-		fpi->phy_node = ofdev->dev.of_node;
+		fpi->phy_node = of_node_get(ofdev->dev.of_node);
 	}
 
 	if (of_device_is_compatible(ofdev->dev.of_node, "fsl,mpc5125-fec")) {
-- 
2.0.1

Re: [PATCH] net: fs_enet: fix reference counting for phy_node

From: David Miller <davem@davemloft.net>
Date: 2014-08-07 23:07:18

From: Uwe Kleine-K=F6nig <redacted>
Date: Thu,  7 Aug 2014 23:06:00 +0200
Make sure that fs_enet_probe is left with a reference to the phy node=
.=
In the presence of a phy handle this is already the case as
of_parse_phandle returns a reference. In the fixed phy case a call to=
of_node_get is necessary. Otherwise the error path and remove functio=
n
drop a reference the driver isn't holding.
=
Fixes: bb74d9a4a87b ("fs_enet: use the new fixed PHY helpers")
Signed-off-by: Uwe Kleine-K=F6nig <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help