[PATCH] Avoid bashisms

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE4352d

3 messages, 2 authors, 2014-09-12 · open the first message on its own page

[PATCH] Avoid bashisms

From: <hidden>
Date: 2014-08-04 20:36:27

From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001

From: malc <redacted>
Date: Mon, 4 Aug 2014 23:28:05 +0400
Subject: [PATCH] Avoid bashisms

---
 arch/powerpc/kernel/prom_init_check.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
index fe8e54b..413f792 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh

@@ -50,22 +50,22 @@ do
 	done
 
 	# ignore register save/restore funcitons
-	if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
+	if [ "$(printf %.9s $UNDEF)" = "_restgpr_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
+	if [ "$(printf %.10s $UNDEF)" = "_restgpr0_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
+	if [ "$(printf %.11s $UNDEF)" = "_rest32gpr_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
+	if [ "$(printf %.9s $UNDEF)" = "_savegpr_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
+	if [ "$(printf %.10s $UNDEF)" = "_savegpr0_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
+	if [ "$(printf %.11s $UNDEF)" = "_save32gpr_" ]; then
 		OK=1
 	fi

-- 
2.0.0.GIT


-- 
mailto:av1474@comtv.ru

Re: [PATCH] Avoid bashisms

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2014-09-12 08:25:43

On Mon, 2014-08-04 at 23:36 +0400, av1474@comtv.ru wrote:

From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001
From: malc <redacted>
Date: Mon, 4 Aug 2014 23:28:05 +0400
Subject: [PATCH] Avoid bashisms

Hi malc,

If you want us to take your patch, please resend with:
  - a better subject, eg:
    powerpc: Avoid bashisms in prom_init_check.sh
  - a Signed-off-by line.

cheers

powerpc: Avoid bashisms in prom_init_check.sh

From: <hidden>
Date: 2014-09-12 19:56:03

From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001

From: malc <av1474 at comtv.ru>
Date: Mon, 4 Aug 2014 23:28:05 +0400
Subject: [PATCH] powerpc: Avoid bashisms in prom_init_check.sh

Signed-off-by: Vassili Karpov <redacted>
---
 arch/powerpc/kernel/prom_init_check.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
index fe8e54b..413f792 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh

@@ -50,22 +50,22 @@ do
 	done
 
 	# ignore register save/restore funcitons
-	if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
+	if [ "$(printf %.9s $UNDEF)" = "_restgpr_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
+	if [ "$(printf %.10s $UNDEF)" = "_restgpr0_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
+	if [ "$(printf %.11s $UNDEF)" = "_rest32gpr_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
+	if [ "$(printf %.9s $UNDEF)" = "_savegpr_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
+	if [ "$(printf %.10s $UNDEF)" = "_savegpr0_" ]; then
 		OK=1
 	fi
-	if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
+	if [ "$(printf %.11s $UNDEF)" = "_save32gpr_" ]; then
 		OK=1
 	fi

-- 
2.0.0.GIT

> On Mon, 2014-08-04 at 23:36 +0400, av1474@comtv.ru wrote:
>> From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001
>> From: malc <av1474@comtv.ru>
>> Date: Mon, 4 Aug 2014 23:28:05 +0400
>> Subject: [PATCH] Avoid bashisms
>
> Hi malc,
>
> If you want us to take your patch, please resend with:
>   - a better subject, eg:
>     powerpc: Avoid bashisms in prom_init_check.sh
>   - a Signed-off-by line.
>
> cheers

Thanks for suggestions,

-- 
mailto:av1474@comtv.ru

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help