# \[PATCH 5/14\] powerpc/mpc5xxx: delete unneeded test before of\_node\_put

- From: Julia Lawall \<hidden\>
- Date: 2014-08-08 10:11:19 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2014/08/4311534
- Thread: https://ratatoskr.run/kernel-janitors/2014/08/4311534/t.md

```text
From: Julia Lawall <redacted>

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 arch/powerpc/sysdev/mpc5xxx_clocks.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/sysdev/mpc5xxx_clocks.c b/arch/powerpc/sysdev/mpc5xxx_clocks.c
index 5492dc5..f4f0301 100644
--- a/arch/powerpc/sysdev/mpc5xxx_clocks.c
+++ b/arch/powerpc/sysdev/mpc5xxx_clocks.c
@@ -26,8 +26,7 @@ unsigned long mpc5xxx_get_bus_frequency(struct device_node *node)
 		of_node_put(node);
 		node = np;
 	}
-	if (node)
-		of_node_put(node);
+	of_node_put(node);
 
 	return p_bus_freq ? *p_bus_freq : 0;
 }
```