Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

2 messages, 2 authors, 2014-07-02 · open the first message on its own page

Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

From: Emil Medve <hidden>
Date: 2014-07-02 07:56:40

On 06/24/2014 08:57 AM, Varun Sethi wrote:
is_power_of_2 requires an unsigned long parameter which would
lead to truncation of 64 bit values on 32 bit architectures.

__ffs also expects an unsigned long parameter thus won't work
for 64 bit values on 32 bit architectures.

Signed-off-by: Varun Sethi <redacted>
---
 drivers/iommu/fsl_pamu.c        |    8 ++++----
 drivers/iommu/fsl_pamu_domain.c |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
Tested-by: Emil Medve <redacted>

On a P4080 DS (i.e. 32-bit SoC)


Cheers,

RE: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

From: Varun Sethi <hidden>
Date: 2014-07-02 08:59:40

VGhhbmtzIEVtaWwuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogRW1p
bCBNZWR2ZSBbbWFpbHRvOkVtaWxpYW4uTWVkdmVARnJlZXNjYWxlLmNvbV0NCj4gU2VudDogV2Vk
bmVzZGF5LCBKdWx5IDAyLCAyMDE0IDE6MTYgUE0NCj4gVG86IFNldGhpIFZhcnVuLUIxNjM5NTsg
aW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmc7DQo+IGpvcm9AOGJ5dGVzLm9yZzsgbGlu
dXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtDQo+IGRldkBsaXN0cy5vemxhYnMu
b3JnOyBhbGV4LndpbGxpYW1zb25AcmVkaGF0LmNvbQ0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDEv
M10gaW9tbXUvZnNsOiBGaXggUEFNVSB3aW5kb3cgc2l6ZSBjaGVjay4NCj4gDQo+IE9uIDA2LzI0
LzIwMTQgMDg6NTcgQU0sIFZhcnVuIFNldGhpIHdyb3RlOg0KPiA+IGlzX3Bvd2VyX29mXzIgcmVx
dWlyZXMgYW4gdW5zaWduZWQgbG9uZyBwYXJhbWV0ZXIgd2hpY2ggd291bGQgbGVhZCB0bw0KPiA+
IHRydW5jYXRpb24gb2YgNjQgYml0IHZhbHVlcyBvbiAzMiBiaXQgYXJjaGl0ZWN0dXJlcy4NCj4g
Pg0KPiA+IF9fZmZzIGFsc28gZXhwZWN0cyBhbiB1bnNpZ25lZCBsb25nIHBhcmFtZXRlciB0aHVz
IHdvbid0IHdvcmsgZm9yIDY0DQo+ID4gYml0IHZhbHVlcyBvbiAzMiBiaXQgYXJjaGl0ZWN0dXJl
cy4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFZhcnVuIFNldGhpIDxWYXJ1bi5TZXRoaUBmcmVl
c2NhbGUuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL2lvbW11L2ZzbF9wYW11LmMgICAgICAg
IHwgICAgOCArKysrLS0tLQ0KPiA+ICBkcml2ZXJzL2lvbW11L2ZzbF9wYW11X2RvbWFpbi5jIHwg
ICAgMiArLQ0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlv
bnMoLSkNCj4gDQo+IFRlc3RlZC1ieTogRW1pbCBNZWR2ZSA8RW1pbGlhbi5NZWR2ZUBGcmVlc2Nh
bGUuY29tPg0KPiANCj4gT24gYSBQNDA4MCBEUyAoaS5lLiAzMi1iaXQgU29DKQ0KPiANCj4gDQo+
IENoZWVycywNCg==
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help