[PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type

STALE4454d

2 messages, 1 author, 2014-06-14 · open the first message on its own page

[PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type

From: Rickard Strandqvist <hidden>
Date: 2014-06-14 16:24:15

This variable is of the wrong type, everywhere it is used it
should be an unsigned int rather than a int.

This was partly found using a static code analysis program called cppcheck.

Rickard Strandqvist (1):
  arch: powerpc: platforms: cell: cbe_thermal.c:  Cleaning up a variable is of the wrong type

 arch/powerpc/platforms/cell/cbe_thermal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.10.4

[PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type

From: Rickard Strandqvist <hidden>
Date: 2014-06-14 16:24:21

This variable is of the wrong type, everywhere it is used it
should be an unsigned int rather than a int.

Signed-off-by: Rickard Strandqvist <redacted>
---
 arch/powerpc/platforms/cell/cbe_thermal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/cell/cbe_thermal.c b/arch/powerpc/platforms/cell/cbe_thermal.c
index 94560db..2c15ff0 100644
--- a/arch/powerpc/platforms/cell/cbe_thermal.c
+++ b/arch/powerpc/platforms/cell/cbe_thermal.c
@@ -125,7 +125,7 @@ static ssize_t show_throttle(struct cbe_pmd_regs __iomem *pmd_regs, char *buf, i
 static ssize_t store_throttle(struct cbe_pmd_regs __iomem *pmd_regs, const char *buf, size_t size, int pos)
 {
 	u64 reg_value;
-	int temp;
+	unsigned int temp;
 	u64 new_value;
 	int ret;
 
-- 
1.7.10.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help