Re: [PATCH 1/2] irqdomain: add support for creating a continous mapping
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2014-02-21 08:04:49
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2014-02-21 08:04:49
On 02/20/2014 10:06 PM, Scott Wood wrote:
On Thu, 2014-02-20 at 21:53 +0100, Sebastian Andrzej Siewior wrote:quoted
A MSI device may have multiple interrupts. That means that the interrupts numbers should be continuos so that pdev->irq refers to the first interrupt, pdev->irq + 1 to the second and so on. This patch adds support for continuous allocation of virqs for a range of hwirqs. The function is based on irq_create_mapping() but due to the number argument there is very little in common now.Would it make sense to turn irq_create_mapping() into a call to irq_create_mapping_block() with num = 1?
There are few things different and I didn't like it. Now I that I look at it again I've found a bug the way irq_find_mapping() is called. Let me redo it with your suggestion and we will see if it makes sense.
-Scott
Sebastian