Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs

On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:

From: Sudeep Holla <redacted>
+#define define_one_ro(_name) \
+static struct cache_attr _name = \
+	__ATTR(_name, 0444, show_##_name, NULL)

In the future, we do have __ATTR_RO(), which should be used instead.
You should never use __ATTR() on it's own, if at all possible.  I'm
sweeping the tree for all usages and fixing them slowly up over time.

thanks,

greg k-h

On 08/01/14 20:28, Greg Kroah-Hartman wrote:

On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:

quoted

From: Sudeep Holla <redacted>
+#define define_one_ro(_name) \
+static struct cache_attr _name =3D \
+=09__ATTR(_name, 0444, show_##_name, NULL)

=20
In the future, we do have __ATTR_RO(), which should be used instead.
You should never use __ATTR() on it's own, if at all possible.  I'm
sweeping the tree for all usages and fixing them slowly up over time.
=20

Understood, will fix it.

Regards,
Sudeep