[PATCH v2] powerpc/512x: dts: disable MPC5125 usb module

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE4634d

2 messages, 2 authors, 2013-12-20 · open the first message on its own page

[PATCH v2] powerpc/512x: dts: disable MPC5125 usb module

From: Matteo Facchinetti <hidden>
Date: 2013-12-20 09:17:19

At the moment the USB controller's pin muxing is not setup
correctly and causes a kernel panic upon system startup, so
disable the USB1 device tree node in the MPC5125 tower board
dts file.

The USB controller is connected to an USB3320 ULPI transceiver
and the device tree should receive an update to reflect correct
dependencies and required initialization data before the USB1
node can get re-enabled.

Signed-off-by: Matteo Facchinetti <redacted>
---
v2:
* improve the text of the commit as suggested by Gerhard Sittig [off-list ref]
* put the 'status = "disabled"' to the last line in the list of properties
* rewiew the comment related to USB1 device tree node
---
 arch/powerpc/boot/dts/mpc5125twr.dts | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/boot/dts/mpc5125twr.dts b/arch/powerpc/boot/dts/mpc5125twr.dts
index 806479f..2fa1d17 100644
--- a/arch/powerpc/boot/dts/mpc5125twr.dts
+++ b/arch/powerpc/boot/dts/mpc5125twr.dts
@@ -229,6 +229,10 @@
 			reg = <0xA000 0x1000>;
 		};
 
+		// disable USB1 port
+		// TODO:
+		// correct pinmux config and fix USB3320 ulpi dependency
+		// before re-enable it
 		usb@3000 {
 			compatible = "fsl,mpc5121-usb2-dr";
 			reg = <0x3000 0x400>;
@@ -239,6 +243,7 @@
 			phy_type = "ulpi";
 			clocks = <&clks MPC512x_CLK_USB1>;
 			clock-names = "ipg";
+			status = "disabled";
 		};
 
 		// 5125 PSCs are not 52xx or 5121 PSC compatible
-- 
1.8.3.2

Re: [PATCH v2] powerpc/512x: dts: disable MPC5125 usb module

From: Anatolij Gustschin <agust@denx.de>
Date: 2013-12-20 21:17:04

On Fri, 20 Dec 2013 10:16:22 +0100
Matteo Facchinetti [off-list ref] wrote:
At the moment the USB controller's pin muxing is not setup
correctly and causes a kernel panic upon system startup, so
disable the USB1 device tree node in the MPC5125 tower board
dts file.

The USB controller is connected to an USB3320 ULPI transceiver
and the device tree should receive an update to reflect correct
dependencies and required initialization data before the USB1
node can get re-enabled.

Signed-off-by: Matteo Facchinetti <redacted>
---
v2:
* improve the text of the commit as suggested by Gerhard Sittig [off-list ref]
* put the 'status = "disabled"' to the last line in the list of properties
* rewiew the comment related to USB1 device tree node
---
 arch/powerpc/boot/dts/mpc5125twr.dts | 5 +++++
 1 file changed, 5 insertions(+)
Applied to merge branch. Thanks!

Anatolij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help