# Re: \[PATCH v6 10/17\] serial: mpc512x: setup the PSC FIFO clock as well

- From: Greg Kroah-Hartman \<gregkh@linuxfoundation.org\>
- Date: 2013-12-05 00:55:21 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2013/12/8667625
- Thread: https://ratatoskr.run/linux-arm-kernel/2013/11/8081534/t.md

```text
On Sat, Nov 30, 2013 at 11:51:30PM +0100, Gerhard Sittig wrote:
> prepare and enable the FIFO clock upon PSC FIFO initialization,
> check for and propagage errors when enabling the PSC FIFO clock,
> disable and unprepare the FIFO clock upon PSC FIFO uninitialization
> 
> devm_{get,put}_clk() doesn't apply here, as the SoC provides a
> single FIFO component which is shared among several PSC components,
> thus the FIFO isn't associated with a device (while the PSCs are)
> 
> provide a fallback clock lookup approach in case the OF based clock
> lookup for the PSC FIFO fails, this allows for successful operation in
> the presence of an outdated device tree which lacks clock specs
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <redacted>
> Cc: <redacted>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> # for v4
> Signed-off-by: Gerhard Sittig <redacted>
> ---
> Greg, the addition since v4 is the clk_get_sys() call for the 'ipg'
> clock item (backwards compat for device trees w/o clock specs)

That's fine, my ACK still stands.

thanks,

greg k-h
```
