[PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE4662d

Revision v1 of 2 in this series.

7 messages, 5 authors, 2013-12-16 · open the first message on its own page

[PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

From: Mark Salter <hidden>
Date: 2013-12-14 17:01:23

Remove messy dependencies from SERIO_I8042 by having it depend on one
Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
New architectures are unlikely to need SERIO_I8042, so this avoids
having an ever growing list of architectures to exclude.

Signed-off-by: Mark Salter <redacted>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Richard Henderson <redacted>
CC: linux-alpha@vger.kernel.org
CC: Russell King <redacted>
CC: linux-arm-kernel@lists.infradead.org
CC: Tony Luck <tony.luck@intel.com>
CC: Fenghua Yu <redacted>
CC: linux-ia64@vger.kernel.org
CC: Ralf Baechle <redacted>
CC: linux-mips@linux-mips.org
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <redacted>
CC: linuxppc-dev@lists.ozlabs.org
CC: Paul Mundt <redacted>
CC: linux-sh@vger.kernel.org
CC: "David S. Miller" <davem@davemloft.net>
CC: sparclinux@vger.kernel.org
CC: Guan Xuetao <redacted>
CC: Ingo Molnar <mingo@redhat.com>
CC: Thomas Gleixner <redacted>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: x86@kernel.org
---
 drivers/input/serio/Kconfig | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
index 8541f94..1f5cec2 100644
--- a/drivers/input/serio/Kconfig
+++ b/drivers/input/serio/Kconfig

@@ -16,14 +16,19 @@ config SERIO
 	  To compile this driver as a module, choose M here: the
 	  module will be called serio.
 
+config ARCH_MIGHT_HAVE_PC_SERIO
+	bool
+	help
+	  Select this config option from the architecture Kconfig if
+	  the architecture might use a PC serio device (i8042) to
+          communicate with keyboard, mouse, etc.
+
 if SERIO
 
 config SERIO_I8042
 	tristate "i8042 PC Keyboard controller"
 	default y
-	depends on !PARISC && (!ARM || FOOTBRIDGE_HOST) && \
-		   (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 && \
-		   !ARC
+	depends on ARCH_MIGHT_HAVE_PC_SERIO
 	help
 	  i8042 is the chip over which the standard AT keyboard and PS/2
 	  mouse are connected to the computer. If you use these devices,

-- 
1.8.3.1

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2013-12-14 18:34:10

On 12/14/2013 08:59 AM, Mark Salter wrote:

Remove messy dependencies from SERIO_I8042 by having it depend on one
Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
New architectures are unlikely to need SERIO_I8042, so this avoids
having an ever growing list of architectures to exclude.

Signed-off-by: Mark Salter <redacted>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Richard Henderson <redacted>
CC: linux-alpha@vger.kernel.org
CC: Russell King <redacted>
CC: linux-arm-kernel@lists.infradead.org
CC: Tony Luck <tony.luck@intel.com>
CC: Fenghua Yu <redacted>
CC: linux-ia64@vger.kernel.org
CC: Ralf Baechle <redacted>
CC: linux-mips@linux-mips.org
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <redacted>
CC: linuxppc-dev@lists.ozlabs.org
CC: Paul Mundt <redacted>
CC: linux-sh@vger.kernel.org
CC: "David S. Miller" <davem@davemloft.net>
CC: sparclinux@vger.kernel.org
CC: Guan Xuetao <redacted>
CC: Ingo Molnar <mingo@redhat.com>
CC: Thomas Gleixner <redacted>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: x86@kernel.org

Acked-by: H. Peter Anvin <redacted>

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-12-15 10:37:09

On Sat, Dec 14, 2013 at 10:32:31AM -0800, H. Peter Anvin wrote:

On 12/14/2013 08:59 AM, Mark Salter wrote:

quoted

Remove messy dependencies from SERIO_I8042 by having it depend on one
Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
New architectures are unlikely to need SERIO_I8042, so this avoids
having an ever growing list of architectures to exclude.

Signed-off-by: Mark Salter <redacted>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Richard Henderson <redacted>
CC: linux-alpha@vger.kernel.org
CC: Russell King <redacted>
CC: linux-arm-kernel@lists.infradead.org
CC: Tony Luck <tony.luck@intel.com>
CC: Fenghua Yu <redacted>
CC: linux-ia64@vger.kernel.org
CC: Ralf Baechle <redacted>
CC: linux-mips@linux-mips.org
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <redacted>
CC: linuxppc-dev@lists.ozlabs.org
CC: Paul Mundt <redacted>
CC: linux-sh@vger.kernel.org
CC: "David S. Miller" <davem@davemloft.net>
CC: sparclinux@vger.kernel.org
CC: Guan Xuetao <redacted>
CC: Ingo Molnar <mingo@redhat.com>
CC: Thomas Gleixner <redacted>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: x86@kernel.org

Acked-by: H. Peter Anvin <redacted>

How are we going to merge this? In bulk through input tree or peacemeal
through all arches first?

-- 
Dmitry

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

From: Mark Salter <hidden>
Date: 2013-12-15 15:51:35

On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote:

On Sat, Dec 14, 2013 at 10:32:31AM -0800, H. Peter Anvin wrote:

quoted

On 12/14/2013 08:59 AM, Mark Salter wrote:

quoted

Remove messy dependencies from SERIO_I8042 by having it depend on one
Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
New architectures are unlikely to need SERIO_I8042, so this avoids
having an ever growing list of architectures to exclude.

How are we going to merge this? In bulk through input tree or peacemeal
through all arches first?

They should all go together to eliminate the chance of bisect breakage.
Either the input tree or maybe akpm tree.

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

From: David Miller <davem@davemloft.net>
Date: 2013-12-16 01:27:34

From: Mark Salter <redacted>
Date: Sun, 15 Dec 2013 10:50:26 -0500

On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote:

quoted

How are we going to merge this? In bulk through input tree or peacemeal
through all arches first?

They should all go together to eliminate the chance of bisect breakage.
Either the input tree or maybe akpm tree.

This sounds good to me.

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-12-16 04:59:14

On Sun, Dec 15, 2013 at 08:27:25PM -0500, David Miller wrote:

From: Mark Salter <redacted>
Date: Sun, 15 Dec 2013 10:50:26 -0500

quoted

On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote:

quoted

How are we going to merge this? In bulk through input tree or peacemeal
through all arches first?

They should all go together to eliminate the chance of bisect breakage.
Either the input tree or maybe akpm tree.

This sounds good to me.

OK, then I'll pick it up once I collect more acks from the arch
maintainers.

-- 
Dmitry

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

From: Ralf Baechle <hidden>
Date: 2013-12-16 16:24:48

On Sat, Dec 14, 2013 at 11:59:36AM -0500, Mark Salter wrote:

-	depends on !PARISC && (!ARM || FOOTBRIDGE_HOST) && \
-		   (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !S390 && \
-		   !ARC
+	depends on ARCH_MIGHT_HAVE_PC_SERIO

Most dependencies on an architecture's kconfig symbol outside arch/
should probably be treated as a bug.

Acked-by: Ralf Baechle <redacted>

  Ralf

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help