# Re: \[Cbe-oss-dev\] \[PATCH 2/8\] cell: Remove OOM message after input\_allocate\_device

- From: Geoff Levand \<geoff@infradead.org\>
- Date: 2013-10-23 20:49:21 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2013/10/4138227
- Thread: https://ratatoskr.run/linuxppc-dev/2013/10/4138197/t.md

```text
Hi Joe,

On Wed, 2013-10-23 at 12:14 -0700, Joe Perches wrote:
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/cell/cbe_powerbutton.c b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> index 2bb8031..8804dbd 100644
> --- a/arch/powerpc/platforms/cell/cbe_powerbutton.c
> +++ b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> @@ -58,7 +58,6 @@ static int __init cbe_powerbutton_init(void)
>  	dev = input_allocate_device();
>  	if (!dev) {
>  		ret = -ENOMEM;
> -		printk(KERN_ERR "%s: Not enough memory.\n", __func__);
>  		goto out;
>  	}

Arnd is out on leave, so I'll say that this looks OK.

Acked-by: Geoff Levand <geoff@infradead.org>
```
