[PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE4749d

5 messages, 3 authors, 2013-09-09 · open the first message on its own page

[PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS

From: Jia Hongtao <hidden>
Date: 2013-09-05 02:44:58

In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
The sub-nodes are also reorganized according to right I2C topology.

Signed-off-by: Jia Hongtao <redacted>
---
V2 change log:
Reorganized the sub-nodes under I2C multiplexer to represent right topology.

 arch/powerpc/boot/dts/b4qds.dtsi   | 49 +++++++++++++++++-----------
 arch/powerpc/boot/dts/t4240qds.dts | 67 ++++++++++++++++++++++----------------
 2 files changed, 69 insertions(+), 47 deletions(-)
diff --git a/arch/powerpc/boot/dts/b4qds.dtsi b/arch/powerpc/boot/dts/b4qds.dtsi
index e6d2f8f..de8cb38 100644
--- a/arch/powerpc/boot/dts/b4qds.dtsi
+++ b/arch/powerpc/boot/dts/b4qds.dtsi
@@ -120,25 +120,36 @@
 		};
 
 		i2c@118000 {
-			eeprom@50 {
-				compatible = "at24,24c64";
-				reg = <0x50>;
-			};
-			eeprom@51 {
-				compatible = "at24,24c256";
-				reg = <0x51>;
-			};
-			eeprom@53 {
-				compatible = "at24,24c256";
-				reg = <0x53>;
-			};
-			eeprom@57 {
-				compatible = "at24,24c256";
-				reg = <0x57>;
-			};
-			rtc@68 {
-				compatible = "dallas,ds3232";
-				reg = <0x68>;
+			pca9547@77 {
+				compatible = "philips,pca9547";
+				reg = <0x77>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				channel@0 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					reg = <0>;
+					eeprom@50 {
+						compatible = "at24,24c64";
+						reg = <0x50>;
+					};
+					eeprom@51 {
+						compatible = "at24,24c256";
+						reg = <0x51>;
+					};
+					eeprom@53 {
+						compatible = "at24,24c256";
+						reg = <0x53>;
+					};
+					eeprom@57 {
+						compatible = "at24,24c256";
+						reg = <0x57>;
+					};
+					rtc@68 {
+						compatible = "dallas,ds3232";
+						reg = <0x68>;
+					};
+				};
 			};
 		};
 
diff --git a/arch/powerpc/boot/dts/t4240qds.dts b/arch/powerpc/boot/dts/t4240qds.dts
index 0555976..ae68595 100644
--- a/arch/powerpc/boot/dts/t4240qds.dts
+++ b/arch/powerpc/boot/dts/t4240qds.dts
@@ -118,34 +118,45 @@
 		};
 
 		i2c@118000 {
-			eeprom@51 {
-				compatible = "at24,24c256";
-				reg = <0x51>;
-			};
-			eeprom@52 {
-				compatible = "at24,24c256";
-				reg = <0x52>;
-			};
-			eeprom@53 {
-				compatible = "at24,24c256";
-				reg = <0x53>;
-			};
-			eeprom@54 {
-				compatible = "at24,24c256";
-				reg = <0x54>;
-			};
-			eeprom@55 {
-				compatible = "at24,24c256";
-				reg = <0x55>;
-			};
-			eeprom@56 {
-				compatible = "at24,24c256";
-				reg = <0x56>;
-			};
-			rtc@68 {
-				compatible = "dallas,ds3232";
-				reg = <0x68>;
-				interrupts = <0x1 0x1 0 0>;
+			pca9547@77 {
+				compatible = "philips,pca9547";
+				reg = <0x77>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				channel@0 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					reg = <0>;
+					eeprom@51 {
+						compatible = "at24,24c256";
+						reg = <0x51>;
+					};
+					eeprom@52 {
+						compatible = "at24,24c256";
+						reg = <0x52>;
+					};
+					eeprom@53 {
+						compatible = "at24,24c256";
+						reg = <0x53>;
+					};
+					eeprom@54 {
+						compatible = "at24,24c256";
+						reg = <0x54>;
+					};
+					eeprom@55 {
+						compatible = "at24,24c256";
+						reg = <0x55>;
+					};
+					eeprom@56 {
+						compatible = "at24,24c256";
+						reg = <0x56>;
+					};
+					rtc@68 {
+						compatible = "dallas,ds3232";
+						reg = <0x68>;
+						interrupts = <0x1 0x1 0 0>;
+					};
+				};
 			};
 		};
 	};
-- 
1.8.0

Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS

From: Kumar Gala <hidden>
Date: 2013-09-05 18:41:10

On Sep 4, 2013, at 9:41 PM, Jia Hongtao wrote:
In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
The sub-nodes are also reorganized according to right I2C topology.
=20
Signed-off-by: Jia Hongtao <redacted>
---
V2 change log:
Reorganized the sub-nodes under I2C multiplexer to represent right =
topology.
=20
arch/powerpc/boot/dts/b4qds.dtsi   | 49 +++++++++++++++++-----------
arch/powerpc/boot/dts/t4240qds.dts | 67 =
++++++++++++++++++++++----------------
quoted hunk
2 files changed, 69 insertions(+), 47 deletions(-)
=20
diff --git a/arch/powerpc/boot/dts/b4qds.dtsi =
b/arch/powerpc/boot/dts/b4qds.dtsi
quoted hunk
index e6d2f8f..de8cb38 100644
--- a/arch/powerpc/boot/dts/b4qds.dtsi
+++ b/arch/powerpc/boot/dts/b4qds.dtsi
@@ -120,25 +120,36 @@
		};
=20
		i2c@118000 {
-			eeprom@50 {
-				compatible =3D "at24,24c64";
-				reg =3D <0x50>;
-			};
-			eeprom@51 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x51>;
-			};
-			eeprom@53 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x53>;
-			};
-			eeprom@57 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x57>;
-			};
-			rtc@68 {
-				compatible =3D "dallas,ds3232";
-				reg =3D <0x68>;
+			pca9547@77 {
+				compatible =3D "philips,pca9547";
We seem to be using nxp instead of philips now.
+				reg =3D <0x77>;
+				#address-cells =3D <1>;
+				#size-cells =3D <0>;
+				channel@0 {
channel should probably be i2c

[same comments below]
+					#address-cells =3D <1>;
+					#size-cells =3D <0>;
+					reg =3D <0>;
+					eeprom@50 {
+						compatible =3D =
"at24,24c64";
+						reg =3D <0x50>;
+					};
+					eeprom@51 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x51>;
+					};
+					eeprom@53 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x53>;
+					};
+					eeprom@57 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x57>;
+					};
+					rtc@68 {
+						compatible =3D =
"dallas,ds3232";
quoted hunk
+						reg =3D <0x68>;
+					};
+				};
			};
		};
=20
diff --git a/arch/powerpc/boot/dts/t4240qds.dts =
b/arch/powerpc/boot/dts/t4240qds.dts
quoted hunk
index 0555976..ae68595 100644
--- a/arch/powerpc/boot/dts/t4240qds.dts
+++ b/arch/powerpc/boot/dts/t4240qds.dts
@@ -118,34 +118,45 @@
		};
=20
		i2c@118000 {
-			eeprom@51 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x51>;
-			};
-			eeprom@52 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x52>;
-			};
-			eeprom@53 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x53>;
-			};
-			eeprom@54 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x54>;
-			};
-			eeprom@55 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x55>;
-			};
-			eeprom@56 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x56>;
-			};
-			rtc@68 {
-				compatible =3D "dallas,ds3232";
-				reg =3D <0x68>;
-				interrupts =3D <0x1 0x1 0 0>;
+			pca9547@77 {
+				compatible =3D "philips,pca9547";
+				reg =3D <0x77>;
+				#address-cells =3D <1>;
+				#size-cells =3D <0>;
+				channel@0 {
+					#address-cells =3D <1>;
+					#size-cells =3D <0>;
+					reg =3D <0>;
+					eeprom@51 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x51>;
+					};
+					eeprom@52 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x52>;
+					};
+					eeprom@53 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x53>;
+					};
+					eeprom@54 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x54>;
+					};
+					eeprom@55 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x55>;
+					};
+					eeprom@56 {
+						compatible =3D =
"at24,24c256";
+						reg =3D <0x56>;
+					};
+					rtc@68 {
+						compatible =3D =
"dallas,ds3232";
+						reg =3D <0x68>;
+						interrupts =3D <0x1 0x1 =
0 0>;
+					};
+				};
			};
		};
	};
--=20
1.8.0
=20
=20
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

RE: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS

From: Jia Hongtao-B38951 <hidden>
Date: 2013-09-06 03:33:44

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Friday, September 06, 2013 2:41 AM
To: Jia Hongtao-B38951
Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421;
Wei.Yang@windriver.com
Subject: Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and
T4240QDS
=20
=20
On Sep 4, 2013, at 9:41 PM, Jia Hongtao wrote:
=20
quoted
In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
The sub-nodes are also reorganized according to right I2C topology.

Signed-off-by: Jia Hongtao <redacted>
---
V2 change log:
Reorganized the sub-nodes under I2C multiplexer to represent right
topology.
quoted
arch/powerpc/boot/dts/b4qds.dtsi   | 49 +++++++++++++++++-----------
arch/powerpc/boot/dts/t4240qds.dts | 67 ++++++++++++++++++++++---------
-------
quoted
2 files changed, 69 insertions(+), 47 deletions(-)
diff --git a/arch/powerpc/boot/dts/b4qds.dtsi
b/arch/powerpc/boot/dts/b4qds.dtsi
quoted
index e6d2f8f..de8cb38 100644
--- a/arch/powerpc/boot/dts/b4qds.dtsi
+++ b/arch/powerpc/boot/dts/b4qds.dtsi
@@ -120,25 +120,36 @@
		};

		i2c@118000 {
-			eeprom@50 {
-				compatible =3D "at24,24c64";
-				reg =3D <0x50>;
-			};
-			eeprom@51 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x51>;
-			};
-			eeprom@53 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x53>;
-			};
-			eeprom@57 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x57>;
-			};
-			rtc@68 {
-				compatible =3D "dallas,ds3232";
-				reg =3D <0x68>;
+			pca9547@77 {
+				compatible =3D "philips,pca9547";
=20
We seem to be using nxp instead of philips now.
=20
quoted
+				reg =3D <0x77>;
+				#address-cells =3D <1>;
+				#size-cells =3D <0>;
+				channel@0 {
=20
channel should probably be i2c

Is there any standard for the name?
i2c is ok but I think channel is more intuitional.

Hi Scott,
What do you think of it.

Thanks.
-Hongtao

=20
[same comments below]
=20
quoted
+					#address-cells =3D <1>;
+					#size-cells =3D <0>;
+					reg =3D <0>;
+					eeprom@50 {
+						compatible =3D "at24,24c64";
+						reg =3D <0x50>;
+					};
+					eeprom@51 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x51>;
+					};
+					eeprom@53 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x53>;
+					};
+					eeprom@57 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x57>;
+					};
+					rtc@68 {
+						compatible =3D "dallas,ds3232";
+						reg =3D <0x68>;
+					};
+				};
			};
		};
diff --git a/arch/powerpc/boot/dts/t4240qds.dts
b/arch/powerpc/boot/dts/t4240qds.dts
quoted
index 0555976..ae68595 100644
--- a/arch/powerpc/boot/dts/t4240qds.dts
+++ b/arch/powerpc/boot/dts/t4240qds.dts
@@ -118,34 +118,45 @@
		};

		i2c@118000 {
-			eeprom@51 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x51>;
-			};
-			eeprom@52 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x52>;
-			};
-			eeprom@53 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x53>;
-			};
-			eeprom@54 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x54>;
-			};
-			eeprom@55 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x55>;
-			};
-			eeprom@56 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x56>;
-			};
-			rtc@68 {
-				compatible =3D "dallas,ds3232";
-				reg =3D <0x68>;
-				interrupts =3D <0x1 0x1 0 0>;
+			pca9547@77 {
+				compatible =3D "philips,pca9547";
+				reg =3D <0x77>;
+				#address-cells =3D <1>;
+				#size-cells =3D <0>;
+				channel@0 {
+					#address-cells =3D <1>;
+					#size-cells =3D <0>;
+					reg =3D <0>;
+					eeprom@51 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x51>;
+					};
+					eeprom@52 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x52>;
+					};
+					eeprom@53 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x53>;
+					};
+					eeprom@54 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x54>;
+					};
+					eeprom@55 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x55>;
+					};
+					eeprom@56 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x56>;
+					};
+					rtc@68 {
+						compatible =3D "dallas,ds3232";
+						reg =3D <0x68>;
+						interrupts =3D <0x1 0x1 0 0>;
+					};
+				};
			};
		};
	};
--
1.8.0


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
=20

Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS

From: Kumar Gala <hidden>
Date: 2013-09-06 16:10:31

On Sep 5, 2013, at 10:33 PM, Jia Hongtao-B38951 wrote:
quoted
-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Friday, September 06, 2013 2:41 AM
To: Jia Hongtao-B38951
Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421;
Wei.Yang@windriver.com
Subject: Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and
T4240QDS


On Sep 4, 2013, at 9:41 PM, Jia Hongtao wrote:
quoted
In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
The sub-nodes are also reorganized according to right I2C topology.

Signed-off-by: Jia Hongtao <redacted>
---
V2 change log:
Reorganized the sub-nodes under I2C multiplexer to represent right
topology.
quoted
arch/powerpc/boot/dts/b4qds.dtsi   | 49 +++++++++++++++++-----------
arch/powerpc/boot/dts/t4240qds.dts | 67 ++++++++++++++++++++++---------
-------
quoted
2 files changed, 69 insertions(+), 47 deletions(-)
diff --git a/arch/powerpc/boot/dts/b4qds.dtsi
b/arch/powerpc/boot/dts/b4qds.dtsi
quoted
index e6d2f8f..de8cb38 100644
--- a/arch/powerpc/boot/dts/b4qds.dtsi
+++ b/arch/powerpc/boot/dts/b4qds.dtsi
@@ -120,25 +120,36 @@
		};

		i2c@118000 {
-			eeprom@50 {
-				compatible = "at24,24c64";
-				reg = <0x50>;
-			};
-			eeprom@51 {
-				compatible = "at24,24c256";
-				reg = <0x51>;
-			};
-			eeprom@53 {
-				compatible = "at24,24c256";
-				reg = <0x53>;
-			};
-			eeprom@57 {
-				compatible = "at24,24c256";
-				reg = <0x57>;
-			};
-			rtc@68 {
-				compatible = "dallas,ds3232";
-				reg = <0x68>;
+			pca9547@77 {
+				compatible = "philips,pca9547";
We seem to be using nxp instead of philips now.
This is based on Documentation/devicetree/bindings/vendor-prefixes.txt
quoted
quoted
+				reg = <0x77>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				channel@0 {
channel should probably be i2c

Is there any standard for the name?
i2c is ok but I think channel is more intuitional.

Hi Scott,
What do you think of it.
Basing my comments on Documentation/devicetree/bindings/i2c/i2c-mux.txt 

Thanks.
-Hongtao

quoted
[same comments below]
quoted
+					#address-cells = <1>;
+					#size-cells = <0>;
+					reg = <0>;
+					eeprom@50 {
+						compatible = "at24,24c64";
+						reg = <0x50>;
+					};
+					eeprom@51 {
+						compatible = "at24,24c256";
+						reg = <0x51>;
+					};
+					eeprom@53 {
+						compatible = "at24,24c256";
+						reg = <0x53>;
+					};
+					eeprom@57 {
+						compatible = "at24,24c256";
+						reg = <0x57>;
+					};
+					rtc@68 {
+						compatible = "dallas,ds3232";
+						reg = <0x68>;
+					};
+				};
			};
		};
diff --git a/arch/powerpc/boot/dts/t4240qds.dts
b/arch/powerpc/boot/dts/t4240qds.dts
quoted
index 0555976..ae68595 100644
--- a/arch/powerpc/boot/dts/t4240qds.dts
+++ b/arch/powerpc/boot/dts/t4240qds.dts
@@ -118,34 +118,45 @@
		};

		i2c@118000 {
-			eeprom@51 {
-				compatible = "at24,24c256";
-				reg = <0x51>;
-			};
-			eeprom@52 {
-				compatible = "at24,24c256";
-				reg = <0x52>;
-			};
-			eeprom@53 {
-				compatible = "at24,24c256";
-				reg = <0x53>;
-			};
-			eeprom@54 {
-				compatible = "at24,24c256";
-				reg = <0x54>;
-			};
-			eeprom@55 {
-				compatible = "at24,24c256";
-				reg = <0x55>;
-			};
-			eeprom@56 {
-				compatible = "at24,24c256";
-				reg = <0x56>;
-			};
-			rtc@68 {
-				compatible = "dallas,ds3232";
-				reg = <0x68>;
-				interrupts = <0x1 0x1 0 0>;
+			pca9547@77 {
+				compatible = "philips,pca9547";
+				reg = <0x77>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+				channel@0 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					reg = <0>;
+					eeprom@51 {
+						compatible = "at24,24c256";
+						reg = <0x51>;
+					};
+					eeprom@52 {
+						compatible = "at24,24c256";
+						reg = <0x52>;
+					};
+					eeprom@53 {
+						compatible = "at24,24c256";
+						reg = <0x53>;
+					};
+					eeprom@54 {
+						compatible = "at24,24c256";
+						reg = <0x54>;
+					};
+					eeprom@55 {
+						compatible = "at24,24c256";
+						reg = <0x55>;
+					};
+					eeprom@56 {
+						compatible = "at24,24c256";
+						reg = <0x56>;
+					};
+					rtc@68 {
+						compatible = "dallas,ds3232";
+						reg = <0x68>;
+						interrupts = <0x1 0x1 0 0>;
+					};
+				};
			};
		};
	};
--
1.8.0


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

RE: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS

From: Jia Hongtao-B38951 <hidden>
Date: 2013-09-09 01:35:00

Great thanks.

I will update the patch and send it soon.

-Hongtao
-----Original Message-----
From: Linuxppc-dev [mailto:linuxppc-dev-
bounces+b38951=3Dfreescale.com@lists.ozlabs.org] On Behalf Of Kumar Gala
Sent: Saturday, September 07, 2013 12:10 AM
To: Jia Hongtao-B38951
Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org;
Wei.Yang@windriver.com
Subject: Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4 and
T4240QDS
=20
=20
On Sep 5, 2013, at 10:33 PM, Jia Hongtao-B38951 wrote:
=20
quoted
quoted
-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Friday, September 06, 2013 2:41 AM
To: Jia Hongtao-B38951
Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421;
Wei.Yang@windriver.com
Subject: Re: [PATCH V2] powerpc: Add I2C bus multiplexer node for B4
and T4240QDS


On Sep 4, 2013, at 9:41 PM, Jia Hongtao wrote:
quoted
In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used.
The sub-nodes are also reorganized according to right I2C topology.

Signed-off-by: Jia Hongtao <redacted>
---
V2 change log:
Reorganized the sub-nodes under I2C multiplexer to represent right
topology.
quoted
arch/powerpc/boot/dts/b4qds.dtsi   | 49 +++++++++++++++++-----------
arch/powerpc/boot/dts/t4240qds.dts | 67
++++++++++++++++++++++---------
-------
quoted
2 files changed, 69 insertions(+), 47 deletions(-)
diff --git a/arch/powerpc/boot/dts/b4qds.dtsi
b/arch/powerpc/boot/dts/b4qds.dtsi
quoted
index e6d2f8f..de8cb38 100644
--- a/arch/powerpc/boot/dts/b4qds.dtsi
+++ b/arch/powerpc/boot/dts/b4qds.dtsi
@@ -120,25 +120,36 @@
		};

		i2c@118000 {
-			eeprom@50 {
-				compatible =3D "at24,24c64";
-				reg =3D <0x50>;
-			};
-			eeprom@51 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x51>;
-			};
-			eeprom@53 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x53>;
-			};
-			eeprom@57 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x57>;
-			};
-			rtc@68 {
-				compatible =3D "dallas,ds3232";
-				reg =3D <0x68>;
+			pca9547@77 {
+				compatible =3D "philips,pca9547";
We seem to be using nxp instead of philips now.
=20
This is based on Documentation/devicetree/bindings/vendor-prefixes.txt
=20
quoted
quoted
quoted
+				reg =3D <0x77>;
+				#address-cells =3D <1>;
+				#size-cells =3D <0>;
+				channel@0 {
channel should probably be i2c

Is there any standard for the name?
i2c is ok but I think channel is more intuitional.

Hi Scott,
What do you think of it.
=20
Basing my comments on Documentation/devicetree/bindings/i2c/i2c-mux.txt
=20
=20
quoted
Thanks.
-Hongtao

quoted
[same comments below]
quoted
+					#address-cells =3D <1>;
+					#size-cells =3D <0>;
+					reg =3D <0>;
+					eeprom@50 {
+						compatible =3D "at24,24c64";
+						reg =3D <0x50>;
+					};
+					eeprom@51 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x51>;
+					};
+					eeprom@53 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x53>;
+					};
+					eeprom@57 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x57>;
+					};
+					rtc@68 {
+						compatible =3D "dallas,ds3232";
+						reg =3D <0x68>;
+					};
+				};
			};
		};
diff --git a/arch/powerpc/boot/dts/t4240qds.dts
b/arch/powerpc/boot/dts/t4240qds.dts
quoted
index 0555976..ae68595 100644
--- a/arch/powerpc/boot/dts/t4240qds.dts
+++ b/arch/powerpc/boot/dts/t4240qds.dts
@@ -118,34 +118,45 @@
		};

		i2c@118000 {
-			eeprom@51 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x51>;
-			};
-			eeprom@52 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x52>;
-			};
-			eeprom@53 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x53>;
-			};
-			eeprom@54 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x54>;
-			};
-			eeprom@55 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x55>;
-			};
-			eeprom@56 {
-				compatible =3D "at24,24c256";
-				reg =3D <0x56>;
-			};
-			rtc@68 {
-				compatible =3D "dallas,ds3232";
-				reg =3D <0x68>;
-				interrupts =3D <0x1 0x1 0 0>;
+			pca9547@77 {
+				compatible =3D "philips,pca9547";
+				reg =3D <0x77>;
+				#address-cells =3D <1>;
+				#size-cells =3D <0>;
+				channel@0 {
+					#address-cells =3D <1>;
+					#size-cells =3D <0>;
+					reg =3D <0>;
+					eeprom@51 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x51>;
+					};
+					eeprom@52 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x52>;
+					};
+					eeprom@53 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x53>;
+					};
+					eeprom@54 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x54>;
+					};
+					eeprom@55 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x55>;
+					};
+					eeprom@56 {
+						compatible =3D "at24,24c256";
+						reg =3D <0x56>;
+					};
+					rtc@68 {
+						compatible =3D "dallas,ds3232";
+						reg =3D <0x68>;
+						interrupts =3D <0x1 0x1 0 0>;
+					};
+				};
			};
		};
	};
--
1.8.0


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
=20
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help