[PATCH] powerpc: Export cpu_to_chip_id() to fix build error

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE4744d

3 messages, 3 authors, 2013-09-11 · open the first message on its own page

[PATCH] powerpc: Export cpu_to_chip_id() to fix build error

From: Guenter Roeck <linux@roeck-us.net>
Date: 2013-09-10 01:38:12

powerpc allmodconfig build fails with:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

The problem was introduced with commit 15863ff3b (powerpc: Make chip-id
information available to userspace).

Export the missing symbol.

Cc: Vasant Hegde <redacted>
Cc: Shivaprasad G Bhat <redacted>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/powerpc/kernel/smp.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 442d8e2..8e59abc 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
 	of_node_put(np);
 	return of_get_ibm_chip_id(np);
 }
+EXPORT_SYMBOL(cpu_to_chip_id);
 
 /* Helper routines for cpu to core mapping */
 int cpu_core_index_of_thread(int cpu)
-- 
1.7.9.7

Re: [PATCH] powerpc: Export cpu_to_chip_id() to fix build error

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2013-09-10 22:03:56

On Mon, 2013-09-09 at 18:37 -0700, Guenter Roeck wrote:
powerpc allmodconfig build fails with:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

The problem was introduced with commit 15863ff3b (powerpc: Make chip-id
information available to userspace).
Thanks, I'll send that to Linus asap.

Ben.
quoted hunk
Export the missing symbol.

Cc: Vasant Hegde <redacted>
Cc: Shivaprasad G Bhat <redacted>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/powerpc/kernel/smp.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 442d8e2..8e59abc 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
 	of_node_put(np);
 	return of_get_ibm_chip_id(np);
 }
+EXPORT_SYMBOL(cpu_to_chip_id);
 
 /* Helper routines for cpu to core mapping */
 int cpu_core_index_of_thread(int cpu)

Re: [PATCH] powerpc: Export cpu_to_chip_id() to fix build error

From: Vasant Hegde <hidden>
Date: 2013-09-11 08:00:23

On 09/11/2013 03:33 AM, Benjamin Herrenschmidt wrote:
On Mon, 2013-09-09 at 18:37 -0700, Guenter Roeck wrote:
quoted
powerpc allmodconfig build fails with:

ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!

The problem was introduced with commit 15863ff3b (powerpc: Make chip-id
information available to userspace).
Thanks, I'll send that to Linus asap.
Verified on today's Linus tree. This issue is fixed.

Thanks a lot.

-Vasant
Ben.
quoted
Export the missing symbol.

Cc: Vasant Hegde <redacted>
Cc: Shivaprasad G Bhat <redacted>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
  arch/powerpc/kernel/smp.c |    1 +
  1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 442d8e2..8e59abc 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
  	of_node_put(np);
  	return of_get_ibm_chip_id(np);
  }
+EXPORT_SYMBOL(cpu_to_chip_id);

  /* Helper routines for cpu to core mapping */
  int cpu_core_index_of_thread(int cpu)

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help