# Re: \[PATCH v4 01/31\] spi: mpc512x: cleanup clock API use

- From: Anatolij Gustschin \<agust@denx.de\>
- Date: 2013-08-21 19:23:09 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2013/08/9475984
- Thread: https://ratatoskr.run/linuxppc-dev/2013/07/8074764/t/2.md

```text
On Tue,  6 Aug 2013 22:43:41 +0200
Gerhard Sittig [ref] wrote:

> cleanup the MPC512x SoC's SPI master's use of the clock API
> - get, prepare, and enable the MCLK during probe; disable, unprepare and
>   put the MCLK upon remove; hold a reference to the clock over the
>   period of use
> - fetch MCLK rate (reference) once during probe and slightly reword BCLK
>   (bitrate) determination to reduce redundancy as well as to not exceed
>   the maximum text line length
> - stick with the PPC_CLOCK 'psc%d_mclk' name for clock lookup, only
>   switch to a fixed string later after device tree based clock lookup
>   will have become available
> 
> Signed-off-by: Gerhard Sittig <redacted>
> ---
>  drivers/spi/spi-mpc512x-psc.c |   48 +++++++++++++++++++++++++----------------
>  1 file changed, 30 insertions(+), 18 deletions(-)

Mark, are you going to apply this patch? Or should I queue it
in my mpc5xxx tree (I'd like to get your Acked-by then)?

Thanks,

Anatolij
```