[PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE4826d

3 messages, 2 authors, 2013-05-30 · open the first message on its own page

[PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

From: liguang <hidden>
Date: 2013-05-30 07:08:17

orderly_poweroff is expecting a bool parameter, so
use 'ture' instead '1'

Signed-off-by: liguang <redacted>
---
 arch/powerpc/platforms/pseries/ras.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index c4dfccd..79b9502 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -83,7 +83,7 @@ static void handle_system_shutdown(char event_modifier)
 	switch (event_modifier) {
 	case EPOW_SHUTDOWN_NORMAL:
 		pr_emerg("Firmware initiated power off");
-		orderly_poweroff(1);
+		orderly_poweroff(true);
 		break;
 
 	case EPOW_SHUTDOWN_ON_UPS:
@@ -95,13 +95,13 @@ static void handle_system_shutdown(char event_modifier)
 		pr_emerg("Loss of system critical functions reported by "
 			"firmware");
 		pr_emerg("Check RTAS error log for details");
-		orderly_poweroff(1);
+		orderly_poweroff(true);
 		break;
 
 	case EPOW_SHUTDOWN_AMBIENT_TEMPERATURE_TOO_HIGH:
 		pr_emerg("Ambient temperature too high reported by firmware");
 		pr_emerg("Check RTAS error log for details");
-		orderly_poweroff(1);
+		orderly_poweroff(true);
 		break;
 
 	default:
@@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log)
 
 	case EPOW_SYSTEM_HALT:
 		pr_emerg("Firmware initiated power off");
-		orderly_poweroff(1);
+		orderly_poweroff(ture);
 		break;
 
 	case EPOW_MAIN_ENCLOSURE:
-- 
1.7.2.5

Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

From: Joe Perches <joe@perches.com>
Date: 2013-05-30 07:14:33

On Thu, 2013-05-30 at 15:07 +0800, liguang wrote:
orderly_poweroff is expecting a bool parameter, so
use 'ture' instead '1'
[]
quoted hunk
diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
[]
quoted hunk
@@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *log)
 
 	case EPOW_SYSTEM_HALT:
 		pr_emerg("Firmware initiated power off");
-		orderly_poweroff(1);
+		orderly_poweroff(ture);
 		break;
Compile your patches _before_ submitting them please.

"true" not "ture" here and in the commit message.

Re: [PATCH] powerpc/pseries: use 'true' instead of '1' for orderly_poweroff

From: li guang <hidden>
Date: 2013-05-30 07:20:52

=E5=9C=A8 2013-05-30=E5=9B=9B=E7=9A=84 00:14 -0700=EF=BC=8CJoe Perches=E5=
=86=99=E9=81=93=EF=BC=9A
On Thu, 2013-05-30 at 15:07 +0800, liguang wrote:
quoted
orderly_poweroff is expecting a bool parameter, so
use 'ture' instead '1'
[]
quoted
diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platfo=
rms/pseries/ras.c
[]
quoted
@@ -162,7 +162,7 @@ void rtas_parse_epow_errlog(struct rtas_error_log *=
log)
quoted
=20
 	case EPOW_SYSTEM_HALT:
 		pr_emerg("Firmware initiated power off");
-		orderly_poweroff(1);
+		orderly_poweroff(ture);
 		break;
=20
Compile your patches _before_ submitting them please.
=20
"true" not "ture" here and in the commit message.
=20
right, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help