[PATCH] powerpc/qe: remove useless Kconfig default

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE4896d

2 messages, 2 authors, 2013-03-15 · open the first message on its own page

[PATCH] powerpc/qe: remove useless Kconfig default

From: Paul Bolle <hidden>
Date: 2013-03-12 21:49:14

The Kconfig entry for QE_USB contains
	default y if USB_GADGET_FSL_QE

But USB_GADGET_FSL_QE got removed in commit
193ab2a6070039e7ee2b9b9bebea754a7c52fd1b ("usb: gadget: allow multiple
gadgets to be built"). This default will therefor never be set and can
be removed.

Signed-off-by: Paul Bolle <redacted>
---
0) Tested with "make ARCH=powerpc menuconfig" and "make ARCH=powerpc
oldconfig" (before and after the patch). Enough to see this patch didn't
obviously break stuff.

1) I don't really understand commit
193ab2a6070039e7ee2b9b9bebea754a7c52fd1b. Was its point that we replace
USB_GADGET_FSL_QE with USB_FSL_QE? I couldn't tell and chose not to
actually change any behavior.

 arch/powerpc/sysdev/qe_lib/Kconfig | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
index 41ac3df..33caf44 100644
--- a/arch/powerpc/sysdev/qe_lib/Kconfig
+++ b/arch/powerpc/sysdev/qe_lib/Kconfig
@@ -22,6 +22,5 @@ config UCC
 
 config QE_USB
 	bool
-	default y if USB_GADGET_FSL_QE
 	help
 	  QE USB Controller support
-- 
1.7.11.7

Re: [PATCH] powerpc/qe: remove useless Kconfig default

From: Kumar Gala <hidden>
Date: 2013-03-15 16:17:11

On Mar 12, 2013, at 4:49 PM, Paul Bolle wrote:
The Kconfig entry for QE_USB contains
	default y if USB_GADGET_FSL_QE
=20
But USB_GADGET_FSL_QE got removed in commit
193ab2a6070039e7ee2b9b9bebea754a7c52fd1b ("usb: gadget: allow multiple
gadgets to be built"). This default will therefor never be set and can
be removed.
=20
Signed-off-by: Paul Bolle <redacted>
---
0) Tested with "make ARCH=3Dpowerpc menuconfig" and "make ARCH=3Dpowerpc=
oldconfig" (before and after the patch). Enough to see this patch =
didn't
obviously break stuff.
=20
1) I don't really understand commit
193ab2a6070039e7ee2b9b9bebea754a7c52fd1b. Was its point that we =
replace
USB_GADGET_FSL_QE with USB_FSL_QE? I couldn't tell and chose not to
actually change any behavior.
=20
arch/powerpc/sysdev/qe_lib/Kconfig | 1 -
1 file changed, 1 deletion(-)
=20
You're correct that this isn't quite right, I've posted a proper patch =
that should fix this correctly.

thanks for pointing it out.

- k=
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help