Re: [PATCH] pci: Provide support for parsing PCI DT ranges property

On Wed, Dec 12, 2012 at 04:37:50PM +0000, Andrew Murray wrote:
[...]

[...]

+	start = of_get_property(node, "ranges", &rlen);
+	if (start == NULL)
+		return NULL;
+
+	end = start + rlen;

I'm currently rewriting large parts of the Tegra PCIe controller driver
and I'm trying to use this new API. This seems to work fine, except that
I think this line needs to be:

	end = start + rlen / sizeof(__be32);

Otherwise we'll try to process 4 times as many ranges as there are.

Thierry

On Thu, Dec 20, 2012 at 08:25:00AM +0000, Thierry Reding wrote:

On Wed, Dec 12, 2012 at 04:37:50PM +0000, Andrew Murray wrote:
[...]

quoted

diff --git a/drivers/of/address.c b/drivers/of/address.c

[...]

quoted

+=09start =3D of_get_property(node, "ranges", &rlen);
+=09if (start =3D=3D NULL)
+=09=09return NULL;
+
+=09end =3D start + rlen;

=20
I'm currently rewriting large parts of the Tegra PCIe controller driver
and I'm trying to use this new API. This seems to work fine, except that
I think this line needs to be:
=20
=09end =3D start + rlen / sizeof(__be32);
=20
Otherwise we'll try to process 4 times as many ranges as there are.
=20
Thierry

Good catch. Thanks for taking this on.

Andrew Murray