On Wed, Dec 12, 2012 at 10:49 AM, Grant Likely wrote:
On Wed, Dec 12, 2012 at 10:37 AM, Michal Simek <monstr@monstr.eu<mailto:m=
onstr@monstr.eu>> wrote:
quoted
On 12/10/2012 10:41 PM, Grant Likely wrote:
quoted
drivers/pci/pci-of.c would be good. I'd also accept drivers/of/pci.c
which might actually be a good idea in the short term so that it gets
appropriate supervision while being generalized before being moved int=
o
quoted
quoted
the pci directory.
Ben: Are you willing to move that ppc code to this location?
It is probably not good idea that I should do it when I even don't have
hardware available for testing (Asking someone else).
=20
You're a clever guy, you are more than capable of crafting the patch,
even if you can't test on hardware. :-)
=20
I refactored most of the OF support code without having access to most
of the affected hardware. Once I got the changes out there for review
I also asked for spot testing before getting it into linux-next for
even more testing.
I've been working on a relatively architecture agnostic PCI host bridge dri=
ver
and also wanted to avoid duplicating more generic DT parsing code for PCI
bindings.
I've ended up with a patch which provides an iterator for returning resourc=
es
based on the the typical 'ranges' binding. This has ended up living in
drivers/of/address.c. I originally started out in drivers/of/pci.c and
drivers/pci/pci-of.c but found there were good (and static) implementations=
in
drivers/of/address.c which can be reused (e.g. of_bus_pci_get_flags,
bus->count_cells).
I'm not just ready to post it - but can do before early next week if you ca=
n
wait.
Andrew Murray
On Wed, Dec 12, 2012 at 12:19:12PM +0000, Andrew Murray wrote:
On Wed, Dec 12, 2012 at 10:49 AM, Grant Likely wrote:
quoted
On Wed, Dec 12, 2012 at 10:37 AM, Michal Simek <monstr@monstr.eu<mailto:monstr@monstr.eu>> wrote:
quoted
On 12/10/2012 10:41 PM, Grant Likely wrote:
quoted
drivers/pci/pci-of.c would be good. I'd also accept drivers/of/pci.c
which might actually be a good idea in the short term so that it gets
appropriate supervision while being generalized before being moved into
the pci directory.
Ben: Are you willing to move that ppc code to this location?
It is probably not good idea that I should do it when I even don't have
hardware available for testing (Asking someone else).
You're a clever guy, you are more than capable of crafting the patch,
even if you can't test on hardware. :-)
I refactored most of the OF support code without having access to most
of the affected hardware. Once I got the changes out there for review
I also asked for spot testing before getting it into linux-next for
even more testing.
I've been working on a relatively architecture agnostic PCI host bridge driver
and also wanted to avoid duplicating more generic DT parsing code for PCI
bindings.
I've ended up with a patch which provides an iterator for returning resources
based on the the typical 'ranges' binding. This has ended up living in
drivers/of/address.c. I originally started out in drivers/of/pci.c and
drivers/pci/pci-of.c but found there were good (and static) implementations in
drivers/of/address.c which can be reused (e.g. of_bus_pci_get_flags,
bus->count_cells).
I'm not just ready to post it - but can do before early next week if you can
wait.
I already posted a similar patch[0] as part of a larger series to bring
DT support to Tegra PCIe back in July. I suppose what you have must be
something pretty close to that. Most of the stuff that had me occupied
since then should be done soon and I was planning on resurrecting the
series one of these days.
Thierry
[0]: https://patchwork.kernel.org/patch/1244451/
On Wed, Dec 12, 2012 at 01:34:24PM +0000, Thierry Reding wrote:
On Wed, Dec 12, 2012 at 12:19:12PM +0000, Andrew Murray wrote:
quoted
I've been working on a relatively architecture agnostic PCI host bridge=
driver
quoted
and also wanted to avoid duplicating more generic DT parsing code for P=
CI
quoted
bindings.
=20
I've ended up with a patch which provides an iterator for returning res=
ources
quoted
based on the the typical 'ranges' binding. This has ended up living in
drivers/of/address.c. I originally started out in drivers/of/pci.c and
drivers/pci/pci-of.c but found there were good (and static) implementat=
ions in
quoted
drivers/of/address.c which can be reused (e.g. of_bus_pci_get_flags,
bus->count_cells).
=20
I'm not just ready to post it - but can do before early next week if yo=
u can
quoted
wait.
=20
I already posted a similar patch[0] as part of a larger series to bring
DT support to Tegra PCIe back in July. I suppose what you have must be
something pretty close to that. Most of the stuff that had me occupied
since then should be done soon and I was planning on resurrecting the
series one of these days.
Thanks for the reference. I've submitted my patch, it's along the lines of =
your
existing patch.
I'm happy to take the best bits from both, drop mine, etc.
Andrew Murray