# Re: \[PATCH v5 06/14\] memory-hotplug: implement register\_page\_bootmem\_info\_section of sparse-vmemmap

- From: Tang Chen \<hidden\>
- Date: 2012-12-26 03:22:05 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2012/12/3976279
- Thread: https://ratatoskr.run/linux-mm/2012/12/3976020/t.md

```text
On 12/25/2012 04:09 PM, Jianguo Wu wrote:
>> +
>> +		if (!cpu=5Fhas=5Fpse) {
>> +			next =3D (addr + PAGE=5FSIZE)&  PAGE=5FMASK;
>> +			pmd =3D pmd=5Foffset(pud, addr);
>> +			if (pmd=5Fnone(*pmd))
>> +				continue;
>> +			get=5Fpage=5Fbootmem(section=5Fnr, pmd=5Fpage(*pmd),
>> +					 MIX=5FSECTION=5FINFO);
>> +
>> +			pte =3D pte=5Foffset=5Fkernel(pmd, addr);
>> +			if (pte=5Fnone(*pte))
>> +				continue;
>> +			get=5Fpage=5Fbootmem(section=5Fnr, pte=5Fpage(*pte),
>> +					 SECTION=5FINFO);
>> +		} else {
>> +			next =3D pmd=5Faddr=5Fend(addr, end);
>> +
>> +			pmd =3D pmd=5Foffset(pud, addr);
>> +			if (pmd=5Fnone(*pmd))
>> +				continue;
>> +			get=5Fpage=5Fbootmem(section=5Fnr, pmd=5Fpage(*pmd),
>> +					 SECTION=5FINFO);
>
> Hi Tang=EF=BC=8C
> 	In this case, pmd maps 512 pages, but you only get=5Fpage=5Fbootmem() on=
the first page.
> I think the whole 512 pages should be get=5Fpage=5Fbootmem(), what do you=
think?
>
Hi Wu,

Yes, thanks. I will fix it. :)

Thanks. :)

=
```