[PATCH -next] TTY: hvsi: use for_each_compatible_node() macro

Subsystems: hypervisor virtual console driver, the rest, tty layer and serial drivers

STALE4990d

2 messages, 2 authors, 2012-12-05 · open the first message on its own page

[PATCH -next] TTY: hvsi: use for_each_compatible_node() macro

From: Wei Yongjun <hidden>
Date: 2012-12-04 05:16:20

From: Wei Yongjun <redacted>

Use for_each_compatible_node() macro instead of open coding it.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/tty/hvc/hvsi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c
index 5b95b4f..70e0ef7 100644
--- a/drivers/tty/hvc/hvsi.c
+++ b/drivers/tty/hvc/hvsi.c
@@ -1187,9 +1187,7 @@ static int __init hvsi_console_init(void)
 	hvsi_wait = poll_for_state; /* no irqs yet; must poll */
 
 	/* search device tree for vty nodes */
-	for (vty = of_find_compatible_node(NULL, "serial", "hvterm-protocol");
-			vty != NULL;
-			vty = of_find_compatible_node(vty, "serial", "hvterm-protocol")) {
+	for_each_compatible_node(vty, "serial", "hvterm-protocol") {
 		struct hvsi_struct *hp;
 		const uint32_t *vtermno, *irq;
 

Re: [PATCH -next] TTY: hvsi: use for_each_compatible_node() macro

From: Grant Likely <hidden>
Date: 2012-12-05 23:37:05

On Tue, 4 Dec 2012 00:16:18 -0500, Wei Yongjun [off-list ref] wrote:
From: Wei Yongjun <redacted>

Use for_each_compatible_node() macro instead of open coding it.

Signed-off-by: Wei Yongjun <redacted>
Acked-by: Grant Likely <redacted>
quoted hunk
---
 drivers/tty/hvc/hvsi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c
index 5b95b4f..70e0ef7 100644
--- a/drivers/tty/hvc/hvsi.c
+++ b/drivers/tty/hvc/hvsi.c
@@ -1187,9 +1187,7 @@ static int __init hvsi_console_init(void)
 	hvsi_wait = poll_for_state; /* no irqs yet; must poll */
 
 	/* search device tree for vty nodes */
-	for (vty = of_find_compatible_node(NULL, "serial", "hvterm-protocol");
-			vty != NULL;
-			vty = of_find_compatible_node(vty, "serial", "hvterm-protocol")) {
+	for_each_compatible_node(vty, "serial", "hvterm-protocol") {
 		struct hvsi_struct *hp;
 		const uint32_t *vtermno, *irq;
 
-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help