[PATCH -next] powerpc/85xx: use for_each_compatible_node() macro

Subsystems: linux for powerpc (32-bit and 64-bit), linux for powerpc embedded ppc85xx, the rest

STALE4923d

3 messages, 3 authors, 2013-02-12 · open the first message on its own page

[PATCH -next] powerpc/85xx: use for_each_compatible_node() macro

From: Wei Yongjun <hidden>
Date: 2012-12-03 13:36:06

From: Wei Yongjun <redacted>

Use for_each_compatible_node() macro instead of open coding it.

Signed-off-by: Wei Yongjun <redacted>
---
 arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
index bd12588..a7b3621 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -206,9 +206,7 @@ static void __init mpc85xx_mds_reset_ucc_phys(void)
 		setbits8(&bcsr_regs[7], BCSR7_UCC12_GETHnRST);
 		clrbits8(&bcsr_regs[8], BCSR8_UEM_MARVELL_RST);
 
-		for (np = NULL; (np = of_find_compatible_node(np,
-						"network",
-						"ucc_geth")) != NULL;) {
+		for_each_compatible_node(np, "network", "ucc_geth") {
 			const unsigned int *prop;
 			int ucc_num;
 

Re: [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro

From: Grant Likely <hidden>
Date: 2012-12-05 23:51:39

On Mon, 3 Dec 2012 08:36:03 -0500, Wei Yongjun [off-list ref] wrote:
From: Wei Yongjun <redacted>

Use for_each_compatible_node() macro instead of open coding it.

Signed-off-by: Wei Yongjun <redacted>
Acked-by: Grant Likely <redacted>
quoted hunk
---
 arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
index bd12588..a7b3621 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -206,9 +206,7 @@ static void __init mpc85xx_mds_reset_ucc_phys(void)
 		setbits8(&bcsr_regs[7], BCSR7_UCC12_GETHnRST);
 		clrbits8(&bcsr_regs[8], BCSR8_UEM_MARVELL_RST);
 
-		for (np = NULL; (np = of_find_compatible_node(np,
-						"network",
-						"ucc_geth")) != NULL;) {
+		for_each_compatible_node(np, "network", "ucc_geth") {
 			const unsigned int *prop;
 			int ucc_num;
 
-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.

Re: [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro

From: Kumar Gala <hidden>
Date: 2013-02-12 20:02:51

On Dec 3, 2012, at 7:36 AM, Wei Yongjun wrote:
From: Wei Yongjun <redacted>

Use for_each_compatible_node() macro instead of open coding it.

Signed-off-by: Wei Yongjun <redacted>
---
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
applied to next

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help