[PATCH] powerpc, perf: Change PMU flag values representation from decimal to hex

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE5004d

3 messages, 2 authors, 2012-11-19 · open the first message on its own page

[PATCH] powerpc, perf: Change PMU flag values representation from decimal to hex

From: Anshuman Khandual <hidden>
Date: 2012-11-16 08:59:45

Signed-off-by: Anshuman Khandual <redacted>
---
 arch/powerpc/include/asm/perf_event_server.h | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/perf_event_server.h b/arch/powerpc/include/asm/perf_event_server.h
index 9710be3..e3f10bb 100644
--- a/arch/powerpc/include/asm/perf_event_server.h
+++ b/arch/powerpc/include/asm/perf_event_server.h
@@ -11,6 +11,7 @@
 
 #include <linux/types.h>
 #include <asm/hw_irq.h>
+#include <asm/asm-compat.h>
 
 #define MAX_HWEVENTS		8
 #define MAX_EVENT_ALTERNATIVES	8
@@ -45,11 +46,21 @@ struct power_pmu {
 /*
  * Values for power_pmu.flags
  */
-#define PPMU_LIMITED_PMC5_6	1	/* PMC5/6 have limited function */
-#define PPMU_ALT_SIPR		2	/* uses alternate posn for SIPR/HV */
-#define PPMU_NO_SIPR		4	/* no SIPR/HV in MMCRA at all */
-#define PPMU_NO_CONT_SAMPLING	8	/* no continuous sampling */
-#define PPMU_SIAR_VALID		16	/* Processor has SIAR Valid bit */
+
+#define PPMU_LIMITED_PMC5_6	\
+	LONG_ASM_CONST(0x0000000000000001) /* PMC5/6 have limited function */
+
+#define PPMU_ALT_SIPR		\
+	LONG_ASM_CONST(0x0000000000000002) /* uses alternate posn for SIPR/HV */
+
+#define PPMU_NO_SIPR		\
+	LONG_ASM_CONST(0x0000000000000004) /* no SIPR/HV in MMCRA at all */
+
+#define PPMU_NO_CONT_SAMPLING	\
+	LONG_ASM_CONST(0x0000000000000008) /* no continuous sampling */
+
+#define PPMU_SIAR_VALID		\
+	LONG_ASM_CONST(0x0000000000000010) /* Processor has SIAR Valid bit */
 
 /*
  * Values for flags to get_alternatives()
-- 
1.7.11.7

Re: [PATCH] powerpc, perf: Change PMU flag values representation from decimal to hex

From: Paul Mackerras <hidden>
Date: 2012-11-16 11:42:38

On Fri, Nov 16, 2012 at 02:29:04PM +0530, Anshuman Khandual wrote:
Signed-off-by: Anshuman Khandual <redacted>
That's not a sufficient description of why you are making this
change.  In particular, what is the motivation for and impact of using
LONG_ASM_CONST?

Paul.

Re: [PATCH] powerpc, perf: Change PMU flag values representation from decimal to hex

From: Anshuman Khandual <hidden>
Date: 2012-11-19 06:15:00

On 11/16/2012 05:12 PM, Paul Mackerras wrote:
On Fri, Nov 16, 2012 at 02:29:04PM +0530, Anshuman Khandual wrote:
quoted
Signed-off-by: Anshuman Khandual <redacted>
That's not a sufficient description of why you are making this
change.  In particular, what is the motivation for and impact of using
LONG_ASM_CONST?

Paul.
Hey Paul,

I have just sent out a revised patch where I have updated the description
and dropped the usage of LONG_ASM_CONST.

Regards
Anshuman 
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help