# Re: \[PATCH\] cpuidle: Measure idle state durations with monotonic clock

- From: Preeti Murthy \<hidden\>
- Date: 2012-11-15 09:04:50 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2012/11/3957436
- Thread: https://ratatoskr.run/linux-acpi/2012/11/3956176/t.md

```text
Hi all,

The code looks correct and inviting to me as it has led to good cleanups.
I dont think passing 0 as the argument to the function
sched_clock_idle_wakeup_event()
should lead to problems,as it does not do anything useful with the
passed arguments.

My only curiosity is what was the purpose of passing idle residency time to
sched_clock_idle_wakeup_event() when this data could always be retrieved from
dev->last_residency for each cpu,which gets almost immediately updated.

But this does not seem to come in way of this patch for now.Anyway I
have added Peter to
the list so that he can opine about this issue if possible and needed.

Reviewed-by: Preeti U Murthy <redacted>


Regards
Preeti U Murthy
```