# Re: \[PATCH 2/3\] usb: gadget: fsl\_qe\_udc: do not use tasklet\_disable before tasklet\_kill

- From: Felipe Balbi \<hidden\>
- Date: 2012-10-31 14:41:06 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2012/10/3949626
- Thread: https://ratatoskr.run/linuxppc-dev/2012/10/3949375/t.md

```text
Hi,

On Wed, Oct 31, 2012 at 10:35:37PM +0800, Li Yang wrote:
> On Wed, Oct 31, 2012 at 9:26 PM, Felipe Balbi [ref] wrote:
> > On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote:
> >> If tasklet_disable() is called before related tasklet handled,
> >> tasklet_kill will never be finished. tasklet_kill is enough.
> >
> > how did you test this ? Why changing FSL driver instead of switching
> > over to chipidea which is supposed to be shared by every licensee of the
> > chipidea core ?
> 
> The QE UDC is an private controller that is not compatible with the
> Chipidea core.

thanks for the clarification, but you still haven't answered how you
tested this ;-)

-- 
balbi
```

## Attachments

- [signature.asc](https://ratatoskr.run/linuxppc-dev/2012/10/3949626/attachment/0) (application/pgp-signature, 836 bytes)