# Re: \[PATCH v2 4/7\] dt/powerpc/sysdev: Use of\_get\_child\_by\_name to get a named child.

- List: linuxppc-dev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linuxppc-dev/2012/09/8063182/t

## Re: \[PATCH v2 4/7\] dt/powerpc/sysdev: Use of\_get\_child\_by\_name to get a named child.

- From: Rob Herring \<hidden\>
- Date: 2012-09-14 13:05:52 
- Message: https://ratatoskr.run/linuxppc-dev/2012/09/8063182.md

```text
On 09/14/2012 03:19 AM, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <redacted>
> 
> As follow-up to "dt: introduce of_get_child_by_name to get child node by
> name." patch, This patch removes some of the code duplication in the
> driver by replacing it with of_get_child_by_name instead.
> 
> Signed-off-by: Srinivas Kandagatla <redacted>
> ---
>  arch/powerpc/sysdev/qe_lib/qe.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
> index b043675..fd1c15d 100644
> --- a/arch/powerpc/sysdev/qe_lib/qe.c
> +++ b/arch/powerpc/sysdev/qe_lib/qe.c
> @@ -568,10 +568,7 @@ struct qe_firmware_info *qe_get_firmware_info(void)
>  	}
>  
>  	/* Find the 'firmware' child node */
> -	for_each_child_of_node(qe, fw) {
> -		if (strcmp(fw->name, "firmware") == 0)
> -			break;
> -	}
> +	fw = of_get_child_by_name(qe "firmware");

Missing comma.

>  
>  	of_node_put(qe);
>  
> 
```

## Re: \[PATCH v2 4/7\] dt/powerpc/sysdev: Use of\_get\_child\_by\_name to get a named child.

- From: Srinivas KANDAGATLA \<hidden\>
- Date: 2012-09-14 13:15:40 
- Message: https://ratatoskr.run/linuxppc-dev/2012/09/8063186.md

```text

Thanks for pointing the typo..

On 14/09/12 14:05, Rob Herring wrote:
> On 09/14/2012 03:19 AM, Srinivas KANDAGATLA wrote:
>> From: Srinivas Kandagatla <redacted>
>>
>> As follow-up to "dt: introduce of_get_child_by_name to get child node by
>> name." patch, This patch removes some of the code duplication in the
>> driver by replacing it with of_get_child_by_name instead.
>>
>> Signed-off-by: Srinivas Kandagatla <redacted>
>> ---
>>  arch/powerpc/sysdev/qe_lib/qe.c |    5 +----
>>  1 files changed, 1 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
>> index b043675..fd1c15d 100644
>> --- a/arch/powerpc/sysdev/qe_lib/qe.c
>> +++ b/arch/powerpc/sysdev/qe_lib/qe.c
>> @@ -568,10 +568,7 @@ struct qe_firmware_info *qe_get_firmware_info(void)
>>  	}
>>  
>>  	/* Find the 'firmware' child node */
>> -	for_each_child_of_node(qe, fw) {
>> -		if (strcmp(fw->name, "firmware") == 0)
>> -			break;
>> -	}
>> +	fw = of_get_child_by_name(qe "firmware");
> Missing comma.
>
>>  
>>  	of_node_put(qe);
>>  
>>
>
>
```