# RE: \[PATCH\] edac/85xx: fix error handle of mpc85xx\_mc\_err\_probe

- From: Xie Shaohui-B21989 \<hidden\>
- Date: 2012-09-17 10:33:08 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2012/09/3924430
- Thread: https://ratatoskr.run/linuxppc-dev/2012/09/3922781/t.md

```text
> -----Original Message-----
> From: Shaun Ruffell [mailto:<redacted>]
> Sent: Saturday, September 15, 2012 2:22 AM
> To: Xie Shaohui-B21989
> Cc: <redacted>; <redacted>;
> akpm@linux-foundation.org; avorontsov@mvista.com; linux-
> kernel@vger.kernel.org; grant.likely@secretlab.ca
> Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe
>=20
> On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote:
> > Error handle in case of DDR ECC off is wrong, sysfs entries have not
> > been created, so edac_mc_free which frees a mci instance should not be
> called.
> > Also, free mci's memory in this case.
>=20
> Jus FYI: I ran into the same error in edac_mc_free() which I resolved in
> a slightly different way in some patches I sent previously. [1]
>=20
> [1] https://lkml.org/lkml/2012/9/14/475
[S.H] Thanks! I did not aware of this patch when one of my colleague asked =
me to have a look at the issue,
It could save me some time if I saw this patch earlier. :(

BTW: seems you are using a different kernel tree with mine.

Best Regards,=20
Shaohui Xie
```