# Re: \[PATCH v7 1/8\] Talitos: Support for async\_tx XOR offload

- From: Dan Williams \<hidden\>
- Date: 2012-09-02 06:47:59 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2012/09/3916542
- Thread: https://ratatoskr.run/linux-crypto/2012/08/3905829/t.md

```text
On Thu, Aug 30, 2012 at 7:23 AM, Geanta Neag Horia Ioan-B05471
[ref] wrote:
>
> Besides these:
> 1. As Dan Williams mentioned, you should explain why you are using
> both spin_lock_bh and spin_lock_irqsave on the same lock.

It looks like talitos_process_pending() can be called from hardirq
context via talitos_error().  So spin_lock_bh is not sufficient.
```