# Re: \[PATCH 4/8\] time: Condense timekeeper.xtime into xtime\_sec

- List: linuxppc-dev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linuxppc-dev/2012/08/3911802/t

## Re: \[PATCH 4/8\] time: Condense timekeeper.xtime into xtime\_sec

- From: Andreas Schwab \<hidden\>
- Date: 2012-08-21 07:14:17 
- Message: https://ratatoskr.run/linuxppc-dev/2012/08/3911802.md

```text
John Stultz [ref] writes:

> @@ -115,6 +115,7 @@ static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts)
>  {
>  	tk->xtime_sec += ts->tv_sec;
>  	tk->xtime_nsec += (u64)ts->tv_nsec << tk->shift;
> +	tk_normalize_xtime(tk);
>  }

Yes, that does it.  Failure to normalize is always bad.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
```

## Re: \[PATCH 4/8\] time: Condense timekeeper.xtime into xtime\_sec

- From: John Stultz \<hidden\>
- Date: 2012-08-21 18:15:22 
- Message: https://ratatoskr.run/linuxppc-dev/2012/08/3912265.md

```text
On 08/21/2012 12:14 AM, Andreas Schwab wrote:
> John Stultz [ref] writes:
>
>> @@ -115,6 +115,7 @@ static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts)
>>   {
>>   	tk->xtime_sec += ts->tv_sec;
>>   	tk->xtime_nsec += (u64)ts->tv_nsec << tk->shift;
>> +	tk_normalize_xtime(tk);
>>   }
> Yes, that does it.  Failure to normalize is always bad.

Great. Thanks for the testing and the bug report! I'll be sending out the patch to -tip later today.

thanks
-john
```