# Re: \[PATCH 4/8\] time: Condense timekeeper.xtime into xtime\_sec

- List: linuxppc-dev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linuxppc-dev/2012/08/3911614/t

## Re: \[PATCH 4/8\] time: Condense timekeeper.xtime into xtime\_sec

- From: Andreas Schwab \<hidden\>
- Date: 2012-08-20 19:45:33 
- Message: https://ratatoskr.run/linuxppc-dev/2012/08/3911614.md

```text
John Stultz [ref] writes:

> I'm not very familiar w/ the iBook hardware, but does it use a 
> clocksource, or does it use arch_gettimeoffset()?

clocksource: timebase mult[3640e38e] shift[24] registered

> I suspect that the casting has avoided clipping some strange values from 
> the persistent clock.

That's my guess as well.

> Could you try with the following patch against Linus' HEAD? I suspect it 
> will let the box resume (although it will seem as though no time was 
> spent in resume) and then let me know what the JDB lines print out?

JDB: suspend_time: 1345491706:0  resume_time: 1345491737:0
JDB: Trying to add: 31:0

(Looks reasonable.)

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
```

## Re: \[PATCH 4/8\] time: Condense timekeeper.xtime into xtime\_sec

- From: John Stultz \<hidden\>
- Date: 2012-08-20 19:58:20 
- Message: https://ratatoskr.run/linuxppc-dev/2012/08/3911631.md

```text
On 08/20/2012 12:45 PM, Andreas Schwab wrote:
> John Stultz [ref] writes:
>
>> I'm not very familiar w/ the iBook hardware, but does it use a
>> clocksource, or does it use arch_gettimeoffset()?
> clocksource: timebase mult[3640e38e] shift[24] registered
>
>> I suspect that the casting has avoided clipping some strange values from
>> the persistent clock.
> That's my guess as well.
>
>> Could you try with the following patch against Linus' HEAD? I suspect it
>> will let the box resume (although it will seem as though no time was
>> spent in resume) and then let me know what the JDB lines print out?
> JDB: suspend_time: 1345491706:0  resume_time: 1345491737:0
> JDB: Trying to add: 31:0
>
> (Looks reasonable.)
Huh.  Yea, that looks fine.  And without the __timekeeping_inject_sleeptime() call, the system resumed ok?

Thanks for the testing!  I'll keep looking here.
-john
```