# Re: \[PATCH v3 2/2\] powerpc: Uprobes port to powerpc

- From: Oleg Nesterov \<oleg@redhat.com\>
- Date: 2012-08-15 17:03:26 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2012/08/3908798
- Thread: https://ratatoskr.run/linuxppc-dev/2012/07/3898939/t.md

```text
On 07/26, Ananth N Mavinakayanahalli wrote:
>
> From: Ananth N Mavinakayanahalli <redacted>
>
> This is the port of uprobes to powerpc. Usage is similar to x86.

I am just curious why this series was ignored by powerpc maintainers...

Of course I can not review this code, I know nothing about powerpc,
but the patches look simple/straightforward.

Paul, Benjamin?





Just one question... Shouldn't arch_uprobe_pre_xol() forbid to probe
UPROBE_SWBP_INSN (at least) ?

(I assume that emulate_step() can't handle this case but of course I
 do not understand arch/powerpc/lib/sstep.c)

Note that uprobe_pre_sstep_notifier() sets utask->state = UTASK_BP_HIT
without any checks. This doesn't look right if it was UTASK_SSTEP...

But again, I do not know what powepc will actually do if we try to
single-step over UPROBE_SWBP_INSN.

Oleg.
```