[PATCH 1/2] powerpc/mpc8572ds: Fix eTSEC is not available on core1 of AMP boot issue

The issue log on core1 is:
root@mpc8572ds:~# ifconfig eth0 10.192.208.244
net eth0: could not attach to PHY
SIOCSIFFLAGS: No such device

To attach PHY node mdio@24520 should not be disabled in dts of core1.
Because all PHYs are controlled through this node as follows:

mdio@24520 {
	phy0: ethernet-phy@0 {
		interrupts = <10 1 0 0>;
		reg = <0x0>;
	};
	phy1: ethernet-phy@1 {
		interrupts = <10 1 0 0>;
		reg = <0x1>;
	};
	phy2: ethernet-phy@2 {
		interrupts = <10 1 0 0>;
		reg = <0x2>;
	};
	phy3: ethernet-phy@3 {
		interrupts = <10 1 0 0>;
		reg = <0x3>;
	};

	tbi0: tbi-phy@11 {
		reg = <0x11>;
		device_type = "tbi-phy";
	};
};

Signed-off-by: Li Yang <redacted>
Signed-off-by: Jia Hongtao <redacted>
---
 arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts b/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts
index d6a8faf..1932396 100644
--- a/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts
+++ b/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts

@@ -67,9 +67,6 @@
 		ethernet@24000 {
 			status = "disabled";
 		};
-		mdio@24520 {
-			status = "disabled";
-		};
 		ptp_clock@24e00 {
 			status = "disabled";
 		};

-- 
1.7.5.1

With 2-cell format interrupts of MSI PCIe ethernet card can not work.

Signed-off-by: Li Yang <redacted>
Signed-off-by: Jia Hongtao <redacted>
---
 arch/powerpc/boot/dts/mpc8572ds_camp_core0.dts |    8 ++++----
 arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts |    8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8572ds_camp_core0.dts b/arch/powerpc/boot/dts/mpc8572ds_camp_core0.dts
index d34d127..ef9ef56 100644
--- a/arch/powerpc/boot/dts/mpc8572ds_camp_core0.dts
+++ b/arch/powerpc/boot/dts/mpc8572ds_camp_core0.dts

@@ -67,10 +67,10 @@
 		msi@41600 {
 			msi-available-ranges = <0 0x80>;
 			interrupts = <
-				0xe0 0
-				0xe1 0
-				0xe2 0
-				0xe3 0>;
+				0xe0 0 0 0
+				0xe1 0 0 0
+				0xe2 0 0 0
+				0xe3 0 0 0>;
 		};
 		timer@42100 {
 			status = "disabled";

diff --git a/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts b/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts
index 1932396..24564ee 100644
--- a/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts
+++ b/arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts

@@ -97,10 +97,10 @@
 		msi@41600 {
 			msi-available-ranges = <0x80 0x80>;
 			interrupts = <
-				0xe4 0
-				0xe5 0
-				0xe6 0
-				0xe7 0>;
+				0xe4 0 0 0
+				0xe5 0 0 0
+				0xe6 0 0 0
+				0xe7 0 0 0>;
 		};
 		global-utilities@e0000 {
 			status = "disabled";

-- 
1.7.5.1

On Jul 10, 2012, at 1:08 AM, Jia Hongtao wrote:

The issue log on core1 is:
root@mpc8572ds:~# ifconfig eth0 10.192.208.244
net eth0: could not attach to PHY
SIOCSIFFLAGS: No such device

To attach PHY node mdio@24520 should not be disabled in dts of core1.
Because all PHYs are controlled through this node as follows:

mdio@24520 {
	phy0: ethernet-phy@0 {
		interrupts = <10 1 0 0>;
		reg = <0x0>;
	};
	phy1: ethernet-phy@1 {
		interrupts = <10 1 0 0>;
		reg = <0x1>;
	};
	phy2: ethernet-phy@2 {
		interrupts = <10 1 0 0>;
		reg = <0x2>;
	};
	phy3: ethernet-phy@3 {
		interrupts = <10 1 0 0>;
		reg = <0x3>;
	};

	tbi0: tbi-phy@11 {
		reg = <0x11>;
		device_type = "tbi-phy";
	};
};

Signed-off-by: Li Yang <redacted>
Signed-off-by: Jia Hongtao <redacted>
---
arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts |    3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

applied to next

- k

On Jul 10, 2012, at 1:08 AM, Jia Hongtao wrote:

With 2-cell format interrupts of MSI PCIe ethernet card can not work.

Signed-off-by: Li Yang <redacted>
Signed-off-by: Jia Hongtao <redacted>
---
arch/powerpc/boot/dts/mpc8572ds_camp_core0.dts |    8 ++++----
arch/powerpc/boot/dts/mpc8572ds_camp_core1.dts |    8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)

applied to next

- k

On 07/10/2012 01:08 AM, Jia Hongtao wrote:

The issue log on core1 is:
root@mpc8572ds:~# ifconfig eth0 10.192.208.244
net eth0: could not attach to PHY
SIOCSIFFLAGS: No such device

To attach PHY node mdio@24520 should not be disabled in dts of core1.
Because all PHYs are controlled through this node as follows:

So you grant it to both partitions?  How do you deal with synchronization?

-Scott

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBKdWx5IDExLCAyMDEyIDI6MTUgQU0NCj4gVG86IEppYSBI
b25ndGFvLUIzODk1MQ0KPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGdhbGFr
QGtlcm5lbC5jcmFzaGluZy5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIHBvd2VycGMv
bXBjODU3MmRzOiBGaXggZVRTRUMgaXMgbm90IGF2YWlsYWJsZSBvbg0KPiBjb3JlMSBvZiBBTVAg
Ym9vdCBpc3N1ZQ0KPiANCj4gT24gMDcvMTAvMjAxMiAwMTowOCBBTSwgSmlhIEhvbmd0YW8gd3Jv
dGU6DQo+ID4gVGhlIGlzc3VlIGxvZyBvbiBjb3JlMSBpczoNCj4gPiByb290QG1wYzg1NzJkczp+
IyBpZmNvbmZpZyBldGgwIDEwLjE5Mi4yMDguMjQ0DQo+ID4gbmV0IGV0aDA6IGNvdWxkIG5vdCBh
dHRhY2ggdG8gUEhZDQo+ID4gU0lPQ1NJRkZMQUdTOiBObyBzdWNoIGRldmljZQ0KPiA+DQo+ID4g
VG8gYXR0YWNoIFBIWSBub2RlIG1kaW9AMjQ1MjAgc2hvdWxkIG5vdCBiZSBkaXNhYmxlZCBpbiBk
dHMgb2YgY29yZTEuDQo+ID4gQmVjYXVzZSBhbGwgUEhZcyBhcmUgY29udHJvbGxlZCB0aHJvdWdo
IHRoaXMgbm9kZSBhcyBmb2xsb3dzOg0KPiANCj4gU28geW91IGdyYW50IGl0IHRvIGJvdGggcGFy
dGl0aW9ucz8gIEhvdyBkbyB5b3UgZGVhbCB3aXRoIHN5bmNocm9uaXphdGlvbj8NCj4gDQo+IC1T
Y290dA0KDQpQSFkgbm9kZXMgYXJlIG9ubHkgdXNlZCBieSBldGhlcm5ldC4gRWFjaCBldGhlcm5l
dCBpcyB1c2VkIGJ5IG9ubHkgb25lIHBhcnRpdGlvbg0KKGRpc2FibGVkIGluIHRoZSBvdGhlciBw
YXJ0aXRpb24pLiBTbyBJIHRoaW5rIHRoZXJlIGlzIG5vIHN5bmNocm9uaXphdGlvbiBpc3N1ZS4N
Cg0KVGhhbmtzLg0KLUppYSBIb25ndGFvLiANCg==

On 07/10/2012 09:07 PM, Jia Hongtao-B38951 wrote:

quoted

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, July 11, 2012 2:15 AM
To: Jia Hongtao-B38951
Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org
Subject: Re: [PATCH 1/2] powerpc/mpc8572ds: Fix eTSEC is not available on
core1 of AMP boot issue

On 07/10/2012 01:08 AM, Jia Hongtao wrote:

quoted

The issue log on core1 is:
root@mpc8572ds:~# ifconfig eth0 10.192.208.244
net eth0: could not attach to PHY
SIOCSIFFLAGS: No such device

To attach PHY node mdio@24520 should not be disabled in dts of core1.
Because all PHYs are controlled through this node as follows:

So you grant it to both partitions?  How do you deal with synchronization?

-Scott

PHY nodes are only used by ethernet. Each ethernet is used by only one partition
(disabled in the other partition). So I think there is no synchronization issue.

I mean for accessing the MDIO bus.

-Scott