[PATCH 7/7] mm/memory.c : cleanup the coding style issue

Subsystems: memory management, memory management - core, the rest

STALE5233d

2 messages, 2 authors, 2012-06-15 · open the first message on its own page

[PATCH 7/7] mm/memory.c : cleanup the coding style issue

From: Wanpeng Li <hidden>
Date: 2012-06-15 13:21:16

From: Wanpeng Li <redacted>

Signed-off-by: Wanpeng Li <redacted>

---
 mm/memory.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index 1b7dc66..195d6e1 100644
--- a/mm/memory.c
+++ b/mm/memory.c

@@ -2447,7 +2447,8 @@ static inline int pte_unmap_same(struct mm_struct *mm, pmd_t *pmd,
 	return same;
 }
 
-static inline void cow_user_page(struct page *dst, struct page *src, unsigned long va, struct vm_area_struct *vma)
+static inline void cow_user_page(struct page *dst, struct page *src,
+		unsigned long va, struct vm_area_struct *vma)
 {
 	/*
 	 * If the source page was a PFN mapping, we don't have

-- 
1.7.9.5

Re: [PATCH 7/7] mm/memory.c : cleanup the coding style issue

From: KOSAKI Motohiro <hidden>
Date: 2012-06-15 19:41:16

quoted hunk

diff --git a/mm/memory.c b/mm/memory.c
index 1b7dc66..195d6e1 100644
--- a/mm/memory.c
+++ b/mm/memory.c

@@ -2447,7 +2447,8 @@ static inline int pte_unmap_same(struct mm_struct *mm, pmd_t *pmd,
 	return same;
 }
 
-static inline void cow_user_page(struct page *dst, struct page *src, unsigned long va, struct vm_area_struct *vma)
+static inline void cow_user_page(struct page *dst, struct page *src,
+		unsigned long va, struct vm_area_struct *vma)
 {
 	/*
 	 * If the source page was a PFN mapping, we don't have

Nowadays, many developers prefer to declare a function in one line. and we don't think
this is incorrect anymore. so, I think this is intentional.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help