[PATCH] powerpc: fix system.h fallout in sysdev/scom.c [chroma_defconfig]

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE5260d

2 messages, 2 authors, 2012-04-16 · open the first message on its own page

[PATCH] powerpc: fix system.h fallout in sysdev/scom.c [chroma_defconfig]

From: Paul Gortmaker <hidden>
Date: 2012-04-16 05:04:48

The following shows up in chroma_defconfig:

 CC      arch/powerpc/sysdev/scom.o
arch/powerpc/sysdev/scom.c: In function 'scom_debug_init':
arch/powerpc/sysdev/scom.c:182:36: error: 'powerpc_debugfs_root' undeclared (first use in this function)
arch/powerpc/sysdev/scom.c:182:36: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [arch/powerpc/sysdev/scom.o] Error 1
make[1]: *** [arch/powerpc/sysdev/scom.o] Error 2

A bisect leads to commit 9ffc93f203c18a70623f21950f1dd473c9ec48cd

    "Remove all #inclusions of asm/system.h"

Add the debug header which contains powerpc_debugfs_root.

Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Paul Gortmaker <redacted>
---

[Ben, let me know if you want to take this or have me keep it.]
diff --git a/arch/powerpc/sysdev/scom.c b/arch/powerpc/sysdev/scom.c
index 49a3ece..702256a 100644
--- a/arch/powerpc/sysdev/scom.c
+++ b/arch/powerpc/sysdev/scom.c
@@ -22,6 +22,7 @@
 #include <linux/debugfs.h>
 #include <linux/slab.h>
 #include <linux/export.h>
+#include <asm/debug.h>
 #include <asm/prom.h>
 #include <asm/scom.h>
 
-- 
1.7.9.1

Re: [PATCH] powerpc: fix system.h fallout in sysdev/scom.c [chroma_defconfig]

From: David Howells <dhowells@redhat.com>
Date: 2012-04-16 08:37:40

Paul Gortmaker [off-list ref] wrote:
The following shows up in chroma_defconfig:

 CC      arch/powerpc/sysdev/scom.o
arch/powerpc/sysdev/scom.c: In function 'scom_debug_init':
arch/powerpc/sysdev/scom.c:182:36: error: 'powerpc_debugfs_root' undeclared (first use in this function)
arch/powerpc/sysdev/scom.c:182:36: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [arch/powerpc/sysdev/scom.o] Error 1
make[1]: *** [arch/powerpc/sysdev/scom.o] Error 2

A bisect leads to commit 9ffc93f203c18a70623f21950f1dd473c9ec48cd

    "Remove all #inclusions of asm/system.h"

Add the debug header which contains powerpc_debugfs_root.

Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Paul Gortmaker <redacted>
Acked-by: David Howells <dhowells@redhat.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help