[PATCH] powerpc/fsl_msi : return proper error value when ioremap failed.

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE5318d

4 messages, 3 authors, 2012-03-16 · open the first message on its own page

[PATCH] powerpc/fsl_msi : return proper error value when ioremap failed.

From: <hidden>
Date: 2012-03-12 10:44:09

From: Liu Shuo <redacted>

Signed-off-by: Liu Shuo <redacted>
---
 arch/powerpc/sysdev/fsl_msi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
index ecb5c19..0bab156 100644
--- a/arch/powerpc/sysdev/fsl_msi.c
+++ b/arch/powerpc/sysdev/fsl_msi.c
@@ -410,6 +410,7 @@ static int __devinit fsl_of_msi_probe(struct platform_device *dev)
 
 		msi->msi_regs = ioremap(res.start, resource_size(&res));
 		if (!msi->msi_regs) {
+			err = -ENOMEM;
 			dev_err(&dev->dev, "could not map node %s\n",
 				dev->dev.of_node->full_name);
 			goto error_out;
-- 
1.7.4.1

Re: [PATCH] powerpc/fsl_msi : return proper error value when ioremap failed.

From: Timur Tabi <hidden>
Date: 2012-03-12 16:10:28

soniccat.liu@gmail.com wrote:
From: Liu Shuo <redacted>

Signed-off-by: Liu Shuo <redacted>
Acked-by: Timur Tabi <redacted>

This is not a critical fix for 3.3, but it should probably be applied to
3.3-stable.

-- 
Timur Tabi
Linux kernel developer at Freescale

Re: [PATCH] powerpc/fsl_msi : return proper error value when ioremap failed.

From: Kumar Gala <hidden>
Date: 2012-03-16 15:14:33

On Mar 8, 2012, at 4:47 PM, soniccat.liu@gmail.com wrote:
From: Liu Shuo <redacted>

Signed-off-by: Liu Shuo <redacted>
---
arch/powerpc/sysdev/fsl_msi.c |    1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applied

- k

Re: [PATCH] powerpc/fsl_msi : return proper error value when ioremap failed.

From: Kumar Gala <hidden>
Date: 2012-03-16 15:24:58

On Mar 8, 2012, at 4:47 PM, soniccat.liu@gmail.com wrote:
From: Liu Shuo <redacted>

Signed-off-by: Liu Shuo <redacted>
---
arch/powerpc/sysdev/fsl_msi.c |    1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applied

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help