Re: [PATCH] Device Tree Bindings for Freescale TDM controller

On Sat, Mar 17, 2012 at 2:33 AM, Aggrwal Poonam-B10812
[off-list ref] wrote:

quoted

quoted

+ =A0 =A0 =A0 =A0 =A0 compatible =3D "fsl,p1010-tdm", "fsl,mpc8315-tdm=

";

quoted

quoted

+ =A0 =A0 =A0 =A0 =A0 reg =3D <0x16000 0x200 0x2c000 0x2000>;
+ =A0 =A0 =A0 =A0 =A0 clock-frequency =3D <0>;

Show a real clock-frequency, perhaps with a comment saying it's typicall=

y

quoted

filled in by boot software.

Okay.

Scott, are you suggesting that Poonam put a non-zero number in the DTS
for clock-frequency?  If so, then I don't think that's a good idea, if
U-Boot will always override it.

--=20
Timur Tabi
Linux kernel developer at Freescale=

On 03/17/2012 11:07 AM, Tabi Timur-B04825 wrote:

On Sat, Mar 17, 2012 at 2:33 AM, Aggrwal Poonam-B10812
[off-list ref] wrote:

quoted

quoted

quoted

+           compatible = "fsl,p1010-tdm", "fsl,mpc8315-tdm";
+           reg = <0x16000 0x200 0x2c000 0x2000>;
+           clock-frequency = <0>;

Show a real clock-frequency, perhaps with a comment saying it's typically
filled in by boot software.

quoted

Okay.

Scott, are you suggesting that Poonam put a non-zero number in the DTS
for clock-frequency?  If so, then I don't think that's a good idea, if
U-Boot will always override it.

This is a device tree binding document, not U-Boot specific.  It
describes what Linux (or another OS) can expect to see, not how it gets
there.

-Scott