[PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

4 messages, 4 authors, 2012-02-27 · open the first message on its own page

[PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds

From: Paul Gortmaker <hidden>
Date: 2012-02-21 23:11:10

The following are seen while using the corenet64_smp_defconfig:

arch/powerpc/sysdev/fsl_rmu.c:315: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:330: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:332: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:339: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:340: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:341: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:659: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:659: error: format '%8.8x' expects type 'unsigned int', but argument 5 has type 'size_t'
arch/powerpc/sysdev/fsl_rmu.c:985: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:997: error: cast to pointer from integer of different size

A quick inspection of the code leaves one with the impression
that it was not explicitly written with 64 bit support in mind,
so just block that as a possible config selection for now.

Signed-off-by: Paul Gortmaker <redacted>

---

[This is seen in linux-next -- not sure if this is the right way to go
 but at least it will give the issue some visibility to the right ppl.]

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 75f061e..5ad8013 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig

@@ -773,7 +773,7 @@ config RAPIDIO
 
 config FSL_RIO
 	bool "Freescale Embedded SRIO Controller support"
-	depends on RAPIDIO && HAS_RAPIDIO
+	depends on RAPIDIO && HAS_RAPIDIO && (BROKEN || !PPC64)
 	default "n"
 	---help---
 	  Include support for RapidIO controller on Freescale embedded

-- 
1.7.9.1

Re: [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds

From: Paul Gortmaker <hidden>
Date: 2012-02-27 01:26:47

Hi Ben,

Given a week has passed with the absence of any feedback
with respect to SRIO on 64 bit, are you OK with applying the
below patch[1] pretty much as-is?

Thanks,
Paul.

[1] http://patchwork.ozlabs.org/patch/142383/

---

On Tue, Feb 21, 2012 at 6:10 PM, Paul Gortmaker
[off-list ref] wrote:

The following are seen while using the corenet64_smp_defconfig:

arch/powerpc/sysdev/fsl_rmu.c:315: error: cast from pointer to integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:330: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:332: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:339: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:340: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:341: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:659: error: cast from pointer to integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:659: error: format '%8.8x' expects type 'un=

signed int', but argument 5 has type 'size_t'

arch/powerpc/sysdev/fsl_rmu.c:985: error: cast from pointer to integer of=

 different size

arch/powerpc/sysdev/fsl_rmu.c:997: error: cast to pointer from integer of=

 different size

quoted hunk

A quick inspection of the code leaves one with the impression
that it was not explicitly written with 64 bit support in mind,
so just block that as a possible config selection for now.

Signed-off-by: Paul Gortmaker <redacted>

---

[This is seen in linux-next -- not sure if this is the right way to go
=A0but at least it will give the issue some visibility to the right ppl.]

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 75f061e..5ad8013 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig

@@ -773,7 +773,7 @@ config RAPIDIO

=A0config FSL_RIO
=A0 =A0 =A0 =A0bool "Freescale Embedded SRIO Controller support"
- =A0 =A0 =A0 depends on RAPIDIO && HAS_RAPIDIO
+ =A0 =A0 =A0 depends on RAPIDIO && HAS_RAPIDIO && (BROKEN || !PPC64)
=A0 =A0 =A0 =A0default "n"
=A0 =A0 =A0 =A0---help---
=A0 =A0 =A0 =A0 =A0Include support for RapidIO controller on Freescale em=

bedded

--
1.7.9.1

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2012-02-27 01:50:14

On Sun, 2012-02-26 at 20:26 -0500, Paul Gortmaker wrote:

Hi Ben,

Given a week has passed with the absence of any feedback
with respect to SRIO on 64 bit, are you OK with applying the
below patch[1] pretty much as-is?

It can't hurt, I'll put it in. That's normally Kumar's side of things
but then with him leaving FSL things are a bit in flux right now.

Cheers,
Ben.

Thanks,
Paul.

[1] http://patchwork.ozlabs.org/patch/142383/

---

On Tue, Feb 21, 2012 at 6:10 PM, Paul Gortmaker
[off-list ref] wrote:

quoted

The following are seen while using the corenet64_smp_defconfig:

arch/powerpc/sysdev/fsl_rmu.c:315: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:320: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:330: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:332: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:339: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:340: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:341: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:348: error: cast to pointer from integer of different size
arch/powerpc/sysdev/fsl_rmu.c:659: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:659: error: format '%8.8x' expects type 'unsigned int', but argument 5 has type 'size_t'
arch/powerpc/sysdev/fsl_rmu.c:985: error: cast from pointer to integer of different size
arch/powerpc/sysdev/fsl_rmu.c:997: error: cast to pointer from integer of different size

A quick inspection of the code leaves one with the impression
that it was not explicitly written with 64 bit support in mind,
so just block that as a possible config selection for now.

Signed-off-by: Paul Gortmaker <redacted>

---

[This is seen in linux-next -- not sure if this is the right way to go
 but at least it will give the issue some visibility to the right ppl.]

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 75f061e..5ad8013 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig

@@ -773,7 +773,7 @@ config RAPIDIO

 config FSL_RIO
       bool "Freescale Embedded SRIO Controller support"
-       depends on RAPIDIO && HAS_RAPIDIO
+       depends on RAPIDIO && HAS_RAPIDIO && (BROKEN || !PPC64)
       default "n"
       ---help---
         Include support for RapidIO controller on Freescale embedded
--

1.7.9.1

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH/RFC] rapidio: temporarily exclude FSL_RIO from 64 bit builds

From: Liu Gang <hidden>
Date: 2012-02-27 06:49:56

On Sun, 2012-02-26 at 20:26 -0500, Paul Gortmaker wrote:

Hi Ben,

Given a week has passed with the absence of any feedback
with respect to SRIO on 64 bit, are you OK with applying the
below patch[1] pretty much as-is?

Hi, Paul, Ben,

Sorry for the late reply because of my other urgent issues. I also found
these errors of 64bit building last week. I'll provide patch for this
issue as soon as possible.

Thanks.

Best Regards,

Liu Gang

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help