[PATCH][v2] powerpc/85xx: Fix compiler error with THIS_MODULE and related

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE5261d

3 messages, 3 authors, 2012-03-16 · open the first message on its own page

[PATCH][v2] powerpc/85xx: Fix compiler error with THIS_MODULE and related

From: Claudiu Manoil <hidden>
Date: 2012-02-01 17:05:24

CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' undeclared here (not in a function)
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected declaration specifiers or '...' before string constant
cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function declaration isn't a prototype
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected declaration specifiers or '...' before string constant
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to 'int' in declaration of 'MODULE_LICENSE'
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function declaration isn't a prototype
make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1

...

  CC      arch/powerpc/sysdev/fsl_85xx_cache_sram.o
cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names (without types) in function declaration
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition has no type or storage class
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names (without types) in function declaration
make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1

Signed-off-by: Claudiu Manoil <redacted>
---
Replaced <linux/module.h> with <linux/export.h> for fsl_85xx_cache_sram.c.

 arch/powerpc/sysdev/fsl_85xx_cache_sram.c |    1 +
 arch/powerpc/sysdev/fsl_85xx_l2ctlr.c     |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
index 1164158..37a6909 100644
--- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
+++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c

@@ -24,6 +24,7 @@
  */
 
 #include <linux/kernel.h>
+#include <linux/export.h>
 #include <linux/slab.h>
 #include <linux/err.h>
 #include <linux/of_platform.h>

diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
index 5f88797..1957e53 100644
--- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
+++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c

@@ -21,6 +21,7 @@
  */
 
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/of_platform.h>
 #include <asm/io.h>

-- 
1.6.6

Re: [PATCH][v2] powerpc/85xx: Fix compiler error with THIS_MODULE and related

From: Paul Gortmaker <hidden>
Date: 2012-02-02 02:34:58

On Wed, Feb 1, 2012 at 12:05 PM, Claudiu Manoil
[off-list ref] wrote:

CC =A0 =A0 =A0arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' undecl=

ared here (not in a function)

Looks OK to me -- must be the 1st time this code has been
merged into the 3.2 baseline, since the export.h change was
news in the last release, and not anything new for 3.3.

Acked-by: Paul Gortmaker <redacted>

Paul.

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected declaration=

 specifiers or '...' before string constant

cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition has n=

o type or storage class

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to 'int=

' in declaration of 'MODULE_DESCRIPTION'

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function declaration=

 isn't a prototype

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected declaration=

 specifiers or '...' before string constant

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition has n=

o type or storage class

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to 'int=

' in declaration of 'MODULE_LICENSE'

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function declaration=

 isn't a prototype

make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1

...

=A0CC =A0 =A0 =A0arch/powerpc/sysdev/fsl_85xx_cache_sram.o
cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition ha=

s no type or storage class

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults to '=

int' in declaration of 'EXPORT_SYMBOL'

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names (w=

ithout types) in function declaration

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition ha=

s no type or storage class

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults to '=

int' in declaration of 'EXPORT_SYMBOL'

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names (w=

ithout types) in function declaration

make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1

Signed-off-by: Claudiu Manoil <redacted>
---
Replaced <linux/module.h> with <linux/export.h> for fsl_85xx_cache_sram.c=

quoted hunk

=A0arch/powerpc/sysdev/fsl_85xx_cache_sram.c | =A0 =A01 +
=A0arch/powerpc/sysdev/fsl_85xx_l2ctlr.c =A0 =A0 | =A0 =A01 +
=A02 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sys=

dev/fsl_85xx_cache_sram.c

quoted hunk

index 1164158..37a6909 100644

--- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
+++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c

@@ -24,6 +24,7 @@

=A0*/

=A0#include <linux/kernel.h>
+#include <linux/export.h>
=A0#include <linux/slab.h>
=A0#include <linux/err.h>
=A0#include <linux/of_platform.h>

diff --git a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c b/arch/powerpc/sysdev/=

fsl_85xx_l2ctlr.c

quoted hunk

index 5f88797..1957e53 100644

--- a/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c
+++ b/arch/powerpc/sysdev/fsl_85xx_l2ctlr.c

@@ -21,6 +21,7 @@

=A0*/

=A0#include <linux/kernel.h>
+#include <linux/module.h>
=A0#include <linux/of_platform.h>
=A0#include <asm/io.h>

--
1.6.6


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH][v2] powerpc/85xx: Fix compiler error with THIS_MODULE and related

From: Kumar Gala <hidden>
Date: 2012-03-16 19:39:53

On Feb 1, 2012, at 11:05 AM, Claudiu Manoil wrote:

CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' =

undeclared here (not in a function)

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected =

declaration specifiers or '...' before string constant

cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: data definition =

has no type or storage class

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:1: error: type defaults to =

'int' in declaration of 'MODULE_DESCRIPTION'

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: function =

declaration isn't a prototype

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: expected =

declaration specifiers or '...' before string constant

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: data definition =

has no type or storage class

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:1: error: type defaults to =

'int' in declaration of 'MODULE_LICENSE'

arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:230:16: error: function =

declaration isn't a prototype

make[1]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
=20
...
=20
 CC      arch/powerpc/sysdev/fsl_85xx_cache_sram.o
cc1: warnings being treated as errors
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: data definition =

has no type or storage class

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: type defaults =

to 'int' in declaration of 'EXPORT_SYMBOL'

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:69:1: error: parameter names =

(without types) in function declaration

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: data definition =

has no type or storage class

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: type defaults =

to 'int' in declaration of 'EXPORT_SYMBOL'

arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names =

(without types) in function declaration

make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1
=20
Signed-off-by: Claudiu Manoil <redacted>
---
Replaced <linux/module.h> with <linux/export.h> for =

fsl_85xx_cache_sram.c.

=20
arch/powerpc/sysdev/fsl_85xx_cache_sram.c |    1 +
arch/powerpc/sysdev/fsl_85xx_l2ctlr.c     |    1 +
2 files changed, 2 insertions(+), 0 deletions(-)


applied

- k=

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help