linux-next: build warnings after merge of the 4xx tree

3 messages, 3 authors, 2011-12-21 · open the first message on its own page

linux-next: build warnings after merge of the 4xx tree

From: Stephen Rothwell <hidden>
Date: 2011-12-21 00:14:04

Hi Josh,

After merging the 4xx tree, today's linux-next build (powerpc ppc64_defconfig)
produced these warnings:

WARN: Uncompressed kernel (size 0xe32858) overlaps the address of the wrapper()
WARN: Fixing the link_address of wrapper to (0xf00000)
WARN: Uncompressed kernel (size 0xd6c9e8) overlaps the address of the wrapper(0x400000)
WARN: Fixing the link_address of wrapper to (0xe00000)

Introduced by commit c55aef0e5bc6 ("powerpc/boot: Change the load address
for the wrapper to fit the kernel").   Maybe "WARN" is not the best
prefix for this.  To me it implies that something may go wrong and there
is something to be fixed ...  If this is purely informational, then maybe
"INFO" would be better.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build warnings after merge of the 4xx tree

From: Josh Boyer <hidden>
Date: 2011-12-21 01:11:20

On Tue, Dec 20, 2011 at 7:13 PM, Stephen Rothwell [off-list ref] wr=
ote:
Hi Josh,

After merging the 4xx tree, today's linux-next build (powerpc ppc64_defco=
nfig)
produced these warnings:

WARN: Uncompressed kernel (size 0xe32858) overlaps the address of the wra=
pper()
WARN: Fixing the link_address of wrapper to (0xf00000)
WARN: Uncompressed kernel (size 0xd6c9e8) overlaps the address of the wra=
pper(0x400000)
WARN: Fixing the link_address of wrapper to (0xe00000)

Introduced by commit c55aef0e5bc6 ("powerpc/boot: Change the load address
for the wrapper to fit the kernel"). =A0 Maybe "WARN" is not the best
prefix for this. =A0To me it implies that something may go wrong and ther=
e
is something to be fixed ... =A0If this is purely informational, then may=
be
"INFO" would be better.
INFO indeed would be better.  I'll try and whip up a patch tomorrow
unless Suzie beats me to it.

Sorry about that.  I saw the WARN during my testing, but the commit
log explicitly mentioned it an brainwashed me into thinking it was OK.
 I blame holiday-itis.

josh

[PATCH] [boot] Change the WARN to INFO for boot wrapper overlap message

From: Suzuki K. Poulose <hidden>
Date: 2011-12-21 07:20:56

commit c55aef0e5bc6 ("powerpc/boot: Change the load address
for the wrapper to fit the kernel") introduced a WARNING to
inform the user that the uncompressed kernel would overlap
the boot uncompressing wrapper code. Change it to an INFO.

I initially thought, this would be a 'WARNING' for the those
boards, where the link_address should be fixed, so that the
user can take actions accordingly.

Changing the same to INFO.

Signed-off-by: Suzuki K. Poulose <redacted>
---

 arch/powerpc/boot/wrapper |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index c8d6aaf..2b171cd 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -282,9 +282,9 @@ round_size=0x$(printf "%x" $round_size)
 link_addr=$(printf "%d" $link_address)
 
 if [ $link_addr -lt $strip_size ]; then
-    echo "WARN: Uncompressed kernel (size 0x$(printf "%x\n" $strip_size))" \
+    echo "INFO: Uncompressed kernel (size 0x$(printf "%x\n" $strip_size))" \
 		"overlaps the address of the wrapper($link_address)"
-    echo "WARN: Fixing the link_address of wrapper to ($round_size)"
+    echo "INFO: Fixing the link_address of wrapper to ($round_size)"
     link_address=$round_size
 fi
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help