linux-next: build warnings after merge of the final tree

6 messages, 3 authors, 2012-01-04 · open the first message on its own page

linux-next: build warnings after merge of the final tree

From: Stephen Rothwell <hidden>
Date: 2011-12-14 07:16:01

Hi all,

After merging the final tree, today's linux-next build (powerpc allyesconfig)
produced these warnings:

In file included from arch/powerpc/include/asm/asm-offsets.h:1:0,
                 from kernel/trace/trace_syscalls.c:9:
include/generated/asm-offsets.h:15:0: warning: "NMI_MASK" redefined [enabled by default]
include/linux/hardirq.h:56:0: note: this is the location of the previous definition
include/generated/asm-offsets.h:128:0: warning: "CLONE_VM" redefined [enabled by default]
include/linux/sched.h:8:0: note: this is the location of the previous definition
include/generated/asm-offsets.h:129:0: warning: "CLONE_UNTRACED" redefined [enabled by default]
include/linux/sched.h:22:0: note: this is the location of the previous definition
include/generated/asm-offsets.h:165:0: warning: "NSEC_PER_SEC" redefined [enabled by default]
include/linux/time.h:40:0: note: this is the location of the previous definition
include/generated/asm-offsets.h:173:0: warning: "PGD_TABLE_SIZE" redefined [enabled by default]
arch/powerpc/include/asm/pgtable-ppc64-4k.h:17:0: note: this is the location of the previous definition

Maybe caused by commit d5e553d6e0a4 ("trace: Include <asm/asm-offsets.h>
in trace_syscalls.c") from the tip tree.  These warnings may have been
here for a while as it is hard to catch the new ones among the flood.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build warnings after merge of the final tree

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2011-12-14 16:32:08

On Wed, 2011-12-14 at 18:15 +1100, Stephen Rothwell wrote:
Maybe caused by commit d5e553d6e0a4 ("trace: Include <asm/asm-offsets.h>
in trace_syscalls.c") from the tip tree.  These warnings may have been
here for a while as it is hard to catch the new ones among the flood.
hpa,

Was this change only needed for x86? If so, could you put that into
asm/ftrace.h instead?

-- Steve

Re: linux-next: build warnings after merge of the final tree

From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2011-12-14 16:47:47

On 12/14/2011 08:32 AM, Steven Rostedt wrote:
On Wed, 2011-12-14 at 18:15 +1100, Stephen Rothwell wrote:
quoted
Maybe caused by commit d5e553d6e0a4 ("trace: Include <asm/asm-offsets.h>
in trace_syscalls.c") from the tip tree.  These warnings may have been
here for a while as it is hard to catch the new ones among the flood.
hpa,

Was this change only needed for x86? If so, could you put that into
asm/ftrace.h instead?
Yes (on both accounts).  It was part of the syscall changes; I'll move
the include.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: linux-next: build warnings after merge of the final tree

From: Stephen Rothwell <hidden>
Date: 2011-12-22 05:33:19

Hi Peter,

On Wed, 14 Dec 2011 08:47:01 -0800 "H. Peter Anvin" [off-list ref] wrote:
On 12/14/2011 08:32 AM, Steven Rostedt wrote:
quoted
On Wed, 2011-12-14 at 18:15 +1100, Stephen Rothwell wrote:
quoted
Maybe caused by commit d5e553d6e0a4 ("trace: Include <asm/asm-offsets.h>
in trace_syscalls.c") from the tip tree.  These warnings may have been
here for a while as it is hard to catch the new ones among the flood.
hpa,

Was this change only needed for x86? If so, could you put that into
asm/ftrace.h instead?
Yes (on both accounts).  It was part of the syscall changes; I'll move
the include.
Ping?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build warnings after merge of the final tree

From: Stephen Rothwell <hidden>
Date: 2012-01-04 08:06:28

Hi again,

On Thu, 22 Dec 2011 16:33:04 +1100 Stephen Rothwell [off-list ref] wrote:
On Wed, 14 Dec 2011 08:47:01 -0800 "H. Peter Anvin" [off-list ref] wrote:
quoted
On 12/14/2011 08:32 AM, Steven Rostedt wrote:
quoted
On Wed, 2011-12-14 at 18:15 +1100, Stephen Rothwell wrote:
quoted
Maybe caused by commit d5e553d6e0a4 ("trace: Include <asm/asm-offsets.h>
in trace_syscalls.c") from the tip tree.  These warnings may have been
here for a while as it is hard to catch the new ones among the flood.
hpa,

Was this change only needed for x86? If so, could you put that into
asm/ftrace.h instead?
Yes (on both accounts).  It was part of the syscall changes; I'll move
the include.
Ping?
Can we please have this fixed ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build warnings after merge of the final tree

From: "hpanvin@gmail.com" <hpa@zytor.com>
Date: 2012-01-04 09:24:19

I thought it had been...?  Need to investigate (as baby permits...)

Stephen Rothwell [off-list ref] wrote:
Hi again,

On Thu, 22 Dec 2011 16:33:04 +1100 Stephen Rothwell
[off-list ref] wrote:
quoted
On Wed, 14 Dec 2011 08:47:01 -0800 "H. Peter Anvin" [off-list ref]
wrote:
quoted
quoted
On 12/14/2011 08:32 AM, Steven Rostedt wrote:
quoted
On Wed, 2011-12-14 at 18:15 +1100, Stephen Rothwell wrote:
quoted
Maybe caused by commit d5e553d6e0a4 ("trace: Include
<asm/asm-offsets.h>
quoted
quoted
quoted
quoted
in trace_syscalls.c") from the tip tree.  These warnings may
have been
quoted
quoted
quoted
quoted
here for a while as it is hard to catch the new ones among the
flood.
quoted
quoted
quoted
quoted
hpa,

Was this change only needed for x86? If so, could you put that
into
quoted
quoted
quoted
asm/ftrace.h instead?
Yes (on both accounts).  It was part of the syscall changes; I'll
move
quoted
quoted
the include.
Ping?
Can we please have this fixed ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help