Re: fpga driver on custom PPC target platform (P4080) ...

On Fri, Nov 04, 2011 at 02:19:36PM -0400, Robert Sciuk wrote:

quoted

quoted

I *believe* you are not supposed to create separate nodes for reading
and writing.  I know that's how I2C works, but I think the I2C layer
takes care of that for you.

If you look at other device trees, you'll see they only have one node
for any particular I2C device.

Thanks, Timur ... I've fixed the tree, and I'm tracking down the
problems with addressing the nodes ...

Ah,  my compatible attribute was wrong:

	Compatible = "nxp,pca9539";

	Should have been:

	Compatible = "nxp,pca953x";

The tree now seems to bind the i2c gpio drivers properly ... on to
the localbus mappings!

Ah.  In that case the drivers should probably be extended to recognize
the first compatible.  "wildcard" compatible strings are a bad idea,
unfortunately there are some already in the wild, as you've seen.  We
should try to phase them out though.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

quoted

Ah,  my compatible attribute was wrong:

	Compatible =3D "nxp,pca9539";

	Should have been:

	Compatible =3D "nxp,pca953x";

The tree now seems to bind the i2c gpio drivers properly ... on to
the localbus mappings!

=20
Ah.  In that case the drivers should probably be extended to recognize
the first compatible.  "wildcard" compatible strings are a bad idea,
unfortunately there are some already in the wild, as you've seen.  We
should try to phase them out though.
=20
--
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_
_other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Thanks, David

It did occur that a specific binding should be preferred over a generic =
one=20

Rob.