[PATCH] mtd/nand: Don't add disabled nand flash devices

Subsystems: memory technology devices (mtd), nand flash subsystem, the rest

STALE5498d

3 messages, 3 authors, 2011-08-22 · open the first message on its own page

[PATCH] mtd/nand: Don't add disabled nand flash devices

From: Chunhe Lan <hidden>
Date: 2011-08-16 09:25:14

Nand flash nodes with the property status="disabled" are not
usable and so avoid adding "disabled" nand flash devices with
the system.

Signed-off-by: Chunhe Lan <redacted>
---
 drivers/mtd/nand/fsl_elbc_nand.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 33d8aad..8212c12 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -1,6 +1,6 @@
 /* Freescale Enhanced Local Bus Controller NAND driver
  *
- * Copyright �� 2006-2007, 2010 Freescale Semiconductor
+ * Copyright �� 2006-2007, 2010-2011 Freescale Semiconductor
  *
  * Authors: Nick Spence <nick.spence@freescale.com>,
  *          Scott Wood <scottwood@freescale.com>
@@ -849,6 +849,9 @@ static int __devinit fsl_elbc_nand_probe(struct platform_device *pdev)
 	struct device *dev;
 	struct device_node *node = pdev->dev.of_node;
 
+	if (!of_device_is_available(node))
+		return -ENODEV;
+
 	if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs)
 		return -ENODEV;
 	lbc = fsl_lbc_ctrl_dev->regs;
-- 
1.5.6.5

Re: [PATCH] mtd/nand: Don't add disabled nand flash devices

From: Scott Wood <hidden>
Date: 2011-08-16 21:46:35

On 08/16/2011 04:27 AM, Chunhe Lan wrote:
quoted hunk
Nand flash nodes with the property status=3D"disabled" are not
usable and so avoid adding "disabled" nand flash devices with
the system.
=20
Signed-off-by: Chunhe Lan <redacted>
---
 drivers/mtd/nand/fsl_elbc_nand.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
=20
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_el=
bc_nand.c
quoted hunk
index 33d8aad..8212c12 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -1,6 +1,6 @@
 /* Freescale Enhanced Local Bus Controller NAND driver
  *
- * Copyright =C2=A9 2006-2007, 2010 Freescale Semiconductor
+ * Copyright =C2=A9 2006-2007, 2010-2011 Freescale Semiconductor
  *
  * Authors: Nick Spence <nick.spence@freescale.com>,
  *          Scott Wood <scottwood@freescale.com>
@@ -849,6 +849,9 @@ static int __devinit fsl_elbc_nand_probe(struct pla=
tform_device *pdev)
 	struct device *dev;
 	struct device_node *node =3D pdev->dev.of_node;
=20
+	if (!of_device_is_available(node))
+		return -ENODEV;
+
 	if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs)
 		return -ENODEV;
 	lbc =3D fsl_lbc_ctrl_dev->regs;
Same comment as the other patch -- unavailable devices should already
not be getting probed.  Also, this subject line makes it sound like this
is a NAND subsystem change rather than a change in one specific driver.

-Scott

Re: [PATCH] mtd/nand: Don't add disabled nand flash devices

From: Lan Chunhe <hidden>
Date: 2011-08-22 10:01:48

On Wed, 17 Aug 2011 05:46:29 +0800, Scott Wood [off-list ref]=
  =

wrote:
On 08/16/2011 04:27 AM, Chunhe Lan wrote:
quoted
Nand flash nodes with the property status=3D"disabled" are not
usable and so avoid adding "disabled" nand flash devices with
the system.

Signed-off-by: Chunhe Lan <redacted>
---
 drivers/mtd/nand/fsl_elbc_nand.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c  =
quoted
b/drivers/mtd/nand/fsl_elbc_nand.c
index 33d8aad..8212c12 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -1,6 +1,6 @@
 /* Freescale Enhanced Local Bus Controller NAND driver
  *
- * Copyright =C2=A9 2006-2007, 2010 Freescale Semiconductor
+ * Copyright =C2=A9 2006-2007, 2010-2011 Freescale Semiconductor
  *
  * Authors: Nick Spence <nick.spence@freescale.com>,
  *          Scott Wood <scottwood@freescale.com>
@@ -849,6 +849,9 @@ static int __devinit fsl_elbc_nand_probe(struct  =
quoted
platform_device *pdev)
 	struct device *dev;
 	struct device_node *node =3D pdev->dev.of_node;

+	if (!of_device_is_available(node))
+		return -ENODEV;
+
 	if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs)
 		return -ENODEV;
 	lbc =3D fsl_lbc_ctrl_dev->regs;
Same comment as the other patch -- unavailable devices should already
not be getting probed.  Also, this subject line makes it sound like th=
is
is a NAND subsystem change rather than a change in one specific driver=
.

    You are right.
    The upper layers have prevented unavailable devices.
    So, this patch is no need.

    Thanks.

    -Jack Lan
-Scott
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help