[PATCH] p1010rdb: gianfar config does not have queues.

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE5274d

4 messages, 3 authors, 2012-03-21 · open the first message on its own page

[PATCH] p1010rdb: gianfar config does not have queues.

From: Robin Holt <hidden>
Date: 2011-08-11 14:25:03 

If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
defined in the p1010's device tree file, I get a kernel panic very
shortly after boot.  The failure indicates we are configuring the
gianfar.c driver for a queue depth greater than actual.  Removing the
properties got the problem resolved.

Signed-off-by: Robin Holt <redacted>
To: U Bhaskar-B22300 <redacted>
Cc: PPC list <redacted>
Cc: Eric Dumazet <redacted>

diff --git a/arch/powerpc/boot/dts/p1010si.dtsi b/arch/powerpc/boot/dts/p1010si.dtsi
index 7f51104..91566aa 100644
--- a/arch/powerpc/boot/dts/p1010si.dtsi
+++ b/arch/powerpc/boot/dts/p1010si.dtsi
@@ -258,8 +258,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 
@@ -280,8 +278,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 
@@ -302,8 +298,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;

Re: [PATCH] p1010rdb: gianfar config does not have queues.

From: Kumar Gala <hidden>
Date: 2012-03-16 15:24:44 

On Aug 11, 2011, at 9:25 AM, Robin Holt wrote:

If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
defined in the p1010's device tree file, I get a kernel panic very
shortly after boot.  The failure indicates we are configuring the
gianfar.c driver for a queue depth greater than actual.  Removing the
properties got the problem resolved.
=20
Signed-off-by: Robin Holt <redacted>
To: U Bhaskar-B22300 <redacted>
Cc: PPC list <redacted>
Cc: Eric Dumazet <redacted>
Poonam,

Can you comment on this patch, does it look correct?

- k
quoted hunk
=20
diff --git a/arch/powerpc/boot/dts/p1010si.dtsi =
b/arch/powerpc/boot/dts/p1010si.dtsi
quoted hunk
index 7f51104..91566aa 100644
--- a/arch/powerpc/boot/dts/p1010si.dtsi
+++ b/arch/powerpc/boot/dts/p1010si.dtsi
@@ -258,8 +258,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;
=20
@@ -280,8 +278,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;
=20
@@ -302,8 +298,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;
=20
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

RE: [PATCH] p1010rdb: gianfar config does not have queues.

From: Aggrwal Poonam-B10812 <hidden>
Date: 2012-03-17 05:37:16 

Hello Pankaj, Rajan

DO you have any comments on the below patch of gianfar?
quoted
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
Have been removed from P1010RDB device tree to avoid a kernel panic.

Kumar, as such I see this is the old dts format. Also in the latest sdk tre=
e these properties are defined, not sure it is working on P1010RDB.
I can check on this and get back.


Regards
Poonam

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Friday, March 16, 2012 8:50 PM
To: Aggrwal Poonam-B10812
Cc: Robin Holt; U Bhaskar-B22300; PPC list; Eric Dumazet
Subject: Re: [PATCH] p1010rdb: gianfar config does not have queues.
=20
=20
On Aug 11, 2011, at 9:25 AM, Robin Holt wrote:
=20
quoted
If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
defined in the p1010's device tree file, I get a kernel panic very
shortly after boot.  The failure indicates we are configuring the
gianfar.c driver for a queue depth greater than actual.  Removing the
properties got the problem resolved.

Signed-off-by: Robin Holt <redacted>
To: U Bhaskar-B22300 <redacted>
Cc: PPC list <redacted>
Cc: Eric Dumazet <redacted>
=20
Poonam,
=20
Can you comment on this patch, does it look correct?
=20
- k
=20
quoted
diff --git a/arch/powerpc/boot/dts/p1010si.dtsi
b/arch/powerpc/boot/dts/p1010si.dtsi
index 7f51104..91566aa 100644
--- a/arch/powerpc/boot/dts/p1010si.dtsi
+++ b/arch/powerpc/boot/dts/p1010si.dtsi
@@ -258,8 +258,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;

@@ -280,8 +278,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;

@@ -302,8 +298,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
=20





  

    
Re: [PATCH] p1010rdb: gianfar config does not have queues.

    

      From: Kumar Gala <hidden>

      Date: 2012-03-21 15:26:21 
    

  

  
On Mar 17, 2012, at 12:37 AM, Aggrwal Poonam-B10812 wrote:

Hello Pankaj, Rajan
=20
DO you have any comments on the below patch of gianfar?
quoted
quoted
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
Have been removed from P1010RDB device tree to avoid a kernel panic.
=20
Ah, right.

Kumar, as such I see this is the old dts format. Also in the latest =
sdk tree these properties are defined, not sure it is working on =
P1010RDB.
I can check on this and get back.
Mostly, can you check that p1010rdb boots and works w/my next branch.

- k

=20
=20
Regards
Poonam
=20
quoted
-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Friday, March 16, 2012 8:50 PM
To: Aggrwal Poonam-B10812
Cc: Robin Holt; U Bhaskar-B22300; PPC list; Eric Dumazet
Subject: Re: [PATCH] p1010rdb: gianfar config does not have queues.
=20
=20
On Aug 11, 2011, at 9:25 AM, Robin Holt wrote:
=20
quoted
If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
defined in the p1010's device tree file, I get a kernel panic very
shortly after boot.  The failure indicates we are configuring the
gianfar.c driver for a queue depth greater than actual.  Removing =
the
quoted
quoted
properties got the problem resolved.
=20
Signed-off-by: Robin Holt <redacted>
To: U Bhaskar-B22300 <redacted>
Cc: PPC list <redacted>
Cc: Eric Dumazet <redacted>
=20
Poonam,
=20
Can you comment on this patch, does it look correct?
=20
- k
=20
quoted
=20
diff --git a/arch/powerpc/boot/dts/p1010si.dtsi
b/arch/powerpc/boot/dts/p1010si.dtsi
index 7f51104..91566aa 100644
--- a/arch/powerpc/boot/dts/p1010si.dtsi
+++ b/arch/powerpc/boot/dts/p1010si.dtsi
@@ -258,8 +258,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;
=20
@@ -280,8 +278,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;
=20
@@ -302,8 +298,6 @@
			device_type =3D "network";
			model =3D "eTSEC";
			compatible =3D "fsl,etsec2";
-			fsl,num_rx_queues =3D <0x8>;
-			fsl,num_tx_queues =3D <0x8>;
			local-mac-address =3D [ 00 00 00 00 00 00 ];
			interrupt-parent =3D <&mpic>;
=20
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
=20
=20




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help