[PATCH] perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE5382d

5 messages, 3 authors, 2011-11-27 · open the first message on its own page

[PATCH] perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

From: Anshuman Khandual <hidden>
Date: 2011-08-30 04:43:54

perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

	Extent the POWER7 PMU driver with definitions
	for generic front-end and back-end stall events.

Signed-off-by: Anshuman Khandual <redacted>
diff --git a/arch/powerpc/kernel/power7-pmu.c b/arch/powerpc/kernel/power7-pmu.c
index 593740f..e5d2844 100644
--- a/arch/powerpc/kernel/power7-pmu.c
+++ b/arch/powerpc/kernel/power7-pmu.c
@@ -297,6 +297,8 @@ static void power7_disable_pmc(unsigned int pmc, unsigned long mmcr[])
 
 static int power7_generic_events[] = {
 	[PERF_COUNT_HW_CPU_CYCLES] = 0x1e,
+	[PERF_COUNT_HW_STALLED_CYCLES_FRONTEND] = 0x100f8, /* GCT_NOSLOT_CYC */
+	[PERF_COUNT_HW_STALLED_CYCLES_BACKEND] = 0x4000a,  /* CMPLU_STALL */
 	[PERF_COUNT_HW_INSTRUCTIONS] = 2,
 	[PERF_COUNT_HW_CACHE_REFERENCES] = 0xc880,	/* LD_REF_L1_LSU*/
 	[PERF_COUNT_HW_CACHE_MISSES] = 0x400f0,		/* LD_MISS_L1	*/
-- 
Anshuman Khandual 

Re: [PATCH] perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

From: Michael Neuling <hidden>
Date: 2011-09-09 01:38:12

perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

	Extent the POWER7 PMU driver with definitions
	for generic front-end and back-end stall events.
Anshuman,

Can you explain what these P7 events actually are and how they relate to
Ingo's original comment on this in
8f62242246351b5a4bc0c1f00c0c7003edea128a

    Both events limit performance: most front end stalls tend to be
    caused by branch misprediction or instruction fetch cachemisses,
    backend stalls can be caused by various resource shortages or
    inefficient instruction scheduling.
quoted hunk
Signed-off-by: Anshuman Khandual <redacted>
diff --git a/arch/powerpc/kernel/power7-pmu.c b/arch/powerpc/kernel/power7-pmu.c
index 593740f..e5d2844 100644
--- a/arch/powerpc/kernel/power7-pmu.c
+++ b/arch/powerpc/kernel/power7-pmu.c
@@ -297,6 +297,8 @@ static void power7_disable_pmc(unsigned int pmc, unsigned long mmcr[])
 
 static int power7_generic_events[] = {
 	[PERF_COUNT_HW_CPU_CYCLES] = 0x1e,
+	[PERF_COUNT_HW_STALLED_CYCLES_FRONTEND] = 0x100f8, /* GCT_NOSLOT_CYC */
eg. Is this Global Completion Table (GCT) empty?
+	[PERF_COUNT_HW_STALLED_CYCLES_BACKEND] = 0x4000a,  /* CMPLU_STALL */
eg. Is this instruction completion stall?

Mikey
 	[PERF_COUNT_HW_INSTRUCTIONS] = 2,
 	[PERF_COUNT_HW_CACHE_REFERENCES] = 0xc880,	/* LD_REF_L1_LSU*/
 	[PERF_COUNT_HW_CACHE_MISSES] = 0x400f0,		/* LD_MISS_L1	*/

-- 
Anshuman Khandual 


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

From: Anshuman Khandual <hidden>
Date: 2011-09-09 06:19:11

On Friday 09 September 2011 07:08 AM, Michael Neuling wrote:
quoted
perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

	Extent the POWER7 PMU driver with definitions
	for generic front-end and back-end stall events.
Anshuman,

Can you explain what these P7 events actually are and how they relate to
Ingo's original comment on this in
8f62242246351b5a4bc0c1f00c0c7003edea128a

    Both events limit performance: most front end stalls tend to be
    caused by branch misprediction or instruction fetch cachemisses,
    backend stalls can be caused by various resource shortages or
    inefficient instruction scheduling.
As explained in Ingo's original comment, the exact definitions of the stall 
events are very much processor specific as different things mean different in
their respective instruction pipeline. These two Power7 raw events are the closest 
approximation to the concept detailed in Ingo's comment.    
quoted
Signed-off-by: Anshuman Khandual <redacted>
diff --git a/arch/powerpc/kernel/power7-pmu.c b/arch/powerpc/kernel/power7-pmu.c
index 593740f..e5d2844 100644
--- a/arch/powerpc/kernel/power7-pmu.c
+++ b/arch/powerpc/kernel/power7-pmu.c
@@ -297,6 +297,8 @@ static void power7_disable_pmc(unsigned int pmc, unsigned long mmcr[])
 
 static int power7_generic_events[] = {
 	[PERF_COUNT_HW_CPU_CYCLES] = 0x1e,
+	[PERF_COUNT_HW_STALLED_CYCLES_FRONTEND] = 0x100f8, /* GCT_NOSLOT_CYC */
eg. Is this Global Completion Table (GCT) empty?
Yes, it means cycles when the Global Completion Table has no slots from this thread
quoted
+	[PERF_COUNT_HW_STALLED_CYCLES_BACKEND] = 0x4000a,  /* CMPLU_STALL */
eg. Is this instruction completion stall?
Yes, it means no groups completed and GCT not empty
Mikey
quoted
 	[PERF_COUNT_HW_INSTRUCTIONS] = 2,
 	[PERF_COUNT_HW_CACHE_REFERENCES] = 0xc880,	/* LD_REF_L1_LSU*/
 	[PERF_COUNT_HW_CACHE_MISSES] = 0x400f0,		/* LD_MISS_L1	*/

-- 
Anshuman Khandual 


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

-- 
Anshuman Khandual 
LTC India 

Re: [PATCH] perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

From: Michael Neuling <hidden>
Date: 2011-09-09 06:26:29

In message [off-list ref] you wrote:
On Friday 09 September 2011 07:08 AM, Michael Neuling wrote:
quoted
quoted
perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

	Extent the POWER7 PMU driver with definitions
	for generic front-end and back-end stall events.
Anshuman,

Can you explain what these P7 events actually are and how they relate to
Ingo's original comment on this in
8f62242246351b5a4bc0c1f00c0c7003edea128a

    Both events limit performance: most front end stalls tend to be
    caused by branch misprediction or instruction fetch cachemisses,
    backend stalls can be caused by various resource shortages or
    inefficient instruction scheduling.
As explained in Ingo's original comment, the exact definitions of the
stall events are very much processor specific as different things mean
different in their respective instruction pipeline. These two Power7
raw events are the closest approximation to the concept detailed in
Ingo's comment.
quoted
quoted
Signed-off-by: Anshuman Khandual <redacted>
diff --git a/arch/powerpc/kernel/power7-pmu.c b/arch/powerpc/kernel/power7
-pmu.c
quoted
quoted
index 593740f..e5d2844 100644
--- a/arch/powerpc/kernel/power7-pmu.c
+++ b/arch/powerpc/kernel/power7-pmu.c
@@ -297,6 +297,8 @@ static void power7_disable_pmc(unsigned int pmc, unsig
ned long mmcr[])
quoted
quoted
 
 static int power7_generic_events[] = {
 	[PERF_COUNT_HW_CPU_CYCLES] = 0x1e,
+	[PERF_COUNT_HW_STALLED_CYCLES_FRONTEND] = 0x100f8, /* GCT_NOSLOT_CYC */
eg. Is this Global Completion Table (GCT) empty?
Yes, it means cycles when the Global Completion Table has no slots from this thread
quoted
quoted
+ [PERF_COUNT_HW_STALLED_CYCLES_BACKEND] = 0x4000a, /* CMPLU_STALL
*/
quoted
eg. Is this instruction completion stall?
Yes, it means no groups completed and GCT not empty
I agree, I think they match what Ingo is trying to achieve.

Can you add these descriptions to the patch and resubmit please?

If you can find similar events for power4/5/5+/6 that would be great too
submit too.  

FWIW, the patch compiles and runs for me.  

Mikey

Re: [PATCH] perf events, powerpc: Add POWER7 stalled-cycles-frontend/backend events

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2011-11-27 22:41:04

On Fri, 2011-09-09 at 16:26 +1000, Michael Neuling wrote:
I agree, I think they match what Ingo is trying to achieve.

Can you add these descriptions to the patch and resubmit please?

If you can find similar events for power4/5/5+/6 that would be great too
submit too.  

FWIW, the patch compiles and runs for me.  
I already put it in my next branch, but feel free to send a followup
patch adding some comments if you think that's worthwhile.

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help