[PATCH] powerpc/85xx: fix race bug of calling request_irq after enable elbc interrupts

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE5551d

2 messages, 2 authors, 2011-06-03 · open the first message on its own page

[PATCH] powerpc/85xx: fix race bug of calling request_irq after enable elbc interrupts

From: Shaohui Xie <hidden>
Date: 2011-06-03 03:35:52

Signed-off-by: Shaohui Xie <redacted>
Signed-off-by: Kumar Gala <redacted>
---
 arch/powerpc/sysdev/fsl_lbc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_lbc.c b/arch/powerpc/sysdev/fsl_lbc.c
index e0292c3..9e7cb19 100644
--- a/arch/powerpc/sysdev/fsl_lbc.c
+++ b/arch/powerpc/sysdev/fsl_lbc.c
@@ -200,9 +200,6 @@ static int __devinit fsl_lbc_ctrl_init(struct fsl_lbc_ctrl *ctrl,
 	out_be32(&lbc->lteccr, LTECCR_CLEAR);
 	out_be32(&lbc->ltedr, LTEDR_ENABLE);
 
-	/* Enable interrupts for any detected events */
-	out_be32(&lbc->lteir, LTEIR_ENABLE);
-
 	/* Set the monitor timeout value to the maximum for erratum A001 */
 	if (of_device_is_compatible(node, "fsl,elbc"))
 		clrsetbits_be32(&lbc->lbcr, LBCR_BMT, LBCR_BMTPS);
@@ -340,6 +337,9 @@ static int __devinit fsl_lbc_ctrl_probe(struct of_device *ofdev,
 		goto err;
 	}
 
+	/* Enable interrupts for any detected events */
+	out_be32(&fsl_lbc_ctrl_dev->regs->lteir, LTEIR_ENABLE);
+
 	return 0;
 
 err:
-- 
1.6.4

Re: [PATCH] powerpc/85xx: fix race bug of calling request_irq after enable elbc interrupts

From: Kumar Gala <hidden>
Date: 2011-06-03 07:57:34

On Jun 2, 2011, at 9:45 PM, Shaohui Xie wrote:
Signed-off-by: Shaohui Xie <redacted>
Signed-off-by: Kumar Gala <redacted>
---
arch/powerpc/sysdev/fsl_lbc.c |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
applied to merge

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help