mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec"

2 messages, 2 authors, 2011-02-23 · open the first message on its own page

mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec"

From: Moffett, Kyle D <hidden>
Date: 2011-02-23 21:07:54

Hello everyone,

I just started trying to update some patches for our P2020-based unit to th=
e latest Linus upstream, hoping to take advantage of the recent mpc85xx kex=
ec() support.

Unfortunately I'm getting a compile error:

arch/powerpc/platforms/85xx/smp.c:241: error: 'struct machdep_calls' has no=
 member named 'machine_kexec'

As far as I can tell, "machine_kexec" was removed in commit c9486878 (power=
pc/kexec: Remove ppc_md.machine_kexec) on Jan 6th, 2011, which claims that =
it was not used.

Unfortunately it looks like it *is* used by the mpc85xx kexec() support (co=
mmit f933a41e), added on Jul 21, 2010.

Cheers,
Kyle Moffett

Re: mpc85xx: kexec build broken by "powerpc/kexec: Remove ppc_md.machine_kexec"

From: Anton Blanchard <hidden>
Date: 2011-02-23 22:11:27

Hi Kyle,
As far as I can tell, "machine_kexec" was removed in commit c9486878
(powerpc/kexec: Remove ppc_md.machine_kexec) on Jan 6th, 2011, which
claims that it was not used.

Unfortunately it looks like it *is* used by the mpc85xx kexec()
support (commit f933a41e), added on Jul 21, 2010.
Thanks for the report. Testing a patch now.

Anton
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help