a4f740cf33f7f6c164bbde3c0cdbcc77b0c4997c introduces:
/arch/powerpc/platforms/83xx/mpc831x_rdb.c:63: error: expected '{'
before 'const'
and more...
This hunk is obviously bogus:
+struct const char *board[] __initdata = {
+ "MPC8313ERDB",
+ "fsl,mpc8315erdb",
+ NULL
+}
+
You should at least compile test your changes :-(
Please send Linus a fix.
Cheers,
Ben.
Hi Ben,
On Fri, 21 Jan 2011 13:15:22 +1100 Benjamin Herrenschmidt [off-list ref] wrote:
a4f740cf33f7f6c164bbde3c0cdbcc77b0c4997c introduces:
/arch/powerpc/platforms/83xx/mpc831x_rdb.c:63: error: expected '{'
before 'const'
and more...
This hunk is obviously bogus:
+struct const char *board[] __initdata = {
+ "MPC8313ERDB",
+ "fsl,mpc8315erdb",
+ NULL
+}
+
You should at least compile test your changes :-(
Please send Linus a fix.
Its already in Grant's devicetree/merge branch (which I assume he will
ask you to pull soon) and has been in linux-next for the past 2 days.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
On Thu, Jan 20, 2011 at 7:15 PM, Benjamin Herrenschmidt
[off-list ref] wrote:
a4f740cf33f7f6c164bbde3c0cdbcc77b0c4997c introduces:
/arch/powerpc/platforms/83xx/mpc831x_rdb.c:63: error: expected '{'
before 'const'
=A0and more...
This hunk is obviously bogus:
+struct const char *board[] __initdata =3D {
+ =A0 =A0 =A0 "MPC8313ERDB",
+ =A0 =A0 =A0 "fsl,mpc8315erdb",
+ =A0 =A0 =A0 NULL
+}
+
You should at least compile test your changes :-(
I do. Always. Over Christmas I even set up an autotest instance to
automate a bunch of the sanity testing so I'd get better coverage, and
I always get changes into linux-next, this commit included. Sometimes
I miss a configuration though, and I apologize. Sorry.
Please send Linus a fix.
I wrote and pushed out the fix yesterday and I just sent Linus the pull req=
.
g.