linux-2.6.36-rc3 bug report

Hello there=2C

I just tried out cppcheck-1.44 on the linux-2.6.36-rc3 source code.

It said

Checking arch/powerpc/kernel/ppc970-pmu.c...
[arch/powerpc/kernel/ppc970-pmu.c:171]: (style) Redundant assignment of "ma=
sk" in switch

The source code is

=A0=A0=A0=A0=A0=A0=A0 case PM_VPU:
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 mask =3D 0x4c=3B=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0 /* byte 0 bits 2=2C3=2C6 */
=A0=A0=A0=A0=A0=A0=A0 case PM_LSU0:
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* byte 2 bits 0=2C2=2C3=2C4=
=2C6=3B all of byte 1 */
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 mask =3D 0x085dff00=3B
=A0=A0=A0=A0=A0=A0=A0 case PM_LSU1L:
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 mask =3D 0x50 << 24=3B=A0=A0=
=A0=A0=A0 /* byte 3 bits 4=2C6 */
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 break=3B

It looks to me like a missing break on the first and second cases.
Suggest code rework.

Regards

David Binderman

 		 	   		  =