[PATCH] mmc_spi: Fix unterminated of_match_table

Subsystems: multimedia card (mmc) etc. over spi, multimedia card (mmc), secure digital (sd) and sdio subsystem, the rest

STALE5850d

2 messages, 2 authors, 2010-08-08 · open the first message on its own page

[PATCH] mmc_spi: Fix unterminated of_match_table

From: Anton Vorontsov <hidden>
Date: 2010-08-08 14:14:25

commit 2ffe8c5f323c3b9749bf7bc2375d909d20bdbb15 ("of: refactor
of_modalias_node() and remove explicit match table"), introduced
an unterminated of_match_table, which may cause kernel to oops.

This patch fixes the issue by adding an empty device ID.

Signed-off-by: Anton Vorontsov <redacted>
---
 drivers/mmc/host/mmc_spi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 7b0f3ef..1145ea0 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1536,6 +1536,7 @@ static int __devexit mmc_spi_remove(struct spi_device *spi)
 #if defined(CONFIG_OF)
 static struct of_device_id mmc_spi_of_match_table[] __devinitdata = {
 	{ .compatible = "mmc-spi-slot", },
+	{},
 };
 #endif
 
-- 
1.7.0.5

Re: [PATCH] mmc_spi: Fix unterminated of_match_table

From: Grant Likely <hidden>
Date: 2010-08-08 15:03:05

On Sun, Aug 8, 2010 at 8:14 AM, Anton Vorontsov [off-list ref] wro=
te:
commit 2ffe8c5f323c3b9749bf7bc2375d909d20bdbb15 ("of: refactor
of_modalias_node() and remove explicit match table"), introduced
an unterminated of_match_table, which may cause kernel to oops.

This patch fixes the issue by adding an empty device ID.

Signed-off-by: Anton Vorontsov <redacted>
Thanks Anton.  Merged into my next-devicetree branch.

g.
quoted hunk
---
=A0drivers/mmc/host/mmc_spi.c | =A0 =A01 +
=A01 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 7b0f3ef..1145ea0 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1536,6 +1536,7 @@ static int __devexit mmc_spi_remove(struct spi_devi=
ce *spi)
=A0#if defined(CONFIG_OF)
=A0static struct of_device_id mmc_spi_of_match_table[] __devinitdata =3D =
{
=A0 =A0 =A0 =A0{ .compatible =3D "mmc-spi-slot", },
+ =A0 =A0 =A0 {},
=A0};
=A0#endif

--
1.7.0.5


--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help